Fix bugs and code smells

Author: diegorodriguez31

src/main/java/fr/cnes/sonar/plugins/icode/languages/ICodeQualityProfiles.java

@@ -42,8 +42,8 @@ public final class ICodeQualityProfiles implements BuiltInQualityProfilesDefinit
      */
     @Override
     public void define(final Context context) {
-        createBuiltInProfile(context, ICodeRulesDefinition.FORTRAN77_REPOSITORY, Fortran77Language.KEY, ICodeRulesDefinition.getF77Rules());
-        createBuiltInProfile(context, ICodeRulesDefinition.FORTRAN90_REPOSITORY, Fortran90Language.KEY, ICodeRulesDefinition.getF90Rules());
+        createBuiltInProfile(context, ICodeRulesDefinition.FORTRAN77_REPOSITORY, Fortran77Language.KEY, ICodeRulesDefinition.f77Rules);
+        createBuiltInProfile(context, ICodeRulesDefinition.FORTRAN90_REPOSITORY, Fortran90Language.KEY, ICodeRulesDefinition.f90Rules);
     }
 
     /**

src/main/java/fr/cnes/sonar/plugins/icode/rules/ICodeRulesDefinition.java

@@ -61,8 +61,8 @@ public class ICodeRulesDefinition implements RulesDefinition {
 	/** Path to xml file in resources tree (fortran 90 rules). **/
 	public static final String PATH_TO_F90_RULES_XML = "/rules/icode-f90-rules.xml";
 
-	private static List<NewRule> f77Rules;
-	private static List<NewRule> f90Rules;
+	public static List<NewRule> f77Rules;
+	public static List<NewRule> f90Rules;
 
 	/**
 	 * Define i-Code rules in SonarQube thanks to xml configuration files.
@@ -151,12 +151,4 @@ protected List<NewRule> createFortranRepository(final Context context, final Str
     public static String getRepositoryKeyForLanguage(final String language) {
         return language + REPO_KEY_SUFFIX;
     }
-
-	public static List<NewRule> getF77Rules() {
-		return f77Rules;
-	}
-
-	public static List<NewRule> getF90Rules() {
-		return f90Rules;
-	}
 }

src/test/java/fr/cnes/sonar/plugins/icode/measures/ICodeMetricsProcessorTest.java

@@ -21,7 +21,7 @@
 import fr.cnes.sonar.plugins.icode.model.AnalysisRule;
 import fr.cnes.sonar.plugins.icode.model.Result;
 import org.junit.Assert;
-import org.junit.Before;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
@@ -43,7 +43,7 @@
 import java.util.List;
 import java.util.Map;
 
-public class ICodeMetricsProcessorTest {
+class ICodeMetricsProcessorTest {
 
     private DefaultFileSystem fs;
     private SensorContextTester context;
@@ -53,7 +53,7 @@ public class ICodeMetricsProcessorTest {
     private DefaultInputFile clanhb_f;
     private DefaultInputFile clanhb_f90;
 
-    @Before
+    @BeforeEach
     public void prepare() throws URISyntaxException {
         final URI projectPath = ICodeMetricsProcessor.class.getResource("/project").toURI();
         fs = new DefaultFileSystem(new File(projectPath));
@@ -92,7 +92,7 @@ private static Stream<Arguments> testData() {
 
     @ParameterizedTest
     @MethodSource("testData")
-    public void test_compute_metrics(AnalysisRuleTestData testData) {
+    void test_compute_metrics(AnalysisRuleTestData testData) {
         final AnalysisProject project = new AnalysisProject();
         final String key = clanhb_f.key();
 
@@ -112,17 +112,17 @@ public void test_compute_metrics(AnalysisRuleTestData testData) {
     }
 
     @Test
-    public void test_is_metric_true() {
+    void test_is_metric_true() {
         Assert.assertTrue(ICodeMetricsProcessor.isMetric("SH.MET.COCO"));
     }
 
     @Test
-    public void test_is_metric_false() {
+    void test_is_metric_false() {
         Assert.assertFalse(ICodeMetricsProcessor.isMetric("COCO"));
     }
 
     @Test
-    public void test_save_extra_measure_with_null_location() {
+    void test_save_extra_measure_with_null_location() {
         // If we upgrade to Junit5, we may check @ParametrizedTest annotation
         String[] locations = {null, "", "method"};
         int[] expectedResults = {0, 0, 1};
@@ -143,7 +143,7 @@ public void test_save_extra_measure_with_null_location() {
     }
 
     @Test
-    public void test_save_nominal_measures() {
+    void test_save_nominal_measures() {
 
         final String key = clanhb_f.key();
         rule.setResult(new Result());