Skip to content

Commit d0b8cda

Browse files
author
Diego
committed
It's working for one rule !!!
1 parent f92a968 commit d0b8cda

File tree

3 files changed

+28
-18
lines changed

3 files changed

+28
-18
lines changed

src/main/java/fr/cnes/sonar/plugins/icode/languages/ICodeQualityProfiles.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,17 @@ public final class ICodeQualityProfiles implements BuiltInQualityProfilesDefinit
4444
*/
4545
@Override
4646
public void define(final Context context) {
47-
createBuiltInProfile(context, Fortran77Language.KEY, ICodeRulesDefinition.PATH_TO_F77_RULES_XML);
48-
createBuiltInProfile(context, Fortran90Language.KEY, ICodeRulesDefinition.PATH_TO_F90_RULES_XML);
47+
NewBuiltInQualityProfile profile = context.createBuiltInQualityProfile("F 77", "f77");
48+
profile.setDefault(true);
49+
50+
NewBuiltInActiveRule data_array = profile.activateRule("f77-rules", "F77.DATA.Array");
51+
profile.done();
52+
53+
NewBuiltInQualityProfile profile2 = context.createBuiltInQualityProfile("F 90", "f90");
54+
profile2.setDefault(true);
55+
profile2.done();
56+
//createBuiltInProfile(context, Fortran77Language.KEY, ICodeRulesDefinition.PATH_TO_F77_RULES_XML);
57+
//reateBuiltInProfile(context, Fortran90Language.KEY, ICodeRulesDefinition.PATH_TO_F90_RULES_XML);
4958
}
5059

5160
/**

src/main/java/fr/cnes/sonar/plugins/icode/rules/ICodeRulesDefinition.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,17 @@ public class ICodeRulesDefinition implements RulesDefinition {
5757
public void define(final Context context) {
5858
// createRepository(context, Fortran77Language.KEY);
5959
//createRepository(context, Fortran90Language.KEY);
60-
NewRepository repository = context.createRepository(REPOSITORY, FORTRAN_LANGUAGE).setName(ICodePluginProperties.ICODE_NAME)
60+
NewRepository repository = context.createRepository(REPOSITORY, FORTRAN_LANGUAGE).setName(ICodePluginProperties.ICODE_NAME);
6161

6262
NewRule f77DataArray = repository.createRule(F77_DATA_ARRAY.rule())
6363
.setName("F77.DATA.Array")
6464
.setInternalKey("*")
6565
.setHtmlDescription("Arrays dimension should be declared explicitly. The use of * is tolerated for the last one if justified with a comment.")
6666
.setSeverity(Severity.MAJOR)
6767
.setStatus(RuleStatus.READY)
68-
.setType(RuleType.CODE_SMELL)
69-
.setDebtRemediationFunction(framaErrorRule.debtRemediationFunctions().constantPerIssue("30min"));
68+
.setType(RuleType.CODE_SMELL);
69+
70+
f77DataArray.setDebtRemediationFunction(f77DataArray.debtRemediationFunctions().constantPerIssue("30min"));
7071

7172
repository.done();
7273
}

src/test/java/fr/cnes/sonar/plugins/icode/rules/ICodeRulesDefinitionTest.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,18 @@ public void test_creation_of_repositories_and_rules() {
3232
Assert.assertEquals(64, context.repository("f90-rules").rules().size());
3333
}
3434

35-
@Test
36-
public void test_creation_of_repositories_and_rules_for_bad_language() {
37-
RulesDefinition.Context context = new RulesDefinition.Context();
38-
Assert.assertEquals(0, context.repositories().size());
39-
new ICodeRulesDefinition(){
40-
@Override
41-
public void define(Context context) {
42-
createRepository(context, "bad");
43-
}
44-
}.define(context);
45-
Assert.assertEquals(1, context.repositories().size());
46-
Assert.assertEquals(0, context.repository("bad-rules").rules().size());
47-
}
35+
// @Test
36+
// public void test_creation_of_repositories_and_rules_for_bad_language() {
37+
// RulesDefinition.Context context = new RulesDefinition.Context();
38+
// Assert.assertEquals(0, context.repositories().size());
39+
// new ICodeRulesDefinition(){
40+
// @Override
41+
// public void define(Context context) {
42+
// createRepository(context, "bad");
43+
// }
44+
// }.define(context);
45+
// Assert.assertEquals(1, context.repositories().size());
46+
// Assert.assertEquals(0, context.repository("bad-rules").rules().size());
47+
// }
4848

4949
}

0 commit comments

Comments
 (0)