Skip to content

Commit d213d86

Browse files
committed
Check if a expected rule has been imported from ICode CNES (always true)
1 parent 15031a1 commit d213d86

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

src/main/java/fr/cnes/sonarqube/plugins/icode/rules/ICodeRulesDefinition.java

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,15 @@
2424
import java.util.ArrayList;
2525
import java.util.Collection;
2626
import java.util.List;
27+
import java.util.Map;
2728

29+
import org.sonar.api.internal.apachecommons.lang.StringUtils;
30+
import org.sonar.api.internal.google.common.base.Objects;
31+
import org.sonar.api.internal.google.common.collect.Maps;
2832
import org.sonar.api.server.rule.RulesDefinition;
2933
import org.sonar.api.server.rule.RulesDefinitionXmlLoader;
34+
import org.sonar.api.server.rule.RulesDefinition.NewRepository;
35+
import org.sonar.api.server.rule.RulesDefinition.NewRepositoryImpl;
3036
import org.sonar.api.server.rule.RulesDefinition.NewRule;
3137

3238
import fr.cnes.sonarqube.plugins.icode.languages.ICodeLanguage;
@@ -47,7 +53,6 @@ public final class ICodeRulesDefinition implements RulesDefinition {
4753
protected static final String REPO_NAME = ICodeLanguage.NAME;
4854

4955
private static NewRepository repository;
50-
private static List<String> allRuleIds = new ArrayList<String>();
5156

5257
protected String rulesDefinitionFilePath() {
5358
return PATH_TO_RULES_XML;
@@ -63,11 +68,6 @@ private void defineRulesForLanguage(Context context, String repositoryKey, Strin
6368
rulesLoader.load(repository, rulesXml, StandardCharsets.UTF_8.name());
6469
}
6570
repository.done();
66-
Collection<NewRule> col = repository.rules();
67-
allRuleIds = new ArrayList<String>();
68-
for (NewRule newRule : col) {
69-
allRuleIds.add(newRule.key());
70-
}
7171
}
7272

7373
@Override
@@ -79,7 +79,13 @@ public static String getRepositoryKeyForLanguage() {
7979
return ICodeLanguage.KEY + "-" + KEY;
8080
}
8181

82+
/** Check if the ruleKey exist.
83+
*
84+
* @param analysisRuleId
85+
* @return Always true with ICode
86+
*/
8287
public static boolean existRule(String analysisRuleId){
83-
return allRuleIds.contains(analysisRuleId);
88+
return true;
8489
}
8590
}
91+

0 commit comments

Comments
 (0)