src: fix atom increase/decrease count issue

Author: JacksonTian

app/controller/reply.js

@@ -39,19 +39,13 @@ class ReplyController extends Controller {
     const user_id = ctx.user._id;
     const topicAuthor = await service.user.getUserById(topic.author_id);
     const newContent = content.replace('@' + topicAuthor.loginname + ' ', '');
-    const [
-      reply, user,
-    ] = await Promise.all([
-      service.reply.newAndSave(content, topic_id, user_id, reply_id),
-      service.user.getUserById(user_id),
-    ]);
+    const reply = await service.reply.newAndSave(content, topic_id, user_id, reply_id);
 
-    user.score += 5;
-    user.reply_count += 1;
     await Promise.all([
+      service.user.incrementScoreAndReplyCount(user_id, 5, 1),
       service.topic.updateLastReply(topic_id, reply._id),
-      user.save(),
     ]);
+
     service.at.sendMessageToMentionUsers(newContent, topic_id, user_id, reply._id);
     if (topic.author_id.toString() !== user_id.toString()) {
       await service.message.sendReplyMessage(topic.author_id, user_id, topic._id, reply._id);

app/controller/topic.js

@@ -33,8 +33,10 @@ class TopicController extends Controller {
 
     const [ topic, author, replies ] = await service.topic.getFullTopic(topic_id);
 
+    // 增加 visit_count
     topic.visit_count += 1;
-    await topic.save();
+    // 写入 DB
+    await service.topic.incrementVisitCount(topic_id);
 
     topic.author = author;
     topic.replies = replies;
@@ -143,11 +145,7 @@ class TopicController extends Controller {
     );
 
     // 发帖用户增加积分,增加发表主题数量
-    const author = await service.user.getUserById(topic.author_id);
-    author.score += 5;
-    author.topic_count += 1;
-    await author.save();
-    ctx.user = author;
+    await service.user.incrementScoreAndReplyCount(topic.author_id, 5, 1);
 
     ctx.redirect('/topic/' + topic._id);
 
@@ -389,13 +387,10 @@ class TopicController extends Controller {
     await service.topicCollect.newAndSave(ctx.user._id, topic._id);
     ctx.body = { status: 'success' };
 
-    const user = await service.user.getUserById(ctx.user._id);
-    user.collect_topic_count += 1;
-    await user.save();
-
-    ctx.user.collect_topic_count += 1;
-    topic.collect_count += 1;
-    await topic.save();
+    await Promise.all([
+      service.user.incrementCollectTopicCount(ctx.user._id),
+      service.topic.incrementCollectCount(topic_id),
+    ]);
   }
 
   /**

app/service/reply.js

@@ -104,7 +104,7 @@ class ReplyService extends Service {
   getLastReplyByTopId(topicId) {
     const query = { topic_id: topicId, deleted: false };
     const opts = { sort: { create_at: -1 }, limit: 1 };
-    return this.ctx.model.Reply.find(query, '_id', opts).exec();
+    return this.ctx.model.Reply.findOne(query, '_id', opts).exec();
   }
 
   getRepliesByAuthorId(authorId, opt = null) {

app/service/topic.js

@@ -113,15 +113,16 @@ class TopicService extends Service {
    * @param {String} replyId 回复ID
    * @param {Function} callback 回调函数
    */
-  async updateLastReply(topicId, replyId) {
-    const topic = await this.ctx.model.Topic.findOne({ _id: topicId }).exec();
-    if (!topic) {
-      return;
-    }
-    topic.last_reply = replyId;
-    topic.last_reply_at = new Date();
-    topic.reply_count += 1;
-    return topic.save();
+  updateLastReply(topicId, replyId) {
+    const update = {
+      last_reply: replyId,
+      last_reply_at: new Date(),
+      $inc: {
+        reply_count: 1,
+      },
+    };
+    const opts = { new: true };
+    return this.ctx.model.Topic.findByIdAndUpdate(topicId, update, opts).exec();
   }
 
   /*
@@ -138,20 +139,33 @@ class TopicService extends Service {
    * @param {String} id 主题ID
    */
   async reduceCount(id) {
-    const topic = await this.ctx.model.Topic.findOne({ _id: id }).exec();
+    const update = { $inc: { reply_count: -1 } };
+    const reply = await this.service.reply.getLastReplyByTopId(id);
+    if (reply) {
+      update.last_reply = reply._id;
+    } else {
+      update.last_reply = null;
+    }
+    const opts = { new: true };
+
+    const topic = await this.ctx.model.Topic.findByIdAndUpdate(id, update, opts).exec();
     if (!topic) {
       throw new Error('该主题不存在');
     }
 
-    topic.reply_count -= 1;
-    const reply = await this.service.reply.getLastReplyByTopId(id);
-    if (reply.length !== 0) {
-      topic.last_reply = reply[0]._id;
-    } else {
-      topic.last_reply = null;
-    }
+    return topic;
+  }
 
-    return topic.save();
+  incrementVisitCount(id) {
+    const query = { _id: id };
+    const update = { $inc: { visit_count: 1 } };
+    return this.ctx.model.Topic.findByIdAndUpdate(query, update).exec();
+  }
+
+  incrementCollectCount(id) {
+    const query = { _id: id };
+    const update = { $inc: { collect_count: 1 } };
+    return this.ctx.model.Topic.findByIdAndUpdate(query, update).exec();
   }
 
   newAndSave(title, content, tab, authorId) {

app/service/user.js

@@ -84,6 +84,18 @@ class UserService extends Service {
     return this.ctx.model.User.findOne(query).exec();
   }
 
+  incrementScoreAndReplyCount(id, score, replyCount) {
+    const query = { _id: id };
+    const update = { $inc: { score, reply_count: replyCount } };
+    return this.ctx.model.User.findByIdAndUpdate(query, update).exec();
+  }
+
+  incrementCollectTopicCount(id) {
+    const query = { _id: id };
+    const update = { $inc: { collect_topic_count: 1 } };
+    return this.ctx.model.User.findByIdAndUpdate(query, update).exec();
+  }
+
   newAndSave(name, loginname, pass, email, avatar_url, active) {
     const user = new this.ctx.model.User();
     user.name = loginname;

test/app/service/reply.test.js

@@ -97,7 +97,7 @@ describe('reply service', () => {
 
     const last_reply = await ctx.service.reply.getLastReplyByTopId(topic._id);
 
-    assert(last_reply[0]._id.toString() === reply._id.toString());
+    assert(last_reply._id.toString() === reply._id.toString());
   });
 
   it('getRepliesByAuthorId should ok', async function() {

test/app/service/topic.test.js

@@ -40,7 +40,7 @@ describe('test/app/service/topic.test.js', () => {
 
   it('updateLastReply should ok', async () => {
     const result1 = await topic.updateLastReply(topicId, replyId);
-    assert(result1.last_reply === replyId);
+    assert(result1.last_reply.toString() === replyId.toString());
     const result2 = await topic.updateLastReply();
     assert(!result2);
   });