Merge pull request #367 from cnoe-io/support-any-remote-agent

feat: allow supervisor agent to work with any remote agent

Author: suwhang-cisco

ai_platform_engineering/multi_agents/__init__.py

@@ -7,16 +7,3 @@
 This module provides the main entry point for the multi-agent system,
 including the AgentRegistry and related functionality.
 """
-
-from .agent_registry import AgentRegistry
-
-# Create a convenience function for backward compatibility
-def get_enabled_agents(validate_imports: bool = True):
-    """Convenience function to get enabled agents using AgentRegistry.get_enabled_agents()"""
-    return AgentRegistry.get_enabled_agents(validate_imports=validate_imports)
-
-# Re-export for backward compatibility
-__all__ = [
-    "AgentRegistry",
-    "get_enabled_agents",
-]

ai_platform_engineering/multi_agents/agent_registry.py

@@ -6,7 +6,7 @@
 import os
 import logging
 
-from ai_platform_engineering.multi_agents import AgentRegistry
+from ai_platform_engineering.multi_agents.agent_registry import AgentRegistry
 
 
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
@@ -37,10 +37,5 @@
 if WEBEX_AGENT_ENABLED:
     AGENT_NAMES.append("webex")
 
-class IncidentRegistry(AgentRegistry):
-    """Registry for incident engineer multi-agent system."""
-
-    AGENT_NAMES = AGENT_NAMES
-
-# Create the incident registry instance
-incident_registry = IncidentRegistry()
+# Create the incident registry instance with custom agent list
+incident_registry = AgentRegistry()

ai_platform_engineering/multi_agents/incident_engineer/__init__.py

@@ -21,20 +21,14 @@
 # =====================================================
 
 # Import after tracing is properly configured
-from ai_platform_engineering.multi_agents import AgentRegistry  # noqa: E402
+from ai_platform_engineering.multi_agents.agent_registry import AgentRegistry  # noqa: E402
 
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
 logger = logging.getLogger(__name__)
 
-# Get enabled agents using the class method
-AGENT_NAMES = AgentRegistry.get_enabled_agents()
+# Create the platform registry instance - it will automatically get enabled agents from env
+platform_registry = AgentRegistry()
 
-for agent_name in AGENT_NAMES:
+# Log enabled agents
+for agent_name in platform_registry.AGENT_NAMES:
     logger.info("🤖 Agent enabled: %s", agent_name)
-
-class PlatformRegistry(AgentRegistry):
-    """Registry for platform engineer multi-agent system."""
-    AGENT_NAMES = AGENT_NAMES
-
-# Create the platform registry instance
-platform_registry = PlatformRegistry()

ai_platform_engineering/multi_agents/platform_engineer/__init__.py

@@ -13,7 +13,7 @@
 
 from ai_platform_engineering.multi_agents.platform_engineer import platform_registry
 
-from ai_platform_engineering.multi_agents.platform_engineer.prompts import system_prompt, generate_subagents
+from ai_platform_engineering.multi_agents.platform_engineer.prompts import system_prompt, subagents
 from deepagents import async_create_deep_agent
 
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
@@ -96,8 +96,6 @@ def _build_graph(self) -> None:
 
     all_agents = platform_registry.get_all_agents()
 
-    subagents = generate_subagents()
-
     logger.info(f'sub_agents: {subagents}')
 
     # Create the Deep Agent

ai_platform_engineering/multi_agents/platform_engineer/deep_agent.py

@@ -47,16 +47,16 @@ def load_prompt_config(path="prompt_config.yaml"):
     agent_skill_examples.extend(agent_examples_from_config.get("general"))
 
 # Include sub-agent examples from config ONLY IF the sub-agent is enabled
-for agent_name, agent in agents.items():
-    if agent is not None:
+for agent_name, agent_card in agents.items():
+    if agent_card is not None:
         try:
             agent_eg = agent_examples_from_config.get(agent_name)
             if agent_eg:
-                logger.info("Agent examples config found for agent:", agent_name)
+                logger.info("Agent examples config found for agent: %s", agent_name)
                 agent_skill_examples.extend(agent_eg)
             else: # If no examples are provided in the config, use the agent's own examples
-                logger.info("Agent examples config not found for agent:", agent_name)
-                agent_skill_examples.extend(agent.get_skill_examples())
+                logger.info("Agent examples config not found for agent: %s", agent_name)
+                agent_skill_examples.extend(platform_registry.get_agent_examples(agent_name))
         except Exception as e:
             logger.warning(f"Error getting skill examples from agent: {e}")
             continue
@@ -69,46 +69,26 @@ def load_prompt_config(path="prompt_config.yaml"):
     )
 )
 
-def generate_subagents():
-    """
-    Build DeepAgents-compatible subagent definitions (without tools) from the platform registry.
-    Each subagent contains: name, description, and prompt.
-    The 'tools' field is intentionally omitted so DeepAgents can populate access later.
-    """
-    subagents = []
-    for agent_key, agent in agents.items():
-        # Prefer system_prompt override from prompt config; fallback to agent description
-        system_prompt_override = agent_prompts.get(agent_key, {}).get("system_prompt")
-        description = getattr(agent.agent_card(), "description", agent_key)
-        prompt = system_prompt_override or description
-        sub_agent = {
-            "name": agent_key,
-            "description": description,
-            "prompt": prompt
-            # "tool": agent
-        }
-        logger.info(f'sub_agent: {sub_agent}')
-        subagents.append(sub_agent)
-    return subagents
+subagents = platform_registry.generate_subagents(agent_prompts)
 
 # Generate system prompt dynamically based on tools and their tasks
 def generate_system_prompt(agents: Dict[str, Any]):
   tool_instructions = []
-  for agent_key, agent in agents.items():
+  for agent_key, agent_card in agents.items():
 
     logger.info(f"Generating tool instruction for agent_key: {agent_key}")
 
     # Check if agent and agent_card are available
-    if agent is None:
+    if agent_card is None:
       logger.warning(f"Agent {agent_key} is None, skipping...")
       continue
 
     try:
-      agent_card = agent.agent_card()
       if agent_card is None:
         logger.warning(f"Agent {agent_key} has no agent card, skipping...")
         continue
-      description = agent_card.description
+      print(f"agent_card 1: {agent_card}")
+      description = agent_card['description']
     except AttributeError as e:
       logger.warning(f"Agent {agent_key} does not have agent_card method or description: {e}, skipping...")
       continue

ai_platform_engineering/multi_agents/platform_engineer/prompts.py

@@ -29,13 +29,13 @@
   agent_description,
   agent_skill_examples
 )
-from ai_platform_engineering.multi_agents import AgentRegistry
+from ai_platform_engineering.multi_agents.platform_engineer import platform_registry
 
 def get_agent_card(host: str, port: int, external_url: str = None):
   capabilities = AgentCapabilities(streaming=True, pushNotifications=True)
 
   # Get enabled agents and add 'devops' as a base tag
-  tags = AgentRegistry.get_enabled_agents()
+  tags = platform_registry.AGENT_NAMES  # this is just a list of agent names
 
   skill = AgentSkill(
     id='ai_platform_engineer',

ai_platform_engineering/multi_agents/platform_engineer/protocol_bindings/a2a/main.py

@@ -446,21 +446,21 @@ def tearDown(self):
 
     def test_convenience_function_exists(self):
         """Test that get_enabled_agents convenience function exists."""
-        from ai_platform_engineering.multi_agents import get_enabled_agents
-        self.assertIsNotNone(get_enabled_agents)
+        from ai_platform_engineering.multi_agents.agent_registry import AgentRegistry
+        self.assertIsNotNone(AgentRegistry.get_enabled_agents)
         print("✓ Convenience function exists")
 
     def test_convenience_function_works(self):
         """Test that convenience function works correctly."""
-        from ai_platform_engineering.multi_agents import get_enabled_agents
+        from ai_platform_engineering.multi_agents.agent_registry import AgentRegistry
 
         # Clear all
         for key in list(os.environ.keys()):
             if key.startswith('ENABLE_'):
                 del os.environ[key]
 
         os.environ['ENABLE_GITHUB'] = 'true'
-        enabled = get_enabled_agents()
+        enabled = AgentRegistry.get_enabled_agents()
 
         self.assertIn('github', enabled)
         print("✓ Convenience function works correctly")

ai_platform_engineering/multi_agents/tests/test_agent_registry.py

@@ -7,7 +7,5 @@
 This package contains common utility functions shared across the AI Platform Engineering codebase.
 """
 
-# Note: get_enabled_agents has been moved to multi_agents.agent_registry
-# for better organization and integration with the AgentRegistry class.
 
 __all__ = []