warnings

Author: tandraschko

src/main/java/org/primefaces/application/exceptionhandler/PrimeExceptionHandler.java

@@ -249,12 +249,12 @@ protected ExceptionInfo createExceptionInfo(Throwable rootCause) throws IOExcept
         info.setTimestamp(new Date());
         info.setType(rootCause.getClass().getName());
 
-        StringWriter sw = new StringWriter();
-        PrintWriter pw = new PrintWriter(sw);
-        rootCause.printStackTrace(pw);
-        info.setFormattedStackTrace(ComponentUtils.escapeXml(sw.toString()).replaceAll("(\r\n|\n)", "<br/>"));
-        pw.close();
-        sw.close();
+        try (StringWriter sw = new StringWriter()) {
+            PrintWriter pw = new PrintWriter(sw);
+            rootCause.printStackTrace(pw);
+            info.setFormattedStackTrace(ComponentUtils.escapeXml(sw.toString()).replaceAll("(\r\n|\n)", "<br/>"));
+            pw.close();
+        }
 
         SimpleDateFormat format = new SimpleDateFormat(DATE_FORMAT_PATTERN);
         info.setFormattedTimestamp(format.format(info.getTimestamp()));

src/main/java/org/primefaces/application/resource/MoveScriptsToBottomState.java

@@ -26,8 +26,8 @@ public class MoveScriptsToBottomState implements Serializable {
     private int savedInlineTags;
 
     public MoveScriptsToBottomState() {
-        includes = new ArrayList<String>(20);
-        inlines = new ArrayList<String>(50);
+        includes = new ArrayList<>(20);
+        inlines = new ArrayList<>(50);
         savedInlineTags = 0;
     }
 

src/main/java/org/primefaces/application/resource/StreamedContentHandler.java

@@ -35,6 +35,7 @@ public class StreamedContentHandler extends BaseDynamicContentHandler {
 
     private final static Logger LOG = Logger.getLogger(StreamedContentHandler.class.getName());
 
+    @Override
     public void handle(FacesContext context) throws IOException {
         Map<String, String> params = context.getExternalContext().getRequestParameterMap();
         String library = params.get("ln");

src/main/java/org/primefaces/application/resource/barcode/BarcodeHandler.java

@@ -44,7 +44,7 @@ public class BarcodeHandler extends BaseDynamicContentHandler {
     private final Map<String, BarcodeGenerator> generators;
 
     public BarcodeHandler() {
-        generators = new HashMap<String, BarcodeGenerator>();
+        generators = new HashMap<>();
         generators.put("int2of5", new Int2of5Generator());
         generators.put("codabar", new CodabarGenerator());
         generators.put("code39", new Code39Generator());
@@ -58,6 +58,7 @@ public BarcodeHandler() {
         generators.put("datamatrix", new DataMatrixGenerator());
     }
 
+    @Override
     public void handle(FacesContext context) throws IOException {
         Map<String, String> params = context.getExternalContext().getRequestParameterMap();
         ExternalContext externalContext = context.getExternalContext();

src/main/java/org/primefaces/cache/DefaultCacheProvider.java

@@ -25,41 +25,45 @@
  */
 public class DefaultCacheProvider implements CacheProvider {
 
-    private final static Logger logger = Logger.getLogger(DefaultCacheProvider.class.getName());
+    private final static Logger LOG = Logger.getLogger(DefaultCacheProvider.class.getName());
 
     private ConcurrentMap<String, ConcurrentMap<String, Object>> cache;
 
     public DefaultCacheProvider() {
-        cache = new ConcurrentHashMap<String, ConcurrentMap<String, Object>>();
-        logger.warning("DefaultCacheProvider is for development purposes only, prefer another provider such as EhCache and HazelCast in production.");
+        cache = new ConcurrentHashMap<>();
+        LOG.warning("DefaultCacheProvider is for development purposes only, prefer another provider such as EhCache and HazelCast in production.");
     }
 
+    @Override
     public Object get(String region, String key) {
         Map<String, Object> cacheRegion = getRegion(region);
 
         return cacheRegion.get(key);
     }
 
+    @Override
     public void put(String region, String key, Object object) {
         Map<String, Object> cacheRegion = getRegion(region);
 
         cacheRegion.put(key, object);
     }
 
+    @Override
     public void remove(String region, String key) {
         Map<String, Object> cacheRegion = getRegion(region);
 
         cacheRegion.remove(key);
     }
 
+    @Override
     public void clear() {
         cache.clear();
     }
 
     private Map<String, Object> getRegion(String name) {
         ConcurrentMap<String, Object> region = cache.get(name);
         if (region == null) {
-            region = new ConcurrentHashMap<String, Object>();
+            region = new ConcurrentHashMap<>();
             cache.put(name, region);
         }
 

src/main/java/org/primefaces/cache/EHCacheProvider.java

@@ -27,6 +27,7 @@ public EHCacheProvider() {
         cacheManager = CacheManager.create();
     }
 
+    @Override
     public Object get(String region, String key) {
         Cache cacheRegion = getRegion(region);
         Element element = cacheRegion.get(key);
@@ -39,18 +40,21 @@ public Object get(String region, String key) {
         }
     }
 
+    @Override
     public void put(String region, String key, Object object) {
         Cache cacheRegion = getRegion(region);
 
         cacheRegion.put(new Element(key, object));
     }
 
+    @Override
     public void remove(String region, String key) {
         Cache cacheRegion = getRegion(region);
 
         cacheRegion.remove(key);
     }
 
+    @Override
     public void clear() {
         String[] cacheNames = getCacheManager().getCacheNames();
         if (cacheNames != null) {

src/main/java/org/primefaces/cache/HazelcastCacheProvider.java

@@ -29,24 +29,28 @@ public HazelcastCacheProvider() {
         hazelcastInstance = Hazelcast.newHazelcastInstance(config);
     }
 
+    @Override
     public Object get(String region, String key) {
         IMap<String, Object> cacheRegion = getRegion(region);
 
         return cacheRegion.get(key);
     }
 
+    @Override
     public void put(String region, String key, Object object) {
         IMap<String, Object> cacheRegion = getRegion(region);
 
         cacheRegion.put(key, object);
     }
 
+    @Override
     public void remove(String region, String key) {
         IMap<String, Object> cacheRegion = getRegion(region);
 
         cacheRegion.remove(key);
     }
 
+    @Override
     public void clear() {
 
     }

src/main/java/org/primefaces/util/ComponentUtils.java

@@ -261,12 +261,12 @@ public static Map<String, List<String>> getUIParams(UIComponent component) {
 
                 if (!uiParam.isDisable()) {
                     if (params == null) {
-                        params = new LinkedHashMap<String, List<String>>();
+                        params = new LinkedHashMap<>();
                     }
 
                     List<String> paramValues = params.get(uiParam.getName());
                     if (paramValues == null) {
-                        paramValues = new ArrayList<String>();
+                        paramValues = new ArrayList<>();
                         params.put(uiParam.getName(), paramValues);
                     }
 

src/main/java/org/primefaces/util/CompositeUtils.java

@@ -64,6 +64,8 @@ public static void invokeOnDeepestEditableValueHolder(FacesContext context, UICo
                     final UIComponent child = childs.get(0);
 
                     composite.invokeOnComponent(context, composite.getClientId(context), new ContextCallback() {
+                        
+                        @Override
                         public void invokeContextCallback(FacesContext context, UIComponent target) {
                             if (isComposite(child)) {
                                 invokeOnDeepestEditableValueHolder(context, child, callback);

src/main/java/org/primefaces/util/DynamicContentSrcBuilder.java

@@ -61,7 +61,7 @@ else if (value instanceof StreamedContent) {
                 Map<String,Object> session = context.getExternalContext().getSessionMap();
                 Map<String,String> dynamicResourcesMapping = (Map) session.get(Constants.DYNAMIC_RESOURCES_MAPPING);
                 if (dynamicResourcesMapping == null) {
-                    dynamicResourcesMapping = new LimitedSizeHashMap<String, String>(200);
+                    dynamicResourcesMapping = new LimitedSizeHashMap<>(200);
                     session.put(Constants.DYNAMIC_RESOURCES_MAPPING, dynamicResourcesMapping);
                 }