primefaces#3189

Author: tandraschko

src/main/java/org/primefaces/behavior/ajax/AjaxBehaviorRenderer.java

@@ -15,6 +15,7 @@
  */
 package org.primefaces.behavior.ajax;
 
+import java.util.ArrayList;
 import java.util.Collection;
 import javax.faces.component.ActionSource;
 import javax.faces.component.EditableValueHolder;
@@ -61,10 +62,23 @@ public String getScript(ClientBehaviorContext behaviorContext, ClientBehavior be
 
         Collection<ClientBehaviorContext.Parameter> behaviorParameters = behaviorContext.getParameters();
         if (behaviorParameters != null && !behaviorParameters.isEmpty()) {
-            for (ClientBehaviorContext.Parameter behaviorParameter : behaviorParameters) {
-                if (behaviorParameter.getValue() != null && behaviorParameter.getValue() instanceof ClientBehaviorRenderingMode) {
-                    renderingMode = (ClientBehaviorRenderingMode) behaviorParameter.getValue();
-                    break;
+            // perf optimzation
+            if (behaviorParameters instanceof ArrayList) {
+                for (int i = 0; i < behaviorParameters.size(); i++) {
+                    ClientBehaviorContext.Parameter behaviorParameter = 
+                            ((ArrayList<ClientBehaviorContext.Parameter>) behaviorParameters).get(i);
+                    if (behaviorParameter.getValue() != null && behaviorParameter.getValue() instanceof ClientBehaviorRenderingMode) {
+                        renderingMode = (ClientBehaviorRenderingMode) behaviorParameter.getValue();
+                        break;
+                    }
+                }
+            }
+            else {
+                for (ClientBehaviorContext.Parameter behaviorParameter : behaviorParameters) {
+                    if (behaviorParameter.getValue() != null && behaviorParameter.getValue() instanceof ClientBehaviorRenderingMode) {
+                        renderingMode = (ClientBehaviorRenderingMode) behaviorParameter.getValue();
+                        break;
+                    }
                 }
             }
         }

src/main/java/org/primefaces/component/orderlist/OrderListRenderer.java

@@ -154,8 +154,7 @@ protected void encodeOptions(FacesContext context, OrderList old, List model) th
         String var = old.getVar();
         Converter converter = old.getConverter();
 
-        for (Iterator it = model.iterator(); it.hasNext();) {
-            Object item = it.next();
+        for (Object item : model) {
             context.getExternalContext().getRequestMap().put(var, item);
             String value = converter != null ? converter.getAsString(context, old, old.getItemValue()) : old.getItemValue().toString();
 

src/main/java/org/primefaces/component/tabview/TabViewRenderer.java

@@ -177,11 +177,12 @@ protected void encodeHeaders(FacesContext context, TabView tabView) throws IOExc
         writer.writeAttribute("role", "tablist", null);
 
         if (var == null) {
-            int i = 0;
-            for (UIComponent kid : tabView.getChildren()) {
-                if (kid.isRendered() && kid instanceof Tab) {
-                    encodeTabHeader(context, tabView, (Tab) kid, i, (i == activeIndex));
-                    i++;
+            int j = 0;
+            for (int i = 0; i < tabView.getChildren().size(); i++) {
+                UIComponent child = tabView.getChildren().get(i);
+                if (child.isRendered() && child instanceof Tab) {
+                    encodeTabHeader(context, tabView, (Tab) child, j, (j == activeIndex));
+                    j++;
                 }
             }
         }
@@ -284,11 +285,12 @@ protected void encodeContents(FacesContext context, TabView tabView) throws IOEx
         writer.writeAttribute("class", TabView.PANELS_CLASS, null);
 
         if (var == null) {
-            int i = 0;
-            for (UIComponent kid : tabView.getChildren()) {
-                if (kid.isRendered() && kid instanceof Tab) {
-                    encodeTabContent(context, (Tab) kid, i, (i == activeIndex), dynamic);
-                    i++;
+            int j = 0;
+            for (int i = 0; i < tabView.getChildren().size(); i++) {
+                UIComponent child = tabView.getChildren().get(i);
+                if (child.isRendered() && child instanceof Tab) {
+                    encodeTabContent(context, (Tab) child, j, (j == activeIndex), dynamic);
+                    j++;
                 }
             }
         }