Skip to content

Commit 2456dc7

Browse files
committed
Peer review column header name changes
- Corrected the column header name for the peer review excel download.
1 parent 1ec20cd commit 2456dc7

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

tests/test_utils/test_to_spreadsheet_peer_review.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,15 +206,15 @@ def test_recommendations_tab_has_risk_columns_for_independent_review(self):
206206
self.assertIn("Recommendation number", headers)
207207

208208
def test_recommendations_tab_no_risk_columns_for_peer_review(self):
209-
"""Test that recommendations tab does NOT include 'Risk' and 'Recommendation number' for peer review."""
209+
"""Test that recommendations tab does NOT include 'Risk' and 'Risk number' for peer review."""
210210
excel_bytes = review_to_excel(self.peer_review)
211211
wb = load_workbook(BytesIO(excel_bytes))
212212
ws = wb["Recommendations"]
213213

214214
# Get header row
215215
headers = [cell.value for cell in ws[1]]
216216
self.assertNotIn("Risk", headers)
217-
self.assertNotIn("Recommendation number", headers)
217+
self.assertNotIn("Risk number", headers)
218218

219219
def test_recommendations_tab_column_count_differs_by_review_type(self):
220220
"""Test that recommendations tab has different column counts for different review types."""
@@ -251,7 +251,7 @@ def test_all_sheets_present_for_both_review_types(self):
251251

252252
def test_recommendations_tab_common_columns_present(self):
253253
"""Test that common columns are present in recommendations tab for both review types."""
254-
common_columns = ["Contributing outcome", "Target CAF profile", "Risk number", "Recommendation"]
254+
common_columns = ["Contributing outcome", "Target CAF profile", "Recommendation number", "Recommendation"]
255255

256256
# Test independent review
257257
excel_bytes = review_to_excel(self.independent_review)
@@ -346,14 +346,14 @@ def test_peer_review_does_not_have_review_comments_column(self):
346346
self.assertNotIn("Review comments", headers)
347347

348348
def test_peer_review_does_not_have_risk_columns(self):
349-
"""Test that peer_review does NOT have 'Risk' and 'Recommendation number' columns."""
349+
"""Test that peer_review does NOT have 'Risk' and 'Risk number' columns."""
350350
review = self.reviews["peer_review"]
351351
excel_bytes = review_to_excel(review)
352352
wb = load_workbook(BytesIO(excel_bytes))
353353
ws = wb["Recommendations"]
354354
headers = [cell.value for cell in ws[1]]
355355
self.assertNotIn("Risk", headers)
356-
self.assertNotIn("Recommendation number", headers)
356+
self.assertNotIn("Risk number", headers)
357357

358358

359359
class TestReviewToExcelDataIntegrity(TestCase):

webcaf/webcaf/utils/to_spreadsheet.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,17 +276,17 @@ def _add_recommendations_tab(wb: Workbook, review: Review):
276276
[
277277
"Contributing outcome",
278278
"Target CAF profile",
279-
"Risk number",
280279
]
281280
+ (
282281
[
282+
"Risk number",
283283
"Risk",
284-
"Recommendation number",
285284
]
286285
if review.assessment.review_type != "peer_review"
287286
else []
288287
)
289288
+ [
289+
"Recommendation number",
290290
"Recommendation",
291291
]
292292
)
@@ -312,17 +312,17 @@ def _add_recommendations_tab(wb: Workbook, review: Review):
312312
[
313313
contributing_outcome_titles[recommendation.outcome],
314314
profile_met,
315-
f"{prefix}{recommendation_group.group_index}",
316315
]
317316
+ (
318317
[
318+
f"{prefix}{recommendation_group.group_index}",
319319
recommendation.title,
320-
recommendation.id,
321320
]
322321
if review.assessment.review_type != "peer_review"
323322
else []
324323
)
325324
+ [
325+
recommendation.id,
326326
recommendation.text,
327327
]
328328
)

0 commit comments

Comments
 (0)