.coafile: Fix ignore files field not created

* Convert generator to list (it was getting exhausted before).
* Remove an if statement which would always evaluate to False.
* Add a test case for ignore_globs.

Fixes #157,
Fixes #173

Author: ishanSrt

coala_quickstart/generation/FileGlobs.py

@@ -49,6 +49,7 @@ def get_project_files(log_printer,
         file_path_completer.deactivate()
     printer.print()
 
+    ignore_globs = list(ignore_globs)
     escaped_project_dir = glob_escape(project_dir)
     file_path_globs = [os.path.join(
         escaped_project_dir, glob_exp) for glob_exp in file_globs]

coala_quickstart/generation/Settings.py

@@ -61,8 +61,7 @@ def generate_ignore_field(project_dir,
     for glob in ignore_globs:
         gitignore_files = {file
                            for file in collect_files([glob], null_printer)}
-        if not all_files.isdisjoint(gitignore_files):
-            ignores.append(os.path.relpath(glob, project_dir))
+        ignores.append(os.path.relpath(glob, project_dir))
 
     return ", ".join(ignores)
 

tests/generation/SettingsTest.py

@@ -16,6 +16,13 @@
 
 class SettingsTest(unittest.TestCase):
 
+    def path_leaf(self, path):
+        """
+        :return: The file name from the given path.
+        """
+        head, tail = os.path.split(path)
+        return tail or os.path.basename(head)
+
     def setUp(self):
         self.project_dir = os.getcwd()
         self.printer = ConsolePrinter()
@@ -42,6 +49,32 @@ def test_write_info(self):
 
         self.assertEqual(result_comment, line)
 
+    def test_allow_complete_section_mode_with_ignore_globs(self):
+        project_dir = "/repo"
+        project_files = ['/repo/hello.html']
+        ignore_globs = ["/repo/style.css"]
+        used_languages = list(get_used_languages(project_files))
+        relevant_bears = filter_relevant_bears(
+            used_languages, self.printer, self.arg_parser, {})
+
+        res = generate_settings(
+            project_dir, project_files, ignore_globs, relevant_bears, {}, True)
+
+        bears_list = res["all.HTML"]["bears"].value.replace(" ", "").split(",")
+
+        files_list = res["all.HTML"]["files"].value.replace(" ", "").split(",")
+
+        self.assertEqual(
+            ['HTMLLintBear', 'coalaBear', 'BootLintBear',
+             'LicenseCheckBear', 'SpaceConsistencyBear', 'KeywordBear',
+             'LineLengthBear', 'DuplicateFileBear'].sort(),
+            bears_list.sort())
+
+        ignore_file = str(os.path.normpath(self.path_leaf(
+            str(res["all"]["ignore"]))))
+        self.assertEqual(['**.html'], files_list)
+        self.assertEqual('style.css', ignore_file)
+
     def test_allow_complete_section_mode(self):
         project_dir = "/repo"
         project_files = ['/repo/hello.html']