Skip to content

Commit 0115558

Browse files
authored
Fixes for CRAN Check (#3)
* Use 2 cores on Travis-CI * Add ORCID * Import the search_google function to quiet CRAN checks * Redocument. * Update DESCRIPTION and NEWS file for new release. * Update CRAN submission remarks.
1 parent 20ed3aa commit 0115558

File tree

7 files changed

+25
-42
lines changed

7 files changed

+25
-42
lines changed

.travis.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@ sudo: false
55
cache: packages
66
after_success:
77
- Rscript -e 'covr::codecov()'
8+
9+
env:
10+
global:
11+
- MAKEFLAGS="-j 2"

DESCRIPTION

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
Package: errorist
22
Title: Automatically Search Errors or Warnings
3-
Version: 0.0.1.1000
4-
Authors@R: c(person("James", "Balamuta",
5-
email = "[email protected]", role = c("aut", "cre")))
3+
Version: 0.0.2
4+
Authors@R: c(person("James", "Balamuta", email = "[email protected]", role = c("aut", "cre", "cph"),
5+
comment = c(ORCID = "0000-0003-2826-8458"))
6+
)
67
Description: Provides environment hooks that obtain errors and warnings which
78
occur during the execution of code to automatically search for solutions.
89
URL: https://github.com/coatless/errorist
@@ -16,6 +17,6 @@ Suggests: testthat,
1617
License: GPL (>= 2)
1718
Encoding: UTF-8
1819
LazyData: true
19-
RoxygenNote: 6.0.1
20+
RoxygenNote: 6.1.1
2021
Roxygen: list(markdown = TRUE)
2122
VignetteBuilder: knitr

NAMESPACE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@ export(disable_warning_shim)
66
export(enable_error_shim)
77
export(enable_errorist)
88
export(enable_warning_shim)
9+
importFrom(searcher,search_google)

NEWS.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
1-
# errorist 0.0.1.1000
1+
# errorist 0.0.2
22

3-
_in progress_
3+
## Bugfixes
4+
5+
- Imported the `search_google` function from `searcher` to satisfy `R CMD check`.
6+
7+
## Test Infrastructure
8+
9+
- Enable the use of two cores to speed up Travis-CI builds.
410

511
# errorist 0.0.1
612

R/handlers.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ disable_warning_shim = function() {
172172
removed_handler = removeTaskCallback("ErroristWarningHandler")
173173
}
174174

175+
#' @importFrom searcher search_google
175176
#' @rdname shims
176177
#' @export
177178
#' @examples

cran-comments.md

Lines changed: 4 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,14 @@
11
## Test environments
22

3-
- local OS X install, R 3.4.3
4-
- ubuntu 12.04 (on travis-ci), R 3.4.3
3+
- local OS X install, R 3.5.2
4+
- ubuntu 14.04 (on travis-ci), R 3.5.2
55
- win-builder (devel and release)
66

77
## R CMD check results
88

9-
0 errors | 0 warnings | 1 note
10-
11-
Found the following (possibly) invalid URLs:
12-
URL: http://www.r-pkg.org/pkg/errorist (moved to https://www.r-pkg.org:443/pkg/errorist)
13-
From: inst/README.md
14-
Status: 404
15-
Message: Not Found
9+
0 errors | 0 warnings | 0 note
1610

17-
- This is a new release.
18-
- Because this is a new release, the above URL has yet to be activated as
19-
the website only contains active packages on CRAN.
20-
21-
## Resubmit Remarks
22-
23-
From the initial submission, Uwe commented:
24-
25-
> Thanks, we see all your examples are in `\dontrun{}` and your tests are
26-
> rather sparse.
27-
> Can you somehow test the core functionality of your package, too?
28-
29-
I have since:
30-
31-
1. Unlocked all examples and added an example for `enable_error_shim()`/`disable_error_shim()`
32-
2. Improved the unit tests:
33-
- Verification that a `call` has been registered in `options(error = ...)`
34-
- An output comparison of the function registered as the `options(error= ...)`
35-
handler and the default search function.
36-
- Checks surrounding the state of the `.errorist_env` when `errorist` is enabled.
37-
3. Added a brief vignette to complement the extensive `README.md` file
38-
39-
Details of the code changes can be seen here:
40-
41-
<https://github.com/coatless/errorist/compare/165357dcf4c76bc4bd35b0049a47799f0c724fdb...master>
11+
- This release is meant to resolve an import issue on the CRAN checks page.
4212

4313
## Reverse dependencies
4414

man/errorist-package.Rd

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)