Skip to content

Commit 8a41cb8

Browse files
committed
Merge branch 'master' of https://github.com/r-assist/errorist
2 parents 0b4233b + f2e336c commit 8a41cb8

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: errorist
22
Title: Automatically Search Errors or Warnings
3-
Version: 0.1.0
3+
Version: 0.0.3
44
Authors@R: c(
55
person("James", "Balamuta",
66
email = "[email protected]",

NEWS.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
# errorist 0.1.0
1+
# errorist 0.0.3
22

3-
## Features
3+
## Bug Fix
44

5-
- TBA
5+
- Address an erroneous unit test that was comparing functions within namespaces
6+
instead of environments.
67

78
# errorist 0.0.2
89

cran-comments.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
## Test environments
22

3-
- local OS X install, R 3.5.2
4-
- ubuntu 14.04 (on travis-ci), R 3.5.2
3+
- local OS X install, R 3.6.2
4+
- ubuntu 14.04 (on travis-ci), R 3.6.2
55
- win-builder (devel and release)
66

77
## R CMD check results
88

99
0 errors | 0 warnings | 0 note
1010

11-
- This release is meant to resolve an import issue on the CRAN checks page.
11+
- This release is meant to resolve an issue with one of the unit tests
12+
on the CRAN checks page.
13+
-
1214

1315
## Reverse dependencies
1416

15-
This is a new release, so there are no reverse dependencies.
17+
There are no reverse dependencies.

tests/testthat/test-handlers.R

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,11 @@ test_that("Check Output from Functions", {
5353
# Retrieve the function
5454
test_error_function = test_error_call[[1]]
5555

56-
# Retrieve function name space
57-
# See: https://stackoverflow.com/a/6433626/1345455
58-
get_function_namespace = function(func) { getNamespaceName(environment(func)) }
59-
6056
expect_true(is.function(options_default_function),
6157
"Verify the default error handler is a function.")
6258

63-
expect_true(get_function_namespace(test_error_function) ==
64-
get_function_namespace(options_default_function) ,
59+
expect_true(identical(environment(test_error_function),
60+
environment(options_default_function)),
6561
"Verify that test function call matches the default function's environment")
6662

6763
expect_equal(test_error_function("toad"), options_default_function("toad"),

0 commit comments

Comments
 (0)