Skip to content

Commit b63e59e

Browse files
Upgrade ensmallen to 2.15.0 (#39)
* Upgrade ensmallen to 2.15.0 * Apply suggestions from code review * Add CRAN comments * Upgrade ensmallen to 2.15.0 * Fix header inclusion order Co-authored-by: coatless <[email protected]> Co-authored-by: James Balamuta <[email protected]>
1 parent 375db51 commit b63e59e

File tree

10 files changed

+661
-8
lines changed

10 files changed

+661
-8
lines changed

ChangeLog

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
2020-11-03 James Balamuta <[email protected]>
2+
3+
* DESCRIPTION (Version): Release 2.15.0
4+
* NEWS.md: Update for Ensmallen release 2.15.0
5+
* inst/include/ensmallen_bits: Upgraded to Ensmallen 2.15.0
6+
* inst/include/ensmallen.hpp: ditto
7+
18
2020-09-05 James Balamuta <[email protected]>
29

310
* DESCRIPTION (Version): Release 2.14.2
@@ -18,7 +25,7 @@
1825

1926
* .github/workflows/upstream-refresh.yaml: Fix NEWS.md entry formatting
2027
issues.
21-
28+
2229
2020-08-21 James Balamuta <[email protected]>
2330

2431
* .github/workflows/upstream-refresh.yaml: Add GitHub Action to

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: RcppEnsmallen
22
Title: Header-Only C++ Mathematical Optimization Library for 'Armadillo'
3-
Version: 0.2.14.2.1
3+
Version: 0.2.15.0.1
44
Authors@R: c(
55
person("James Joseph", "Balamuta", email = "[email protected]",
66
role = c("aut", "cre", "cph"),

NEWS.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
# RcppEnsmallen 0.2.15.0.1
2+
3+
- Upgraded to ensmallen 2.15.0: "No Direction Home" (2020-11-03)
4+
- Make a few tests more robust
5+
([#228](https://github.com/mlpack/ensmallen/pull/228)).
6+
- Add release date to version information. ([#226](https://github.com/mlpack/ensmallen/pull/226))
7+
- Fix typo in release script
8+
([#236](https://github.com/mlpack/ensmallen/pull/236)).
9+
- Add optimizer summary report callback
10+
([#213](https://github.com/mlpack/ensmallen/pull/213)).
11+
112
# RcppEnsmallen 0.2.14.2.1
213

314
- Upgraded to ensmallen 2.14.2: "No Direction Home" (2020-09-05)

cran-comments.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Test environments
22

3-
* local macOS install, R 4.0.2
4-
* ubuntu 16.04 (with GitHub Actions), R 4.0.2
3+
* local macOS install, R 4.0.3
4+
* ubuntu 16.04 (with GitHub Actions), R 4.0.3
55
* win-builder (devel and release)
66

77
## R CMD check results

inst/include/ensmallen.hpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,15 @@
6666
#include "ensmallen_bits/utility/any.hpp"
6767
#include "ensmallen_bits/utility/arma_traits.hpp"
6868

69+
// Contains traits, must be placed before report callback.
70+
#include "ensmallen_bits/function.hpp" // TODO: should move to function/
71+
6972
// Callbacks.
7073
#include "ensmallen_bits/callbacks/callbacks.hpp"
7174
#include "ensmallen_bits/callbacks/early_stop_at_min_loss.hpp"
7275
#include "ensmallen_bits/callbacks/print_loss.hpp"
7376
#include "ensmallen_bits/callbacks/progress_bar.hpp"
77+
#include "ensmallen_bits/callbacks/report.hpp"
7478
#include "ensmallen_bits/callbacks/store_best_coordinates.hpp"
7579
#include "ensmallen_bits/callbacks/timer_stop.hpp"
7680

@@ -89,8 +93,6 @@
8993
#include "ensmallen_bits/eve/eve.hpp"
9094
#include "ensmallen_bits/ftml/ftml.hpp"
9195

92-
#include "ensmallen_bits/function.hpp" // TODO: should move to function/
93-
9496
#include "ensmallen_bits/fw/frank_wolfe.hpp"
9597
#include "ensmallen_bits/gradient_descent/gradient_descent.hpp"
9698
#include "ensmallen_bits/grid_search/grid_search.hpp"

0 commit comments

Comments
 (0)