Validate search websites (#24)

* - Add shortname mapping
- Add a check validation function

* Begin refactoring the `searcher` handler.

* Redo mapping

Author: coatless

R/search-functions.R

@@ -102,6 +102,7 @@ search_site = function(query,
 #' R error message on search portals by opening a
 #' browser.
 #'
+#' @param keyword Opt to search under different default terms.
 #' @inheritParams search_site
 #' @export
 #' @section Generic Error Search:
@@ -123,23 +124,10 @@ search_site = function(query,
 #' # On error, automatically search the message on google
 #' options(error = searcher("google"))
 #' }
-searcher = function(site  = c(
-  "google",
-  "bing",
-  "duckduckgo",
-  "ddg",
-  "startpage",
-  "sp",
-  "stackoverflow",
-  "so",
-  "rstudio community",
-  "rscom",
-  "github",
-  "gh",
-  "bitbucket",
-  "bb"
-),
-rlang = TRUE) {
+searcher = function(site, rlang = TRUE, keyword = getOption("searcher.default_keyword", "base")) {
+
+  check_valid_site(site)
+
   function(query = geterrmessage(), rlang = rlang) {
     search_site(query, site, rlang = rlang)
   }

R/searcher-environment.R

@@ -31,3 +31,33 @@ searcher_properties =
                                       keyword_entry("lang:r"))
   )
 
+short_site_name_map = c(
+  "ddg" = "duckduckgo",
+  "sp" = "startpage",
+  "so" = "stackoverflow",
+  "rscom" = "rstudio community",
+  "gh" = "github",
+  "bb" = "bitbucket"
+)
+
+check_site_name = function(x, data) {
+  !x %in% names(data)
+}
+
+check_short_site_name = function(x) {
+  check_site_name(x, short_site_name_map)
+}
+
+check_long_site_name = function(x) {
+  check_site_name(x, searcher_properties)
+}
+
+check_valid_site = function(site) {
+  recorded_site = any(check_long_site_name(site) | check_short_site_name(site))
+
+  if(!recorded_site) {
+      stop("`site` must be a valid site name.", call. = FALSE)
+  }
+
+  invisible(TRUE)
+}