Skip to content

Commit 72c313b

Browse files
Add positive condition
1 parent cd8df3d commit 72c313b

File tree

1 file changed

+17
-12
lines changed

1 file changed

+17
-12
lines changed

internal/controller/hypervisor_controller.go

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -132,19 +132,24 @@ func (r *HypervisorReconciler) Reconcile(ctx context.Context, req ctrl.Request)
132132
// Update hypervisor instances
133133
hypervisor.Status.NumInstances = r.Libvirt.GetNumInstances()
134134
hypervisor.Status.Instances, _ = r.Libvirt.GetInstances()
135-
}
136135

137-
// Update capabilities status.
138-
var err error
139-
hypervisor.Status.Capabilities, err = r.Libvirt.GetCapabilities()
140-
if err != nil {
141-
log.Error(err, "failed to get capabilities")
142-
meta.SetStatusCondition(&hypervisor.Status.Conditions, metav1.Condition{
143-
Type: CapabilitiesClientType,
144-
Status: metav1.ConditionFalse,
145-
Message: err.Error(),
146-
Reason: "CapabilitiesClientGetFailed",
147-
})
136+
// Update capabilities status.
137+
if capabilities, err := r.Libvirt.GetCapabilities(); err == nil {
138+
hypervisor.Status.Capabilities = capabilities
139+
meta.SetStatusCondition(&hypervisor.Status.Conditions, metav1.Condition{
140+
Type: CapabilitiesClientType,
141+
Status: metav1.ConditionTrue,
142+
Reason: "CapabilitiesClientGetSucceeded",
143+
})
144+
} else {
145+
log.Error(err, "failed to get capabilities")
146+
meta.SetStatusCondition(&hypervisor.Status.Conditions, metav1.Condition{
147+
Type: CapabilitiesClientType,
148+
Status: metav1.ConditionFalse,
149+
Message: err.Error(),
150+
Reason: "CapabilitiesClientGetFailed",
151+
})
152+
}
148153
}
149154

150155
// ====================================================================================================

0 commit comments

Comments
 (0)