Decomission: Requeue on hypervisor update

fwiesel · notandy · commit 4d63a22e4df3 · 2025-12-17T14:11:12.000-05:00
The decomissioning controller doesn't reconcile on the hypervisor,
so it won't get an update, which means we have to requeue it 'manually'.
diff --git a/internal/controller/decomission_controller.go b/internal/controller/decomission_controller.go
@@ -195,7 +195,7 @@ func (r *NodeDecommissionReconciler) setDecommissioningCondition(ctx context.Con
 		k8sclient.MergeFromWithOptimisticLock{}), k8sclient.FieldOwner(DecommissionControllerName)); err != nil {
 		return ctrl.Result{}, fmt.Errorf("cannot update hypervisor status due to %w", err)
 	}
-	return ctrl.Result{}, nil
+	return ctrl.Result{RequeueAfter: shortRetryTime}, nil
 }
 
 // SetupWithManager sets up the controller with the Manager.

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ func (r *NodeDecommissionReconciler) setDecommissioningCondition(ctx context.Con`
`195`	`195`	`k8sclient.MergeFromWithOptimisticLock{}), k8sclient.FieldOwner(DecommissionControllerName)); err != nil {`
`196`	`196`	`return ctrl.Result{}, fmt.Errorf("cannot update hypervisor status due to %w", err)`
`197`	`197`	`}`
`198`		`- return ctrl.Result{}, nil`
	`198`	`+ return ctrl.Result{RequeueAfter: shortRetryTime}, nil`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`// SetupWithManager sets up the controller with the Manager.`