Onboarding: Use unique log message for localising text

fwiesel · fwiesel · commit 7038e2766e45 · 2025-12-03T12:42:38.000+01:00
The log message was the same as in another delete case,
and that makes it hard to identify where it gets deleted.
diff --git a/internal/controller/onboarding_controller.go b/internal/controller/onboarding_controller.go
@@ -433,7 +433,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 			continue
 		}
 		if server.Name != serverName || foundServer != nil {
-			log.Info("deleting server", "name", server.Name)
+			log.Info("deleting outdated server", "name", server.Name)
 			err = servers.Delete(ctx, r.testComputeClient, server.ID).ExtractErr()
 			if err != nil && !gophercloud.ResponseCodeIs(err, http.StatusNotFound) {
 				log.Error(err, "failed deleting instance due to", "instance", server.ID)

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,`
`433`	`433`	`continue`
`434`	`434`	`}`
`435`	`435`	`if server.Name != serverName \|\| foundServer != nil {`
`436`		`- log.Info("deleting server", "name", server.Name)`
	`436`	`+ log.Info("deleting outdated server", "name", server.Name)`
`437`	`437`	`err = servers.Delete(ctx, r.testComputeClient, server.ID).ExtractErr()`
`438`	`438`	`if err != nil && !gophercloud.ResponseCodeIs(err, http.StatusNotFound) {`
`439`	`439`	`log.Error(err, "failed deleting instance due to", "instance", server.ID)`