[golangci-lint] fix golint annotations

Author: notandy

internal/controller/decomission_controller_test.go

@@ -49,7 +49,7 @@ var _ = Describe("Decommission Controller", func() {
 		resource := &corev1.Node{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:   nodeName,
-				Labels: map[string]string{labelEvictionRequired: "true"}, //nolint:goconst
+				Labels: map[string]string{labelEvictionRequired: "true"},
 			},
 		}
 		Expect(k8sClient.Create(ctx, resource)).To(Succeed())

internal/controller/eviction_controller.go

@@ -305,7 +305,7 @@ func (r *EvictionReconciler) evictNext(ctx context.Context, eviction *kvmv1.Evic
 		return ctrl.Result{}, r.Status().Update(ctx, eviction)
 	}
 
-	if vm.TaskState == "deleting" { // nolint:gocritic
+	if vm.TaskState == "deleting" { //nolint:gocritic
 		// We just have to wait for it to be gone. Try the next one.
 		copy((*instances)[1:], (*instances)[:len(*instances)-1])
 		(*instances)[0] = uuid

internal/controller/eviction_controller_test.go

@@ -97,7 +97,7 @@ var _ = Describe("Eviction Controller", func() {
 		fakeServer           testhelper.FakeServer
 	)
 
-	ctx := context.Background() // nolint:govet
+	ctx := context.Background() //nolint:govet
 
 	BeforeEach(func() {
 		By("Setting up the OpenStack http mock server")

internal/controller/hypervisor_controller_test.go

@@ -48,7 +48,7 @@ var _ = Describe("Hypervisor Controller", func() {
 		resource = &corev1.Node{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:   "other-node",
-				Labels: map[string]string{corev1.LabelTopologyZone: "test-zone"}, //nolint:goconst
+				Labels: map[string]string{corev1.LabelTopologyZone: "test-zone"},
 			},
 		}
 	})

internal/controller/maintenance_controller.go

@@ -179,7 +179,7 @@ func (r *MaintenanceController) ensureSignallingDeployment(ctx context.Context,
 		deployment.Labels = labels
 
 		podLabels := maps.Clone(labels)
-		podLabels[labelCriticalComponent] = "true" //nolint:goconst
+		podLabels[labelCriticalComponent] = "true"
 
 		var command []string
 		if ready {

internal/controller/maintenance_controller_test.go

@@ -45,7 +45,7 @@ var _ = Describe("Maintenance Controller", func() {
 		resource := &corev1.Node{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:   nodeName,
-				Labels: map[string]string{labelEvictionRequired: "true"}, //nolint:goconst
+				Labels: map[string]string{labelEvictionRequired: "true"},
 			},
 		}
 		Expect(k8sClient.Create(ctx, resource)).To(Succeed())

internal/controller/node_certificate_controller_test.go

@@ -66,7 +66,7 @@ var _ = Describe("Node Certificate Controller", func() {
 		resource := &corev1.Node{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:   nodeName,
-				Labels: map[string]string{labelHypervisor: "test"}, //nolint:goconst
+				Labels: map[string]string{labelHypervisor: "test"},
 			},
 		}
 		Expect(fakeClient.Create(ctx, resource)).To(Succeed())

internal/controller/node_eviction_label_controller.go

@@ -97,7 +97,7 @@ func (r *NodeEvictionLabelReconciler) Reconcile(ctx context.Context, req ctrl.Re
 
 	if !HasStatusCondition(hv.Status.Conditions, ConditionTypeOnboarding) {
 		// Hasn't even started to onboard that node, so nothing to evict for sure
-		value = "true" //nolint:goconst
+		value = "true"
 	} else {
 		// check for existing eviction, else create it
 		value, err = r.reconcileEviction(ctx, eviction, node, hostname, maintenanceValue)
@@ -113,7 +113,7 @@ func (r *NodeEvictionLabelReconciler) Reconcile(ctx context.Context, req ctrl.Re
 		}
 
 		newNode := node.DeepCopy()
-		if value == "true" { //nolint:goconst
+		if value == "true" {
 			evictAgentsLabels(newNode.Labels)
 		}
 		newNode.Labels[labelEvictionApproved] = maintenanceValue
@@ -153,7 +153,7 @@ func (r *NodeEvictionLabelReconciler) reconcileEviction(ctx context.Context, evi
 	}
 	switch evictionState {
 	case "Succeeded":
-		return "true", nil //nolint:goconst
+		return "true", nil
 	case "Failed":
 		return "false", nil
 	default:

internal/controller/node_eviction_label_controller_test.go

@@ -49,7 +49,7 @@ var _ = Describe("Node Eviction Label Controller", func() {
 	)
 
 	Context("When reconciling a node", func() {
-		ctx := context.Background() // nolint:govet
+		ctx := context.Background() //nolint:govet
 
 		reconcileNodeLoop := func(steps int) (res ctrl.Result, err error) {
 			for range steps {

internal/controller/onboarding_controller_test.go

@@ -38,7 +38,7 @@ var _ = Describe("Onboarding Controller", func() {
 	Context("When reconciling a hypervisor", func() {
 		const hypervisorName = "some-test"
 
-		ctx := context.Background() // nolint:govet
+		ctx := context.Background() //nolint:govet
 
 		reconcileLoop := func(steps int) (res ctrl.Result, err error) {
 			req := ctrl.Request{