[golangci-lint] error-format: fmt.Errorf can be replaced with errors.New

Author: notandy

internal/controller/onboarding_controller.go

@@ -48,7 +48,7 @@ import (
 	"github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/openstack"
 )
 
-var errRequeue = fmt.Errorf("requeue requested")
+var errRequeue = errors.New("requeue requested")
 
 const (
 	defaultWaitTime           = 1 * time.Minute
@@ -465,7 +465,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 	}
 
 	if flavorRef == "" {
-		return nil, fmt.Errorf("couldn't find flavor")
+		return nil, errors.New("couldn't find flavor")
 	}
 
 	var imageRef string
@@ -488,7 +488,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 	}
 
 	if imageRef == "" {
-		return nil, fmt.Errorf("couldn't find image")
+		return nil, errors.New("couldn't find image")
 	}
 
 	falseVal := false
@@ -509,7 +509,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 	}
 
 	if networkRef == "" {
-		return nil, fmt.Errorf("couldn't find network")
+		return nil, errors.New("couldn't find network")
 	}
 
 	log.Info("creating server", "name", serverName)
@@ -537,7 +537,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 	}
 
 	if server == nil {
-		return nil, fmt.Errorf("server is nil")
+		return nil, errors.New("server is nil")
 	}
 	// Apparently the response doesn't contain the value
 	server.Name = serverName

internal/openstack/hypervisor.go

@@ -19,7 +19,7 @@ package openstack
 
 import (
 	"context"
-	"fmt"
+	"errors"
 	"net/http"
 
 	"github.com/gophercloud/gophercloud/v2"
@@ -30,8 +30,8 @@ type HyperVisorsDetails struct {
 	Hypervisors []hypervisors.Hypervisor `json:"hypervisors"`
 }
 
-var ErrNoHypervisor = fmt.Errorf("no hypervisor found")
-var ErrMultipleHypervisors = fmt.Errorf("multiple hypervisors found")
+var ErrNoHypervisor = errors.New("no hypervisor found")
+var ErrMultipleHypervisors = errors.New("multiple hypervisors found")
 
 func GetHypervisorByName(ctx context.Context, sc *gophercloud.ServiceClient, hypervisorHostnamePattern string, withServers bool) (*hypervisors.Hypervisor, error) {
 	listOpts := hypervisors.ListOpts{

internal/openstack/placement.go

@@ -19,6 +19,7 @@ package openstack
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/gophercloud/gophercloud/v2"
@@ -146,7 +147,7 @@ func CleanupResourceProvider(ctx context.Context, client *gophercloud.ServiceCli
 		}
 
 		if len(consumerAllocations.Allocations) > 0 {
-			return fmt.Errorf("cannot clean up provider, cannot handle non-empty consumer allocations")
+			return errors.New("cannot clean up provider, cannot handle non-empty consumer allocations")
 		}
 
 		// The consumer actually doesn't have *any* allocations, so it is just