Onboarding: Use unique log message for localising text

fwiesel · fwiesel · commit de8c5a219748 · 2025-10-14T17:52:20.000+02:00
The log message was the same as in another delete case,
and that makes it hard to identify where it gets deleted.
diff --git a/internal/controller/onboarding_controller.go b/internal/controller/onboarding_controller.go
@@ -473,7 +473,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 			continue
 		}
 		if server.Name != serverName || foundServer != nil {
-			log.Info("deleting server", "name", server.Name)
+			log.Info("deleting outdated server", "name", server.Name)
 			err = servers.Delete(ctx, r.testComputeClient, server.ID).ExtractErr()
 			if err != nil && !gophercloud.ResponseCodeIs(err, http.StatusNotFound) {
 				log.Error(err, "failed deleting instance due to", "instance", server.ID)

Original file line number	Diff line number	Diff line change
`@@ -473,7 +473,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,`
`473`	`473`	`continue`
`474`	`474`	`}`
`475`	`475`	`if server.Name != serverName \|\| foundServer != nil {`
`476`		`- log.Info("deleting server", "name", server.Name)`
	`476`	`+ log.Info("deleting outdated server", "name", server.Name)`
`477`	`477`	`err = servers.Delete(ctx, r.testComputeClient, server.ID).ExtractErr()`
`478`	`478`	`if err != nil && !gophercloud.ResponseCodeIs(err, http.StatusNotFound) {`
`479`	`479`	`log.Error(err, "failed deleting instance due to", "instance", server.ID)`