Skip to content

Conversation

@notandy
Copy link
Contributor

@notandy notandy commented Oct 20, 2025

This commit switches the project to go-makefile-maker and fixes all golanci-lint issues

  • Switch to go-makefile-maker
  • [golangci-lint] should conform to the format, rewrite if-else to switch statement
  • [golangci-lint] unnamedResult: consider giving a name to these results
  • [golangci-lint] unnamedResult: paramTypeCombine
  • [golangci-lint] importShadow: shadow of imported
  • [golangci-lint] G404: Use of weak random number generator
  • [golangci-lint] G107: Potential HTTP request made with variable url
  • [golangci-lint] govet: shadow declaration
  • [golangci-lint] response body must be closed
  • [golangci-lint] for loop can be changed to use an integer range
  • [golangci-lint] fix golint annotations
  • [golangci-lint] fmt.Sprintf can be replaced with string concatenation
  • [golangci-lint] error-format: fmt.Errorf can be replaced with errors.New
  • [golangci-lint] unnecessary trailing newline, multi-line statement should be followed by a newline
  • [modernize] run modernize
  • Run make, regenerates applyconfiguration w/o header

@notandy notandy requested a review from fwiesel October 20, 2025 21:17
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@notandy notandy merged commit 54394b4 into main Oct 21, 2025
6 of 7 checks passed
@notandy notandy deleted the go-makefile-maker branch October 21, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants