introduce --label-selector option to limit reconcilled objects #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwiesel
reviewed
Oct 22, 2025
notandy
force-pushed
the
labelselector
branch
from
7627d2a to
0d01a64
Compare
notandy
force-pushed
the
labelselector
branch
from
0d01a64 to
25561e8
Compare
fwiesel
approved these changes
Oct 23, 2025
| return ctrl.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
|
|
||
| if global.LabelSelector != "" { |
Contributor
There was a problem hiding this comment.
Personally, I'd prefer if it would be the hypervisor resource, as my understanding is that should be the primary input for the controller as far as possible (and it is a "lighter" object).
And maybe move it to handlePreflight where it is even used.
But that is just my preference. If you want to merge it as it, that would be fine as well.
Contributor
Author
There was a problem hiding this comment.
I am with you, but I don't want to refactor in this PR.
notandy
force-pushed
the
labelselector
branch
from
25561e8 to
8ac48fe
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before rollout with selector enable, it's important to delete all related objects (like evictions and hypervisors) since else there will be some strange effects (e.g. hypervisor CROs without the label are not found, but cannot be created because they already exist)