test: Add tests for boot arguments

Co-authored-by: Marius Vollmer <marius.vollmer@gmail.com>

Author: mvollmer

test/check-machines-create

@@ -65,6 +65,15 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                                                             create_and_run=False,
                                                             pixel_test_tag="url"))
 
+        # boot argument check
+        runner.cancelDialogTest(TestMachinesCreate.VmDialog(self, sourceType='url',
+                                                            location=config.VALID_URL,
+                                                            memory_size=128, memory_size_unit='MiB',
+                                                            os_name=config.FEDORA_28,
+                                                            extra_arguments="foo=bar",
+                                                            create_and_run=False,
+                                                            pixel_test_tag="extra-args-url"))
+
         # OS input check
         runner.checkOsInputTest(TestMachinesCreate.VmDialog(self))
 
@@ -514,6 +523,15 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                                                                   os_name=config.FEDORA_28,
                                                                   os_short_id=config.FEDORA_28_SHORTID))
 
+        # test with --extra-args
+        runner.createDownloadAnOSTest(TestMachinesCreate.VmDialog(self, sourceType='os',
+                                                                  expected_memory_size=128,
+                                                                  expected_storage_size=128,
+                                                                  os_name=config.FEDORA_28,
+                                                                  os_short_id=config.FEDORA_28_SHORTID,
+                                                                  extra_arguments="foo=bar",
+                                                                  create_and_run=True))
+
         # name already used from a VM that is currently being created
         # https://bugzilla.redhat.com/show_bug.cgi?id=1780451
         runner.createDownloadAnOSTest(TestMachinesCreate.VmDialog(self, name='existing-name', sourceType='os',
@@ -820,6 +838,20 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                                                       storage_pool=NEW_VOLUME_RAW,
                                                       create_and_run=True,))
 
+        # test with --extra-args
+        dialog = TestMachinesCreate.VmDialog(self, sourceType='file',
+                                                      name="extra-args-file",
+                                                      location=config.TREE_FILE,
+                                                      memory_size=128, memory_size_unit='MiB',
+                                                      storage_size=128, storage_size_unit='MiB',
+                                                      extra_arguments="foo=bar",
+                                                      delete=False,
+                                                      create_and_run=True)
+        runner.createTest(dialog)
+        testlib.wait(lambda: "--extra-args foo=bar" in self.machine.execute("ps aux | grep '[v]irt-install'"))
+        runner._deleteVm(dialog)
+        runner.checkEnvIsEmpty()
+
     def testCreateImportDisk(self):
         runner = TestMachinesCreate.CreateVmRunner(self)
         config = TestMachinesCreate.TestCreateConfig
@@ -898,6 +930,20 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                                                       storage_size=128, storage_size_unit='MiB',
                                                       create_and_run=False))
 
+        # test with --extra-args
+        dialog = TestMachinesCreate.VmDialog(self, sourceType='url',
+                                             name="extra-args-url",
+                                             location=config.TREE_URL,
+                                             memory_size=128, memory_size_unit='MiB',
+                                             storage_size=128, storage_size_unit='MiB',
+                                             extra_arguments="foo=bar",
+                                             delete=False,
+                                             create_and_run=True)
+        runner.createTest(dialog)
+        testlib.wait(lambda: "--extra-args foo=bar" in m.execute("ps aux | grep '[v]irt-install'"))
+        runner._deleteVm(dialog)
+        runner.checkEnvIsEmpty()
+
         # This functionality works on debian only because of extra qemu-block-extra dep.
         # Check error is returned if dependency is missing
         if m.image.startswith("debian"):
@@ -944,6 +990,7 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
         PATH_WITH_SPACE = '/var/lib/libvirt/novell with spaces.iso'
         ISO_URL = 'https://archive.fedoraproject.org/pub/archive/fedora/linux/releases/28/Server/x86_64/os/images/boot.iso?foo=bar'
         TREE_URL = 'https://archive.fedoraproject.org/pub/archive/fedora/linux/releases/28/Server/x86_64/os'
+        TREE_FILE = '/var/lib/libvirt/pub/archive/fedora/linux/releases/28/Server/x86_64/os/'
 
         # LINUX can be filtered if 3 years old
         OLD_FILTERED_OS = 'Red Hat Enterprise Linux 8.3 (Ootpa)'
@@ -995,6 +1042,7 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                      connection="system",
                      offline_token=None,
                      offline_token_autofilled=True,
+                     extra_arguments=None,
                      pixel_test_tag=None):
 
             TestMachinesCreate.VmDialog.vmId += 1  # This variable is static - don't use self here
@@ -1049,6 +1097,7 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
             self.name_generated = name_generated
             self.offline_token = offline_token
             self.offline_token_autofilled = offline_token_autofilled
+            self.extra_arguments = extra_arguments
 
             self.pixel_test_tag = pixel_test_tag
 
@@ -1337,6 +1386,8 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                     if self.user_login:
                         user_login = virt_install_cmd_out.split("user-login=", 1)[1].split(",")[0].rstrip()
                         self.assertIn(user_login, self.user_login)
+                if self.extra_arguments:
+                    self.assertIn(f"--extra-args {self.extra_arguments}", virt_install_cmd_out)
                 return True
 
             testlib.wait(virt_install_correct, tries=180)
@@ -1471,6 +1522,18 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
                 else:
                     b.wait_visible("#create-and-run:not([aria-disabled=true])")
 
+                if self.sourceType == "cloud":
+                    b.wait_not_present("#extra-argument")
+                else:
+                    b.wait_visible("#extra-argument")
+
+            if self.extra_arguments:
+                if (self.sourceType in ["file", "url"] and not self.sourceType.endswith(".iso")) \
+                or self.sourceType == "os":
+                    b.click("#pf-tab-1-automation")
+
+                b.set_input_text("#extra-argument", self.extra_arguments)
+
             return self
 
         def cancel(self, force=False):
@@ -2090,7 +2153,8 @@ class TestMachinesCreate(machineslib.VirtualMachinesCase):
             if dialog.sourceType != 'cloud':
                 self.browser.mouse(".pf-v6-c-tabs__list button[aria-disabled=true]:contains(Automation)",
                                    "mouseenter")
-                tooltip_text = "Automated installs are only available when downloading an image or using cloud-init."
+                tooltip_text = "Automated installs are only available when downloading an image,"
+                tooltip_text += " an install tree or using cloud-init."
                 self.browser.wait_in_text("div.pf-v6-c-tooltip__content", tooltip_text)
                 self.browser.mouse(".pf-v6-c-tabs__list button[aria-disabled=true]:contains(Automation)",
                                    "mouseleave")