Skip to content

Commit dc960ea

Browse files
authored
nics: Replace text about direct mode with link to external docs (#2171)
The text was too massive, jargony, ultimately not super helpful out of context, and we don't want to subject our translators to it. So let's just put the link to the libvirt documentation back.
1 parent b3b0948 commit dc960ea

File tree

1 file changed

+12
-20
lines changed

1 file changed

+12
-20
lines changed

src/components/vm/nics/nicBody.jsx

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,14 @@
1919

2020
import React from 'react';
2121
import PropTypes from 'prop-types';
22+
import { Button } from "@patternfly/react-core/dist/esm/components/Button";
2223
import { Flex } from "@patternfly/react-core/dist/esm/layouts/Flex";
2324
import { FormGroup } from "@patternfly/react-core/dist/esm/components/Form";
2425
import { FormSelect, FormSelectOption } from "@patternfly/react-core/dist/esm/components/FormSelect";
2526
import { Radio } from "@patternfly/react-core/dist/esm/components/Radio";
2627
import { PopoverPosition } from "@patternfly/react-core/dist/esm/components/Popover";
2728
import { Content, ContentVariants } from "@patternfly/react-core/dist/esm/components/Content";
29+
import { ExternalLinkSquareAltIcon } from '@patternfly/react-icons';
2830

2931
import { InfoPopover } from '../../common/infoPopover.jsx';
3032

@@ -196,29 +198,19 @@ export const NetworkTypeAndSourceRow = ({ idPrefix, onValueChanged, dialogValues
196198
enableFlip={false}
197199
bodyContent={
198200
<Content>
199-
<Content component={ContentVariants.h4}>
200-
VEPA
201-
</Content>
202-
<Content component={ContentVariants.p}>
203-
{_("All VMs' packets are sent to the external bridge. Packets whose destination is a VM on the same host as where the packet originates from are sent back to the host by the VEPA capable bridge (today's bridges are typically not VEPA capable)")}.
204-
</Content>
205-
<Content component={ContentVariants.h4}>
206-
{_("Bridge")}
207-
</Content>
208201
<Content component={ContentVariants.p}>
209-
{_("Packets whose destination is on the same host as where they originate from are directly delivered to the target macvtap device. Both origin and destination devices need to be in bridge mode for direct delivery. If either one of them is in \"VEPA\" mode, a VEPA capable bridge is required.")}
210-
</Content>
211-
<Content component={ContentVariants.h4}>
212-
{_("Private")}
213-
</Content>
214-
<Content component={ContentVariants.p}>
215-
{_("All packets are sent to the external bridge and will only be delivered to a target VM on the same host if they are sent through an external router or gateway and that device sends them back to the host. This procedure is followed if either the source or destination device is in \"Private\" mode.")}
216-
</Content>
217-
<Content component={ContentVariants.h4}>
218-
{_("Passthrough")}
202+
{_("The mode influences the delivery of packets.")}
219203
</Content>
220204
<Content component={ContentVariants.p}>
221-
{_("This feature attaches a virtual function of a SRIOV capable NIC directly to a VM without losing the migration capability. All packets are sent to the VF/IF of the configured network device. Depending on the capabilities of the device additional prerequisites or limitations may apply.")}
205+
<Button isInline
206+
variant="link"
207+
component="a"
208+
icon={<ExternalLinkSquareAltIcon />}
209+
iconPosition="right"
210+
target="__blank"
211+
href="https://libvirt.org/formatdomain.html#direct-attachment-to-physical-interface">
212+
{_("More info")}
213+
</Button>
222214
</Content>
223215
</Content>}
224216
/>

0 commit comments

Comments
 (0)