Skip to content

Commit 1e22d05

Browse files
committed
test: Skip currently failing opensuse-tumbleweed/other tests
This establishes a baseline for introducing opensuse-tumbleweed into our CI. We'll start with the `/ohter` scenario. There are currently 111 passing and 47 failing tests. A few of them are obvious, like crypto-policies and setroubleshoot not being available on Tumbleweed, adjust their skips accordingly. For the rest, just mass-skip them with "TODO: fix for OpenSUSE", which is easy enough to grep. After that, we can enable them step by step with actual fixes. E.g. large swaths of functionality is broken due to PackageKit.
1 parent 810f537 commit 1e22d05

18 files changed

+39
-6
lines changed

test/verify/check-apps

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import testlib
1212

1313

1414
@testlib.skipWsContainer("Not supported")
15+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
1516
@testlib.nondestructive
1617
class TestApps(packagelib.PackageCase):
1718

test/verify/check-client

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import testlib
1010

1111
# enable this once our cockpit/ws container can beiboot
1212
@testlib.skipWsContainer("client setup does not work with ws container")
13+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
1314
class TestClient(testlib.MachineCase):
1415

1516
provision = {

test/verify/check-connection

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1509,6 +1509,7 @@ Command={self.libexecdir}/cockpit-session
15091509
self.assertIn('sudo', bridge_names)
15101510

15111511

1512+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
15121513
class TestReverseProxy(testlib.MachineCase):
15131514

15141515
provision = {

test/verify/check-loopback

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import testlib
99

1010

1111
@testlib.skipWsContainer("cockpit/ws always uses loopback")
12+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
1213
@testlib.nondestructive
1314
class TestLoopback(testlib.MachineCase):
1415

test/verify/check-metrics

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ class TestHistoryMetrics(testlib.MachineCase):
605605
self.assertEqual(m.execute("systemctl is-enabled pmlogger").strip(), "enabled")
606606

607607
@testlib.nondestructive
608+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
608609
def testPmProxySettings(self, customRedisService=None):
609610
b = self.browser
610611
m = self.machine
@@ -1033,6 +1034,7 @@ class TestCurrentMetrics(testlib.MachineCase):
10331034
b.enter_page("/system/services")
10341035
b.wait_in_text(".service-name", "/usr/bin/dd if=/dev/urandom of=/dev/null")
10351036

1037+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
10361038
def testMemory(self):
10371039
b = self.browser
10381040
m = self.machine
@@ -1313,6 +1315,7 @@ BEGIN {{
13131315

13141316
@testlib.skipImage("TODO: Arch Linux packagekit support", "arch")
13151317
@testlib.skipImage("image has pcp installed, but cannot be removed", "*-bootc")
1318+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
13161319
class TestMetricsPackages(packagelib.PackageCase):
13171320
pcp_dialog_selector = "#pcp-settings-modal"
13181321

@@ -1491,6 +1494,7 @@ class TestMultiCPU(testlib.MachineCase):
14911494

14921495

14931496
@testlib.skipOstree("no PCP support")
1497+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
14941498
class TestGrafanaClient(testlib.MachineCase):
14951499

14961500
provision = {

test/verify/check-packagekit

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1240,6 +1240,7 @@ ExecStart=/usr/local/bin/{packageName}
12401240

12411241
@testlib.skipImage("TODO: Arch Linux has no cockpit-ws package, it's in cockpit", "arch")
12421242
@testlib.skipWsContainer("no cockpit-ws package with cockpit/ws container")
1243+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
12431244
class TestWsUpdate(NoSubManCase):
12441245
def testBasic(self):
12451246
# The main case for this is that cockpit-ws itself gets upgraded, which
@@ -1305,6 +1306,7 @@ class TestWsUpdate(NoSubManCase):
13051306

13061307

13071308
@testlib.skipImage("kpatch is not available", *OSesWithoutKpatch)
1309+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
13081310
class TestKpatchInstall(NoSubManCase):
13091311
def testBasic(self):
13101312
b = self.browser
@@ -1836,6 +1838,7 @@ WantedBy=basic.target
18361838

18371839

18381840
@testlib.skipOstree("Image uses OSTree")
1841+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
18391842
@testlib.nondestructive
18401843
class TestInstallDialog(NoSubManCase):
18411844

test/verify/check-reauthorize

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ class TestReauthorize(testlib.MachineCase):
6969
b.leave_page()
7070
b.check_superuser_indicator("")
7171

72+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
7273
def testSudo(self):
7374
m = self.machine
7475
b = self.browser

test/verify/check-selinux

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class TestSelinux(testlib.MachineCase):
4444
"ansible_machine": {"image": TEST_OS_DEFAULT}
4545
}
4646

47-
@testlib.skipImage("No setroubleshoot", "debian-*", "ubuntu-*", "arch")
47+
@testlib.skipImage("No setroubleshoot", "debian-*", "ubuntu-*", "arch", "opensuse-tumbleweed")
4848
@testlib.skipOstree("No setroubleshoot")
4949
@testlib.skipBrowser("Firefox fails to recognize 'clipboard-read' permission", "firefox")
5050
def testTroubleshootAlerts(self):
@@ -294,7 +294,7 @@ class TestSelinux(testlib.MachineCase):
294294

295295
# https://github.com/fedora-selinux/selinux-policy/issues/2947
296296
@testlib.skipDaily("nightly has selinux set to permissive")
297-
@testlib.skipImage("No cockpit-selinux", "debian-*", "ubuntu-*", "arch")
297+
@testlib.skipImage("No cockpit-selinux", "debian-*", "ubuntu-*", "arch", "opensuse-tumbleweed")
298298
@testlib.skipOstree("No cockpit-selinux")
299299
@testlib.nondestructive
300300
class TestSelinuxEnforcing(testlib.MachineCase):

test/verify/check-session

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import testlib
1111
@testlib.nondestructive
1212
class TestSession(testlib.MachineCase):
1313

14+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
1415
def testBasic(self):
1516
m = self.machine
1617
b = self.browser

test/verify/check-shell-keys

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ class TestKeys(testlib.MachineCase):
137137

138138
# Possible workaround - ssh as `admin` and just do `m.execute()`
139139
@testlib.skipBrowser("Firefox cannot do `cockpit.spawn`", "firefox")
140+
@testlib.skipImage("TODO: fix for OpenSUSE", "opensuse-tumbleweed")
140141
def testPrivateKeys(self):
141142
b = self.browser
142143
m = self.machine

0 commit comments

Comments
 (0)