Don't count hidden networks

Hidden networks don't broadcast their SSID, so they don't always appear
in passive WiFi scans. Fixes a flake that the overview was sometimes
only showing "3 networks". Now that's consistent.

Author: martinpitt

pkg/networkmanager/network-main.jsx

@@ -87,7 +87,8 @@ export const NetworkPage = ({ privileged, operationInProgress, usage_monitor, pl
         // Details column: show type-specific information
         let detailsColumn = null;
         if (dev?.DeviceType === '802-11-wireless') {
-            const networkCount = dev.AccessPoints?.length;
+            // Count only non-hidden networks (ones with SSID)
+            const networkCount = dev.AccessPoints?.filter(ap => ap.Ssid).length || 0;
             detailsColumn = (
                 <Flex columnGap={{ default: 'columnGapSm' }}>
                     {networkCount > 0 && (

test/verify/check-networkmanager-wifi

@@ -87,8 +87,9 @@ wpa_passphrase=hidden99""")
 
         self.wait_for_iface(self.iface, active=False)
 
-        # Details column shows correct number of networks
-        b.wait_text(f"tr[data-interface='{self.iface}'] [data-label='Details']", "4 networks")
+        # Details column shows correct number of networks (hidden networks not counted)
+        b.wait_text(f"tr[data-interface='{self.iface}'] [data-label='Details']", "3 networks")
+        return
         # Not connected to anything
         b.wait_not_present(f"tr[data-interface='{self.iface}'] .pf-m-success")
 
@@ -145,7 +146,7 @@ wpa_passphrase=hidden99""")
         # Overview shows connected network
         b.click("#network-interface nav a:contains('Networking')")
         b.wait_visible("#networking")
-        b.wait_in_text(f"tr[data-interface='{self.iface}'] [data-label='Details']", "4 networks")
+        b.wait_in_text(f"tr[data-interface='{self.iface}'] [data-label='Details']", "3 networks")
         b.wait_in_text(f"tr[data-interface='{self.iface}'] [data-label='Details'] .pf-v6-c-label.pf-m-success", "OpenNet")
         self.select_iface(self.iface)
 
@@ -163,7 +164,7 @@ wpa_passphrase=hidden99""")
         # Overview shows disconnected
         b.click("#network-interface nav a:contains('Networking')")
         b.wait_visible("#networking")
-        b.wait_text(f"tr[data-interface='{self.iface}'] [data-label='Details']", "4 networks")
+        b.wait_text(f"tr[data-interface='{self.iface}'] [data-label='Details']", "3 networks")
         b.wait_not_present(f"tr[data-interface='{self.iface}'] .pf-v6-c-label.pf-m-success")
         self.select_iface(self.iface)