network: add test for cockpit_has_checkpoint event

Related: COCKPIT-1417

Author: rvykydal

test/browser/run-test.sh

@@ -99,6 +99,8 @@ if [ "$PLAN" = "main" ]; then
               TestNetworkingBasic.testNoService
               TestNetworkingCheckpoints.testCheckpoint
               TestNetworkingCheckpoints.testCheckpointSlowRollback
+              TestNetworkingCheckpoints.testCheckpointSessionStorageEventSuccess
+              TestNetworkingCheckpoints.testCheckpointSessionStorageEventRollback
               TestNetworkingUnmanaged.testUnmanaged
 
               TestSOS.testWithUrlRoot

test/verify/check-networkmanager-checkpoints

@@ -174,6 +174,99 @@ class TestNetworkingCheckpoints(netlib.NetworkCase):
 
         testlib.wait(checkpoint_was_destroyed)
 
+    def testCheckpointSessionStorageEventSuccess(self):
+        b = self.browser
+
+        self.login_and_go("/network")
+        self.nm_checkpoints_enable()
+        b.wait_visible("#networking")
+
+        iface = 'cockpit1'
+        self.add_veth(iface, dhcp_cidr="10.111.114.2/20")
+        self.nm_activate_eth(iface)
+        self.wait_for_iface(iface)
+
+        self.select_iface(iface)
+        b.wait_visible("#network-interface")
+
+        # Verify sessionStorage is initially false or not set
+        initial_value = b.call_js_func("window.sessionStorage.getItem", "cockpit_has_checkpoint")
+        self.assertIn(initial_value, [None, "false"])
+
+        # Change IP settings which will trigger a checkpoint
+        self.configure_iface_setting('IPv4')
+        b.wait_visible("#network-ip-settings-dialog")
+        b.select_from_dropdown("#network-ip-settings-select-method", "manual")
+        b.set_input_text('#network-ip-settings-address-0', "10.111.114.100")
+        b.set_input_text('#network-ip-settings-netmask-0', "20")
+
+        # Click save, which triggers checkpoint creation
+        b.click("#network-ip-settings-save")
+
+        # Verify sessionStorage becomes true during checkpoint operation
+        def checkpoint_active():
+            value = b.call_js_func("window.sessionStorage.getItem", "cockpit_has_checkpoint")
+            return value == "true"
+
+        testlib.wait(checkpoint_active)
+
+        # Wait for operation to complete and sessionStorage to be cleared
+        def checkpoint_cleared():
+            value = b.call_js_func("window.sessionStorage.getItem", "cockpit_has_checkpoint")
+            return value == "false"
+
+        testlib.wait(checkpoint_cleared)
+
+    def testCheckpointSessionStorageEventRollback(self):
+        b = self.browser
+        m = self.machine
+
+        self.login_and_go("/network")
+        self.nm_checkpoints_enable()
+        b.wait_visible("#networking")
+
+        iface = self.get_iface("52:54:00:12:34:56")
+
+        if "debian" in m.image:
+            self.sed_file("s/managed=false/managed=true/", "/etc/NetworkManager/NetworkManager.conf",
+                          "systemctl restart NetworkManager")
+
+        if m.image == "arch":
+            self.sed_file("s/unmanaged-devices=interface-name:eth0//", "/etc/NetworkManager/conf.d/noauto.conf",
+                          "systemctl restart NetworkManager")
+
+        self.wait_for_iface(iface, prefix="172.")
+        self.select_iface(iface)
+        b.wait_visible("#network-interface")
+
+        # Verify sessionStorage is initially false or not set
+        initial_value = b.call_js_func("window.sessionStorage.getItem", "cockpit_has_checkpoint")
+        self.assertIn(initial_value, [None, "false"])
+
+        # Disconnect interface which will trigger checkpoint and should cause rollback dialog
+        self.wait_onoff("label[for='interface-switch']", val=True)
+        self.toggle_onoff("label[for='interface-switch']")
+
+        # Verify sessionStorage becomes true during checkpoint operation
+        def checkpoint_active():
+            value = b.call_js_func("window.sessionStorage.getItem", "cockpit_has_checkpoint")
+            return value == "true"
+
+        testlib.wait(checkpoint_active)
+
+        # Wait for dialog to appear (this happens when checkpoint_destroy fails)
+        with b.wait_timeout(60):
+            b.wait_visible("#confirm-breaking-change-popup")
+
+            # By the time dialog is visible, sessionStorage should already be cleared
+            checkpoint_cleared_value = b.call_js_func("window.sessionStorage.getItem", "cockpit_has_checkpoint")
+            self.assertEqual(checkpoint_cleared_value, "false")
+
+            # Keep the connection (rollback)
+            b.click("#confirm-breaking-change-popup button:contains('Keep connection')")
+
+        b.wait_not_present("#confirm-breaking-change-popup")
+
 
 if __name__ == '__main__':
     testlib.test_main()