networkmanager: use connection.type as a fallback

fixes: RHEL-131244

When a connection is in the state `down` the `dev` variable can be `null`
as no device exists and will be created once the connection is `up`.
Use `connection.type` as a fallback to determine what kind of device the IP
settings modal is working with.

Author: tomasmatus

pkg/networkmanager/ip-settings.jsx

@@ -155,6 +155,10 @@ export const IpSettingsDialog = ({ topic, connection, dev, settings }) => {
         } else return { ...config, gateway: '' };
     };
 
+    // Prefer device type if the device exists, otherwise fallback to a connection type
+    // of an existing connection that is down in which case the device may not exist.
+    const deviceType = dev?.DeviceType ?? connection?.Settings.connection.type;
+
     return (
         <NetworkModal dialogError={dialogError}
                       idPrefix={idPrefix}
@@ -174,7 +178,7 @@ export const IpSettingsDialog = ({ topic, connection, dev, settings }) => {
                                             aria-label={_("Select method")}
                                             onChange={(_, val) => setMethod(val)}
                                             value={method}>
-                                    {get_ip_method_choices(topic, dev.DeviceType).map(choice => <FormSelectOption value={choice.choice} label={choice.title} key={choice.choice} />)}
+                                    {get_ip_method_choices(topic, deviceType).map(choice => <FormSelectOption value={choice.choice} label={choice.title} key={choice.choice} />)}
                                 </FormSelect>
                                 <Tooltip content={_("Add address")}>
                                     <Button variant="secondary"

test/verify/check-networkmanager-basic

@@ -156,6 +156,49 @@ class TestNetworkingBasic(netlib.NetworkCase):
 
         testlib.wait(lambda: "yes" in m.execute(f"nmcli -f ipv4.ignore-auto-dns connection show '{con_id}'"))
 
+        b.go("/network")
+        # Create a bridge interface and disable it to test if disabled connections can be modified.
+        # Connection exists, is down and the device itself does not exist as long as the connection is down
+        m.execute("nmcli con add con-name cockpitbr type bridge ifname cockpitbr ipv4.meth disab ipv6.meth disab")
+        self.addCleanup(m.execute, "nmcli con del cockpitbr")
+        self.wait_for_iface("cockpitbr", prefix="No carrier")
+        m.execute("nmcli con down cockpitbr")
+        self.wait_for_iface("cockpitbr", active=False)
+        # check that connection exists but interface does not
+        m.execute("nmcli con sh | grep -q 'cockpitbr'")
+        m.execute("ip link sh | grep -q --invert-match 'cockpitbr'")
+
+        self.select_iface("cockpitbr")
+        b.wait_visible("#network-interface")
+        self.wait_for_iface_setting("Status", "Inactive")
+
+        # Configure IPv4 address
+        self.configure_iface_setting("IPv4")
+        b.wait_visible("#network-ip-settings-dialog")
+        b.select_from_dropdown("#network-ip-settings-select-method", "manual")
+        b.wait_visible("#network-ip-settings-address-0")
+        b.set_input_text("#network-ip-settings-address-0", "10.0.5.10")
+        b.set_input_text("#network-ip-settings-netmask-0", "24")
+        b.set_input_text("#network-ip-settings-gateway-0", "10.0.5.1")
+        b.click("#network-ip-settings-save")
+        self.wait_for_iface_setting("IPv4", "Address 10.0.5.10/24 via 10.0.5.1")
+        # Configure IPv6 address
+        self.configure_iface_setting("IPv6")
+        b.wait_visible("#network-ip-settings-dialog")
+        b.select_from_dropdown("#network-ip-settings-select-method", "manual")
+        b.wait_visible("#network-ip-settings-address-0")
+        b.set_input_text("#network-ip-settings-address-0", "2001:db8::10")
+        b.set_input_text("#network-ip-settings-netmask-0", "64")
+        b.set_input_text("#network-ip-settings-gateway-0", "2001:db8::1")
+        b.click("#network-ip-settings-save")
+        self.wait_for_iface_setting("IPv6", "Address 2001:db8::10/64 via 2001:db8::1")
+
+        # Start the interface and verify new address is set
+        b.click("#interface-switch")
+        self.wait_for_iface_setting("Status", "10.0.5.10/24,")
+        m.execute("ip addr sh cockpitbr | grep -q 'inet 10.0.5.10/24'")
+        m.execute("ip addr sh cockpitbr | grep -q 'inet6 2001:db8::10/64'")
+
     def testIpHelper(self):
         b = self.browser
         m = self.machine