temp: a bit clearer logs

Author: BuonOmo

lib/active_record/connection_adapters/cockroachdb/referential_integrity.rb

@@ -35,7 +35,7 @@ def check_all_foreign_keys_valid!
 
         def disable_referential_integrity
           foreign_keys = all_foreign_keys
-          dropped_fks = foreign_keys.size
+          dropped_fks = foreign_keys
 
           statements = foreign_keys.map do |foreign_key|
             # We do not use the `#remove_foreign_key` method here because it
@@ -70,18 +70,23 @@ def disable_referential_integrity
             # for every key. This method is performance critical for the test suite, hence
             # we use the `#all_foreign_keys` method that only make one query to the database.
             already_inserted_foreign_keys = all_foreign_keys
+            new_fks = []
             statements = foreign_keys.map do |foreign_key|
               next if already_inserted_foreign_keys.any? { |fk| fk.from_table == foreign_key.from_table && fk.options[:name] == foreign_key.options[:name] }
 
               options = foreign_key_options(foreign_key.from_table, foreign_key.to_table, foreign_key.options)
               at = create_alter_table foreign_key.from_table
               at.add_foreign_key foreign_key.to_table, options
 
+              new_fks << foreign_key
               schema_creation.accept(at)
             end
             execute_batch(statements.compact, "Disable referential integrity -> add foreign keys")
-            new_fks = statements.compact.size
-            STDOUT.puts "FK DIFF: #{new_fks - dropped_fks}"
+
+            new_fks = new_fks.map { _1.from_table + " -> " + _1.to_table + (_1.options[:name] ? " (#{_1.options[:name]})" : "") }
+            dropped_fks = dropped_fks.map { _1.from_table + " -> " + _1.to_table + (_1.options[:name] ? " (#{_1.options[:name]})" : "") }
+            STDOUT.puts "FK DIFF NEW:\n", (new_fks - dropped_fks).map{ "\t#{_1}" } if (new_fks - dropped_fks).any?
+            STDOUT.puts "FK DIFF OLD:\n", (dropped_fks - new_fks).map{ "\t#{_1}" } if (dropped_fks - new_fks).any?
           ensure
             ActiveRecord::Base.table_name_prefix = old_prefix
             ActiveRecord::Base.table_name_suffix = old_suffix