Skip to content

Commit 18ec0ef

Browse files
committed
cached plan change
1 parent 08e7847 commit 18ec0ef

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lib/active_record/connection_adapters/cockroachdb_adapter.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -475,9 +475,7 @@ def crdb_column_definitions(table_name)
475475
# That method will not work for CockroachDB because the error
476476
# originates from the "runExecBuilder" function, so we need
477477
# to modify the original to match the CockroachDB behavior.
478-
def is_cached_plan_failure?(e)
479-
pgerror = e.cause
480-
478+
def is_cached_plan_failure?(pgerror)
481479
pgerror.result.result_error_field(PG::PG_DIAG_SQLSTATE) == FEATURE_NOT_SUPPORTED &&
482480
pgerror.result.result_error_field(PG::PG_DIAG_SOURCE_FUNCTION) == "runExecBuilder"
483481
rescue

test/excludes/PostgresqlPointTest.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@
1212
exclude :test_legacy_schema_dumping, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
1313
exclude :test_legacy_roundtrip, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
1414
exclude :test_legacy_mutation, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
15+
exclude :test_hash_assignment, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."

0 commit comments

Comments
 (0)