refactor: various

- fix geos-config file fetching
- refactor for loop into any?
- unexclude working tests

Author: BuonOmo

bin/start-cockroachdb

@@ -19,7 +19,7 @@ fi
 
 cockroach start-single-node \
 	--insecure --store=type=mem,size=0.25 --advertise-addr=localhost \
-	--spatial-libs="$(geos-config --includes)" \
+	--spatial-libs="$(geos-config --prefix)/lib" \
 	--pid-file "$pid_file" \
 	&> "$log_file" &
 

test/cases/helper_cockroachdb.rb

@@ -112,13 +112,9 @@ def run_one_method(klass, method_name, reporter)
       res = Minitest.run_one_method(klass, method_name)
       final_res ||= res
 
-      retryable = false
-      if res.error?
-        res.failures.each do |f|
-          retryable = true if f.message.include?("ActiveRecord::InvalidForeignKey")
-        end
-      end
+      retryable = res.error? && res.failures.any? { _1.message.include?("ActiveRecord::InvalidForeignKey") }
       (final_res = res) && break unless retryable
+
     end
 
     # report message from first failure or from success

test/excludes/ActiveRecord/AdapterTestWithoutTransaction.rb

@@ -1,3 +1 @@
 exclude :test_reset_empty_table_with_custom_pk, "The test fails because serial primary keys in CockroachDB are created with unique_rowid() where PostgreSQL will create them with a sequence. See https://www.cockroachlabs.com/docs/v19.2/serial.html#modes-of-operation"
-exclude :test_truncate_tables, "This is override to prevent an intermittent error. Table fk_test_has_pk has constrain droped and not created back"
-exclude :test_truncate_tables_with_query_cache, "This is override to prevent an intermittent error. Table fk_test_has_pk has constrain droped and not created back"

test/excludes/ActiveRecord/PostgresqlConnectionTest.rb

@@ -1,4 +1,3 @@
-exclude :test_default_client_min_messages, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
 exclude :test_get_and_release_advisory_lock, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
 exclude :test_reconnection_after_actual_disconnection_with_verify, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
 exclude :test_reset, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"