fix(ci): Github Action reporter priority

When using `--fail-fast` option the rails reporter could raise before
the Github Action reporter records the failure. Hence we invert them.

Signed-off-by: Ulysse Buonomo <[email protected]>

Author: BuonOmo

test/cases/helper_cockroachdb.rb

@@ -7,7 +7,6 @@ module ExcludeMessage
 end
 
 require "minitest/excludes"
-require "minitest/github_action_reporter"
 
 # This gives great visibility on schema dump related tests, but
 # some rails specific messages are then ignored.
@@ -152,21 +151,34 @@ def with_postgresql_datetime_type(type)
 
 ActiveRecord::TestCase.prepend(SetDatetimeInCockroachDBAdapter)
 
-module Minitest
-  module GithubActionReporterExt
-    def gh_link(loc)
-      return super unless loc.include?("/gems/")
+if ENV["GITHUB_ACTIONS"] || true
+  require "minitest/github_action_reporter"
 
-      path, _, line = loc[%r(/(?:test|spec|lib)/.*)][1..].rpartition(":")
+  module Minitest
+    module GithubActionReporterExt
+      def gh_link(loc)
+        return super unless loc.include?("/gems/")
 
-      rails_version = "v#{ActiveRecord::VERSION::STRING}"
-      "#{ENV["GITHUB_SERVER_URL"]}/rails/rails/blob/#{rails_version}/activerecord/#{path}#L#{line}"
-    rescue
-      warn "Failed to generate link for #{loc}"
-      super
+        path, _, line = loc[%r(/(?:test|spec|lib)/.*)][1..].rpartition(":")
+
+        rails_version = "v#{ActiveRecord::VERSION::STRING}"
+        "#{ENV["GITHUB_SERVER_URL"]}/rails/rails/blob/#{rails_version}/activerecord/#{path}#L#{line}"
+      rescue
+        warn "Failed to generate link for #{loc}"
+        super
+      end
     end
+    GithubActionReporter.prepend(GithubActionReporterExt)
+  end
+
+  # Using '--fail-fast' may cause the github_action_reporter to not
+  # catch the error or failure in time. We make sure it appears first.
+  Minitest.load_plugins
+  github_action_index = Minitest.extensions.index("github_action_reporter")
+  if github_action_index&.positive?
+    Minitest.extensions[0], Minitest.extensions[github_action_index] =
+      Minitest.extensions[github_action_index], Minitest.extensions[0]
   end
-  GithubActionReporter.prepend(GithubActionReporterExt)
 end
 
 if ENV['TRACE_LIB']

test/support/copy_cat.rb

@@ -20,7 +20,7 @@ def warn(message, category: nil, **kwargs)
 
   # Copy methods from The original rails class to our adapter.
   # While copying, we can rewrite the source code of the method using
-  # ast. Use `debug: true` to lead you true that process.
+  # ast. Use `debug: true` to lead you through that process.
   def copy_methods(new_klass, old_klass, *methods, debug: false, &block)
     methods.each do |met|
       file, _ = old_klass.instance_method(met).source_location

test/support/exclude_from_transactional_tests.rb

@@ -18,7 +18,6 @@ def self.prepended(base)
   end
 
   def before_setup
-    # binding.irb if self.class.non_transactional_list.include?(@NAME.to_s)
     @old_use_transactional_tests = self.use_transactional_tests
     if @old_use_transactional_tests # stay false if false
       self.use_transactional_tests = !self.class.non_transactional_list.include?(@NAME.to_s)