Skip to content

Commit 5abb325

Browse files
BuonOmorafiss
authored andcommitted
chore: remove noisy outdated overrides
1 parent 2e06103 commit 5abb325

File tree

3 files changed

+1
-62
lines changed

3 files changed

+1
-62
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
name: Test (crdb=${{ matrix.crdb }} ruby=${{ matrix.ruby }})
4444
steps:
4545
- name: Set Up Actions
46-
uses: actions/checkout@v3
46+
uses: actions/checkout@v4
4747
- name: Install GEOS
4848
run: sudo apt-get install libgeos-dev
4949
- name: Set Up Ruby

test/cases/schema_dumper_test.rb

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -212,64 +212,5 @@ def test_schema_dumps_check_constraints
212212
end
213213
end
214214
end
215-
216-
def test_schema_dump_defaults_with_universally_supported_types
217-
original, $stdout = $stdout, StringIO.new
218-
219-
migration = Class.new(ActiveRecord::Migration::Current) do
220-
def up
221-
create_table("defaults_with_universally_supported_types") do |t|
222-
t.string :string_with_default, default: 'Hello!'
223-
t.date :date_with_default, default: '2014-06-05'
224-
t.datetime :datetime_with_default, default: '2014-06-05 07:17:04'
225-
t.time :time_with_default, default: '2000-01-01 07:17:04'
226-
t.decimal :decimal_with_default, precision: 20, scale: 10, default: '1234567890.0123456789'
227-
end
228-
end
229-
def down
230-
drop_table("defaults_with_universally_supported_types")
231-
end
232-
end
233-
migration.migrate(:up)
234-
235-
output = perform_schema_dump
236-
237-
assert output.include?('t.string "string_with_default", default: "Hello!"')
238-
assert output.include?('t.date "date_with_default", default: "2014-06-05"')
239-
240-
if supports_datetime_with_precision?
241-
assert output.include?('t.datetime "datetime_with_default", default: "2014-06-05 07:17:04"')
242-
else
243-
assert output.include?('t.datetime "datetime_with_default", precision: nil, default: "2014-06-05 07:17:04"')
244-
end
245-
246-
assert output.include?('t.time "time_with_default", default: "2000-01-01 07:17:04"')
247-
assert output.include?('t.decimal "decimal_with_default", precision: 20, scale: 10, default: "1234567890.0123456789"')
248-
ensure
249-
migration.migrate(:down)
250-
$stdout = original
251-
end
252-
253-
if supports_text_column_with_default?
254-
def test_schema_dump_with_text_column
255-
migration = Class.new(ActiveRecord::Migration::Current) do
256-
def up
257-
create_table("text_column_with_default") do |t|
258-
t.text :text_with_default, default: "John' Doe"
259-
end
260-
end
261-
def down
262-
drop_table("text_column_with_default")
263-
end
264-
end
265-
migration.migrate(:up)
266-
267-
output = perform_schema_dump
268-
269-
assert output.include?('t.text "text_with_default", default: "John\' Doe"')
270-
ensure
271-
migration.migrate(:down)
272-
end
273-
end
274215
end
275216
end
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
11
exclude :test_schema_dump_with_column_infinity_default, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
2-
exclude :test_schema_dump_defaults_with_universally_supported_types, "Re-implementing ourselves because we need CockroachDB specific methods."
3-
exclude :test_schema_dump_with_text_column, "Re-implementing ourselves because we need CockroachDB specific methods."

0 commit comments

Comments
 (0)