chore: remove noisy outdated overrides

Author: BuonOmo

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
     name: Test (crdb=${{ matrix.crdb }} ruby=${{ matrix.ruby }})
     steps:
       - name: Set Up Actions
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install GEOS
         run: sudo apt-get install libgeos-dev
       - name: Set Up Ruby

test/cases/schema_dumper_test.rb

@@ -212,64 +212,5 @@ def test_schema_dumps_check_constraints
         end
       end
     end
-
-    def test_schema_dump_defaults_with_universally_supported_types
-      original, $stdout = $stdout, StringIO.new
-
-      migration = Class.new(ActiveRecord::Migration::Current) do
-        def up
-          create_table("defaults_with_universally_supported_types") do |t|
-            t.string :string_with_default, default: 'Hello!'
-            t.date :date_with_default, default: '2014-06-05'
-            t.datetime :datetime_with_default, default: '2014-06-05 07:17:04'
-            t.time :time_with_default, default: '2000-01-01 07:17:04'
-            t.decimal :decimal_with_default, precision: 20, scale: 10, default: '1234567890.0123456789'
-          end
-        end
-        def down
-          drop_table("defaults_with_universally_supported_types")
-        end
-      end
-      migration.migrate(:up)
-
-      output = perform_schema_dump
-
-      assert output.include?('t.string "string_with_default", default: "Hello!"')
-      assert output.include?('t.date "date_with_default", default: "2014-06-05"')
-
-      if supports_datetime_with_precision?
-        assert output.include?('t.datetime "datetime_with_default", default: "2014-06-05 07:17:04"')
-      else
-        assert output.include?('t.datetime "datetime_with_default", precision: nil, default: "2014-06-05 07:17:04"')
-      end
-
-      assert output.include?('t.time "time_with_default", default: "2000-01-01 07:17:04"')
-      assert output.include?('t.decimal "decimal_with_default", precision: 20, scale: 10, default: "1234567890.0123456789"')
-    ensure
-      migration.migrate(:down)
-      $stdout = original
-    end
-
-    if supports_text_column_with_default?
-      def test_schema_dump_with_text_column
-        migration = Class.new(ActiveRecord::Migration::Current) do
-          def up
-            create_table("text_column_with_default") do |t|
-              t.text :text_with_default, default: "John' Doe"
-            end
-          end
-          def down
-            drop_table("text_column_with_default")
-          end
-        end
-        migration.migrate(:up)
-
-        output = perform_schema_dump
-
-        assert output.include?('t.text "text_with_default", default: "John\' Doe"')
-      ensure
-        migration.migrate(:down)
-      end
-    end
   end
 end

test/excludes/SchemaDumperDefaultsTest.rb

@@ -1,3 +1 @@
 exclude :test_schema_dump_with_column_infinity_default, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
-exclude :test_schema_dump_defaults_with_universally_supported_types, "Re-implementing ourselves because we need CockroachDB specific methods."
-exclude :test_schema_dump_with_text_column, "Re-implementing ourselves because we need CockroachDB specific methods."