fix(ci): smaller summary without skips

Author: BuonOmo

.github/workflows/ci.yml

@@ -58,7 +58,7 @@ jobs:
           EOF
 
           jq --slurp --raw-output '
-            map(.failed_tests|map("\(.klass)#\(.NAME)")) | flatten | unique | sort | to_entries[]
+            map(.failed_tests|map("\(.klass)#\(.NAME)")) | flatten | unique | sort[0:100] | to_entries[]
             | "<tr><td><strong>\(.key)</strong></td><td>\(.value)</td></tr>"
           ' reports/*/report.json >>$GITHUB_STEP_SUMMARY
 
@@ -67,6 +67,9 @@ jobs:
           </table>
           EOF
 
+          # Do not print json if too large.
+          [[ "$(du -s reports | cut -f1)" -gt 124 ]] && exit 0
+
           echo >>$GITHUB_STEP_SUMMARY
           echo '```json' >>$GITHUB_STEP_SUMMARY
           jq --slurp --compact-output '.' reports/*/report.json >>$GITHUB_STEP_SUMMARY

.github/workflows/flaky.yml

@@ -72,7 +72,7 @@ jobs:
           name: report-${{ matrix.crdb }}-${{ matrix.ruby }}-${{ matrix.seed }}
           path: report.json
   collect:
-    if: failure()
+    if: failure() || cancelled()
     needs: test
     runs-on: ubuntu-latest
     steps:
@@ -97,7 +97,7 @@ jobs:
           EOF
 
           jq --slurp --raw-output '
-            sort_by(.total_time)[]
+            sort_by(.total_time)[0:100][]
             | {seed, time: .total_time | strftime("%H:%M:%S"), failure: .failed_tests[0].NAME }
             | "<tr><td>\(.seed)</td><td>\(.time)</td><td>\(.failure)</td></tr>"
           ' reports/*/report.json >> $GITHUB_STEP_SUMMARY
@@ -107,6 +107,10 @@ jobs:
           </tbody>
           </table>
           EOF
+
+          # Do not print json if too large.
+          [[ "$(du -s reports | cut -f1)" -gt 124 ]] && exit 0
+
           echo >> $GITHUB_STEP_SUMMARY
           echo '```json' >> $GITHUB_STEP_SUMMARY
           jq --slurp --compact-output '.' reports/*/report.json >> $GITHUB_STEP_SUMMARY

lib/active_record/connection_adapters/cockroachdb/quoting.rb

@@ -34,17 +34,18 @@ module Quoting
         # but when creating objects, using RGeo features is more convenient than
         # converting to WKB, so this does it automatically.
         def quote(value)
-          if value.is_a?(Numeric)
+          case value
+          when Numeric
             # NOTE: The fact that integers are quoted is important and helps
             # mitigate a potential vulnerability.
             #
             # See
             # - https://nvd.nist.gov/vuln/detail/CVE-2022-44566
             # - https://github.com/cockroachdb/activerecord-cockroachdb-adapter/pull/280#discussion_r1288692977
             "'#{quote_string(value.to_s)}'"
-          elsif RGeo::Feature::Geometry.check_type(value)
+          when RGeo::Feature::Geometry
             "'#{RGeo::WKRep::WKBGenerator.new(hex_format: true, type_format: :ewkb, emit_ewkb_srid: true).generate(value)}'"
-          elsif value.is_a?(RGeo::Cartesian::BoundingBox)
+          when RGeo::Cartesian::BoundingBox
             "'#{value.min_x},#{value.min_y},#{value.max_x},#{value.max_y}'::box"
           else
             super

test/cases/helper_cockroachdb.rb

@@ -180,7 +180,7 @@ def report
             seed: Minitest.seed,
             assertions: assertions,
             count: count,
-            failed_tests: results,
+            failed_tests: results.reject(&:skipped?),
             total_time: total_time,
             failures: failures,
             errors: errors,