Skip to content

Commit 8dce233

Browse files
authored
Add validation to check the image on cockroachdb registry (#1110)
1 parent b834c82 commit 8dce233

File tree

14 files changed

+132
-25
lines changed

14 files changed

+132
-25
lines changed

config/manager/patches/image.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,8 @@ spec:
240240
value: cockroachdb/cockroach:v23.2.24
241241
- name: RELATED_IMAGE_COCKROACH_v23_2_25
242242
value: cockroachdb/cockroach:v23.2.25
243+
- name: RELATED_IMAGE_COCKROACH_v23_2_26
244+
value: cockroachdb/cockroach:v23.2.26
243245
- name: RELATED_IMAGE_COCKROACH_v24_1_0
244246
value: cockroachdb/cockroach:v24.1.0
245247
- name: RELATED_IMAGE_COCKROACH_v24_1_1
@@ -274,6 +276,8 @@ spec:
274276
value: cockroachdb/cockroach:v24.1.16
275277
- name: RELATED_IMAGE_COCKROACH_v24_1_18
276278
value: cockroachdb/cockroach:v24.1.18
279+
- name: RELATED_IMAGE_COCKROACH_v24_1_19
280+
value: cockroachdb/cockroach:v24.1.19
277281
- name: RELATED_IMAGE_COCKROACH_v24_2_0
278282
value: cockroachdb/cockroach:v24.2.0
279283
- name: RELATED_IMAGE_COCKROACH_v24_2_2
@@ -316,6 +320,8 @@ spec:
316320
value: cockroachdb/cockroach:v24.3.11
317321
- name: RELATED_IMAGE_COCKROACH_v24_3_12
318322
value: cockroachdb/cockroach:v24.3.12
323+
- name: RELATED_IMAGE_COCKROACH_v24_3_14
324+
value: cockroachdb/cockroach:v24.3.14
319325
- name: RELATED_IMAGE_COCKROACH_v25_1_0
320326
value: cockroachdb/cockroach:v25.1.0
321327
- name: RELATED_IMAGE_COCKROACH_v25_1_1
@@ -330,3 +336,7 @@ spec:
330336
value: cockroachdb/cockroach:v25.1.5
331337
- name: RELATED_IMAGE_COCKROACH_v25_1_6
332338
value: cockroachdb/cockroach:v25.1.6
339+
- name: RELATED_IMAGE_COCKROACH_v25_1_7
340+
value: cockroachdb/cockroach:v25.1.7
341+
- name: RELATED_IMAGE_COCKROACH_v25_2_0
342+
value: cockroachdb/cockroach:v25.2.0

config/manifests/bases/cockroach-operator.clusterserviceversion.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,8 @@ spec:
413413
name: RELATED_IMAGE_COCKROACH_v23_2_24
414414
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:0754f7901feea9017bc5041cb91b7ac1cdbca10c2064f37c3648a2c395f24f83
415415
name: RELATED_IMAGE_COCKROACH_v23_2_25
416+
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:02e1ef01a023da0eee653f63b314786fd66a78d184a97a314422f6f9c3ef8e7e
417+
name: RELATED_IMAGE_COCKROACH_v23_2_26
416418
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:5240f9f591263569fad7ee934e81fa8a1617de3c25da94ddd59ee5b2b3407f90
417419
name: RELATED_IMAGE_COCKROACH_v24_1_0
418420
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:1374cbdc4ecf38e4b4226328f532e830b8932b34d9449bf2fbb36e60d0310521
@@ -447,6 +449,8 @@ spec:
447449
name: RELATED_IMAGE_COCKROACH_v24_1_16
448450
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8f1f2fd1aca914a1ef007117c85ac944055bbfb873a468a7374d239ef20b065e
449451
name: RELATED_IMAGE_COCKROACH_v24_1_18
452+
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:68fe64fe3e112288ccfc2a7dffd69b9b2786a5da3d3bdedd6addf41659d460c9
453+
name: RELATED_IMAGE_COCKROACH_v24_1_19
450454
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:cad60044ad6573bd80b65e892a9ec0510dbe4fcbbfc6b51010ecf419f56f1024
451455
name: RELATED_IMAGE_COCKROACH_v24_2_0
452456
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:08cec123813304ab03bd66d72a09949667a874a42320bedafda391ebcdb2e56c
@@ -489,6 +493,8 @@ spec:
489493
name: RELATED_IMAGE_COCKROACH_v24_3_11
490494
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:9f42e929f2cc7e9b6d24dd61e19c5d93dcfeabd34b9c8b935afbe78577efb18b
491495
name: RELATED_IMAGE_COCKROACH_v24_3_12
496+
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:a59cafff8d4ff2c62204ece15880117011c30978823c232902c7182d747ec827
497+
name: RELATED_IMAGE_COCKROACH_v24_3_14
492498
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8e8c081c231b5b15eca483ceec16ea9190ba73aae6e421865162446eb584519a
493499
name: RELATED_IMAGE_COCKROACH_v25_1_0
494500
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:fd6c9b8ca82ff4f2d0fe29166d1fc9bca6439cb40907be60f4d8f1b9735de2f7
@@ -503,6 +509,10 @@ spec:
503509
name: RELATED_IMAGE_COCKROACH_v25_1_5
504510
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:e8f26fd132affbaeb8ef6b1807a646c83b301e5dc334a592dfb2cf8dc3dbaf10
505511
name: RELATED_IMAGE_COCKROACH_v25_1_6
512+
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:cc20270212f01fc231ff788e20b0476b8228c440bfc40430c0836d5eb702a042
513+
name: RELATED_IMAGE_COCKROACH_v25_1_7
514+
- image: registry.connect.redhat.com/cockroachdb/cockroach@sha256:c74cf927a2b2c5098ad74ad0880996f8b042186a9911d888a231ef5b9e2a0715
515+
name: RELATED_IMAGE_COCKROACH_v25_2_0
506516
- image: RH_COCKROACH_OP_IMAGE_PLACEHOLDER
507517
name: RELATED_IMAGE_COCKROACH_OPERATOR
508518
version: 0.0.0

config/manifests/patches/deployment_patch.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,8 @@ spec:
249249
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:c9a31bdf19175880d0981e21dd19a1458b6e8cde8d4acbcb554f3bea3578a64e
250250
- name: RELATED_IMAGE_COCKROACH_v23_2_25
251251
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:0754f7901feea9017bc5041cb91b7ac1cdbca10c2064f37c3648a2c395f24f83
252+
- name: RELATED_IMAGE_COCKROACH_v23_2_26
253+
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:02e1ef01a023da0eee653f63b314786fd66a78d184a97a314422f6f9c3ef8e7e
252254
- name: RELATED_IMAGE_COCKROACH_v24_1_0
253255
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:5240f9f591263569fad7ee934e81fa8a1617de3c25da94ddd59ee5b2b3407f90
254256
- name: RELATED_IMAGE_COCKROACH_v24_1_1
@@ -283,6 +285,8 @@ spec:
283285
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8fc8de4f3671a73f9aa747e5b23ec973d192fff6f2869c38985cd656063c1e3d
284286
- name: RELATED_IMAGE_COCKROACH_v24_1_18
285287
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8f1f2fd1aca914a1ef007117c85ac944055bbfb873a468a7374d239ef20b065e
288+
- name: RELATED_IMAGE_COCKROACH_v24_1_19
289+
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:68fe64fe3e112288ccfc2a7dffd69b9b2786a5da3d3bdedd6addf41659d460c9
286290
- name: RELATED_IMAGE_COCKROACH_v24_2_0
287291
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:cad60044ad6573bd80b65e892a9ec0510dbe4fcbbfc6b51010ecf419f56f1024
288292
- name: RELATED_IMAGE_COCKROACH_v24_2_2
@@ -325,6 +329,8 @@ spec:
325329
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:742a6f69a3a209a7080a1e911fd96467d2a91aacb3f91d6be80a6a6e2e54b2ae
326330
- name: RELATED_IMAGE_COCKROACH_v24_3_12
327331
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:9f42e929f2cc7e9b6d24dd61e19c5d93dcfeabd34b9c8b935afbe78577efb18b
332+
- name: RELATED_IMAGE_COCKROACH_v24_3_14
333+
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:a59cafff8d4ff2c62204ece15880117011c30978823c232902c7182d747ec827
328334
- name: RELATED_IMAGE_COCKROACH_v25_1_0
329335
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8e8c081c231b5b15eca483ceec16ea9190ba73aae6e421865162446eb584519a
330336
- name: RELATED_IMAGE_COCKROACH_v25_1_1
@@ -339,6 +345,10 @@ spec:
339345
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:79d688bebe0643ef0dd6ba7108cdb34c0442470c0c20ae0df88b5d02a3476cd0
340346
- name: RELATED_IMAGE_COCKROACH_v25_1_6
341347
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:e8f26fd132affbaeb8ef6b1807a646c83b301e5dc334a592dfb2cf8dc3dbaf10
348+
- name: RELATED_IMAGE_COCKROACH_v25_1_7
349+
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:cc20270212f01fc231ff788e20b0476b8228c440bfc40430c0836d5eb702a042
350+
- name: RELATED_IMAGE_COCKROACH_v25_2_0
351+
value: registry.connect.redhat.com/cockroachdb/cockroach@sha256:c74cf927a2b2c5098ad74ad0880996f8b042186a9911d888a231ef5b9e2a0715
342352
- name: RELATED_IMAGE_COCKROACH_OPERATOR
343353
value: RH_COCKROACH_OP_IMAGE_PLACEHOLDER
344354
image: RH_COCKROACH_OP_IMAGE_PLACEHOLDER

config/samples/crdb-tls-example.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ kind: CrdbCluster
1919
metadata:
2020
name: crdb-tls-example
2121
spec:
22-
cockroachDBVersion: v25.1.6
22+
cockroachDBVersion: v25.2.0
2323
dataStore:
2424
pvc:
2525
spec:

crdb-versions.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,9 @@ CrdbVersions:
343343
- image: cockroachdb/cockroach:v23.2.25
344344
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:0754f7901feea9017bc5041cb91b7ac1cdbca10c2064f37c3648a2c395f24f83
345345
tag: v23.2.25
346+
- image: cockroachdb/cockroach:v23.2.26
347+
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:02e1ef01a023da0eee653f63b314786fd66a78d184a97a314422f6f9c3ef8e7e
348+
tag: v23.2.26
346349
- image: cockroachdb/cockroach:v24.1.0
347350
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:5240f9f591263569fad7ee934e81fa8a1617de3c25da94ddd59ee5b2b3407f90
348351
tag: v24.1.0
@@ -394,6 +397,9 @@ CrdbVersions:
394397
- image: cockroachdb/cockroach:v24.1.18
395398
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8f1f2fd1aca914a1ef007117c85ac944055bbfb873a468a7374d239ef20b065e
396399
tag: v24.1.18
400+
- image: cockroachdb/cockroach:v24.1.19
401+
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:68fe64fe3e112288ccfc2a7dffd69b9b2786a5da3d3bdedd6addf41659d460c9
402+
tag: v24.1.19
397403
- image: cockroachdb/cockroach:v24.2.0
398404
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:cad60044ad6573bd80b65e892a9ec0510dbe4fcbbfc6b51010ecf419f56f1024
399405
tag: v24.2.0
@@ -457,6 +463,9 @@ CrdbVersions:
457463
- image: cockroachdb/cockroach:v24.3.12
458464
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:9f42e929f2cc7e9b6d24dd61e19c5d93dcfeabd34b9c8b935afbe78577efb18b
459465
tag: v24.3.12
466+
- image: cockroachdb/cockroach:v24.3.14
467+
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:a59cafff8d4ff2c62204ece15880117011c30978823c232902c7182d747ec827
468+
tag: v24.3.14
460469
- image: cockroachdb/cockroach:v25.1.0
461470
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:8e8c081c231b5b15eca483ceec16ea9190ba73aae6e421865162446eb584519a
462471
tag: v25.1.0
@@ -478,3 +487,9 @@ CrdbVersions:
478487
- image: cockroachdb/cockroach:v25.1.6
479488
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:e8f26fd132affbaeb8ef6b1807a646c83b301e5dc334a592dfb2cf8dc3dbaf10
480489
tag: v25.1.6
490+
- image: cockroachdb/cockroach:v25.1.7
491+
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:cc20270212f01fc231ff788e20b0476b8228c440bfc40430c0836d5eb702a042
492+
tag: v25.1.7
493+
- image: cockroachdb/cockroach:v25.2.0
494+
redhatImage: registry.connect.redhat.com/cockroachdb/cockroach@sha256:c74cf927a2b2c5098ad74ad0880996f8b042186a9911d888a231ef5b9e2a0715
495+
tag: v25.2.0

e2e/create/create_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ import (
3131
)
3232

3333
var (
34-
crdbVersion = "v21.1.7"
35-
relatedImageEnvName = "RELATED_IMAGE_COCKROACH_v21_1_7"
36-
validImage = "cockroachdb/cockroach:v21.1.7"
34+
crdbVersion = "v21.2.7"
35+
relatedImageEnvName = "RELATED_IMAGE_COCKROACH_v21_2_7"
36+
validImage = "cockroachdb/cockroach:v21.2.7"
3737
)
3838

3939
// TestCreateInsecureCluster tests the creation of insecure cluster, and it should be successful.

e2e/e2e.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const (
3232
MinorVersion2 = "cockroachdb/cockroach:v24.1.2"
3333
MajorVersion = "cockroachdb/cockroach:v24.2.2"
3434
NonExistentVersion = "cockroachdb/cockroach-non-existent:v21.1.999"
35-
SkipFeatureVersion = "cockroachdb/cockroach:v20.1.0"
35+
SkipFeatureVersion = "cockroachdb/cockroach:v21.2.0"
3636
InvalidImage = "nginx:latest"
3737
DefaultCPULimit = "800m"
3838
DefaultMemoryLimit = "3Gi"

e2e/upgrades/upgrades_test.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func TestUpgradesMinorVersion(t *testing.T) {
5050

5151
// We are testing a Minor Version Upgrade with
5252
// partition update
53-
// Going from v20.2.8 to v20.2.9
53+
// Going from v24.1.0 to v24.1.2
5454

5555
if testing.Short() {
5656
t.Skip("skipping test in short mode.")
@@ -97,11 +97,11 @@ func TestUpgradesMinorVersion(t *testing.T) {
9797
steps.Run(t)
9898
}
9999

100-
// TestUpgradesMajorVersion20to21 tests a major version upgrade
101-
func TestUpgradesMajorVersion20to21(t *testing.T) {
100+
// TestUpgradesMajorVersion24.1to24.2 tests a major version upgrade
101+
func TestUpgradesMajorVersion24_1to24_2(t *testing.T) {
102102

103103
// We are doing a major version upgrade here
104-
// 20 to 21
104+
// 24.1.2 to 24.2.2
105105

106106
if testing.Short() {
107107
t.Skip("skipping test in short mode.")
@@ -149,8 +149,8 @@ func TestUpgradesMajorVersion20to21(t *testing.T) {
149149
steps.Run(t)
150150
}
151151

152-
// TestUpgradesMajorVersion20_1To20_2 is another major version upgrade
153-
func TestUpgradesMajorVersion20_1To20_2(t *testing.T) {
152+
// TestUpgradesMajorVersion21_2To22_1 is another major version upgrade
153+
func TestUpgradesMajorVersion21_2To22_1(t *testing.T) {
154154

155155
if testing.Short() {
156156
t.Skip("skipping test in short mode.")
@@ -166,7 +166,7 @@ func TestUpgradesMajorVersion20_1To20_2(t *testing.T) {
166166
sb.StartManager(t, controller.InitClusterReconcilerWithLogger(testLog))
167167

168168
builder := testutil.NewBuilder("crdb").WithNodeCount(3).WithTLS().
169-
WithImage("cockroachdb/cockroach:v20.1.16").
169+
WithImage("cockroachdb/cockroach:v21.2.16").
170170
WithPVDataStore("1Gi").WithResources(resRequirements)
171171

172172
steps := testutil.Steps{
@@ -184,7 +184,7 @@ func TestUpgradesMajorVersion20_1To20_2(t *testing.T) {
184184
require.NoError(t, sb.Get(current))
185185

186186
updated := current.DeepCopy()
187-
updated.Spec.Image.Name = "cockroachdb/cockroach:v20.2.10"
187+
updated.Spec.Image.Name = "cockroachdb/cockroach:v22.1.10"
188188
require.NoError(t, sb.Patch(updated, client.MergeFrom(current)))
189189
// we wait 10 min because we will be waiting 3 min for each pod because
190190
// v20.1.16 does not have curl installed
@@ -251,7 +251,8 @@ func TestUpgradesMinorVersionThenRollback(t *testing.T) {
251251

252252
// We are testing a Minor Version Upgrade with
253253
// partition update
254-
// Going from v20.2.8 to v20.2.9
254+
// Going from v24.1.0 to v24.1.2
255+
// Then rollback to v24.1.0
255256

256257
if testing.Short() {
257258
t.Skip("skipping test in short mode.")

examples/client-secure-operator.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ spec:
2323
serviceAccountName: cockroachdb-sa
2424
containers:
2525
- name: cockroachdb-client-secure
26-
image: cockroachdb/cockroach:v25.1.6
26+
image: cockroachdb/cockroach:v25.2.0
2727
imagePullPolicy: IfNotPresent
2828
volumeMounts:
2929
- name: client-certs

examples/example.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ spec:
4040
memory: 8Gi
4141
tlsEnabled: true
4242
# You can set either a version of the db or a specific image name
43-
# cockroachDBVersion: v25.1.6
43+
# cockroachDBVersion: v25.2.0
4444
image:
45-
name: cockroachdb/cockroach:v25.1.6
45+
name: cockroachdb/cockroach:v25.2.0
4646
# nodes refers to the number of crdb pods that are created
4747
# via the statefulset
4848
nodes: 3

0 commit comments

Comments
 (0)