update: modify TerminationGracePeriodSecs data type to int64 to remove implicit conversion

Author: NishanthNalluri

apis/v1alpha1/cluster_types.go

@@ -149,7 +149,7 @@ type CrdbClusterSpec struct {
 	// when marked for deletion or restarted
 	// Default : 300
 	// +optional
-	TerminationGracePeriodSecs int32 `json:"terminationGracePeriodSecs,omitempty"`
+	TerminationGracePeriodSecs int64 `json:"terminationGracePeriodSecs,omitempty"`
 }
 
 // +k8s:openapi-gen=true

config/crd/bases/crdb.cockroachlabs.com_crdbclusters.yaml

@@ -1397,7 +1397,7 @@ spec:
                 description: '(Optional) Amount of grace time prior to the container
                   being forcibly terminated when marked for deletion or restarted
                   Default : 300'
-                format: int32
+                format: int64
                 type: integer
               tlsEnabled:
                 description: (Optional) TLSEnabled determines if TLS is enabled for

install/crds.yaml

@@ -1395,7 +1395,7 @@ spec:
                 description: '(Optional) Amount of grace time prior to the container
                   being forcibly terminated when marked for deletion or restarted
                   Default : 300'
-                format: int32
+                format: int64
                 type: integer
               tlsEnabled:
                 description: (Optional) TLSEnabled determines if TLS is enabled for

pkg/resource/cluster.go

@@ -330,7 +330,7 @@ func (cluster Cluster) SecureMode() string {
 	return "--insecure"
 }
 
-func (cluster Cluster) GetTerminationGracePeriod() int32 {
+func (cluster Cluster) GetTerminationGracePeriod() int64 {
 	if cluster.Spec().TerminationGracePeriodSecs == 0 {
 		return terminationGracePeriodSecs
 	}

pkg/resource/statefulset.go

@@ -209,7 +209,7 @@ func (b StatefulSetBuilder) makePodTemplate() corev1.PodTemplateSpec {
 				RunAsUser: ptr.Int64(1000581000),
 				FSGroup:   ptr.Int64(1000581000),
 			},
-			TerminationGracePeriodSeconds: ptr.Int64(int64(b.GetTerminationGracePeriod())),
+			TerminationGracePeriodSeconds: ptr.Int64(b.GetTerminationGracePeriod()),
 			Containers:                    b.MakeContainers(),
 			AutomountServiceAccountToken:  ptr.Bool(b.Spec().AutomountServiceAccountToken),
 			ServiceAccountName:            b.ServiceAccountName(),

pkg/testutil/builder.go

@@ -56,7 +56,7 @@ func (b ClusterBuilder) WithAutomountServiceAccountToken(mount bool) ClusterBuil
 	return b
 }
 
-func (b ClusterBuilder) WithTerminationGracePeriodSeconds(s int32) ClusterBuilder {
+func (b ClusterBuilder) WithTerminationGracePeriodSeconds(s int64) ClusterBuilder {
 	b.cluster.Spec.TerminationGracePeriodSecs = s
 	return b
 }