Merge #149596 #149839 #149986 #150448 #150491 #150492 #150510

149596: Reapply "sql,log: add new txn_read_timestamp field to CommonSqlEventDetails" r=kyle-a-wong a=kyle-a-wong

This reverts commit e8c121ebeb622c0c414b23a4dd79e67b2a726b00.

This commit was reverted because it introduced flaky tests due to non-deterministic queries in the event log logic tests. These flaky queries were updated to order results deterministically.

Epic: None
Release note: None

149839: ui: refactor schema insights to remove redux and sagas r=kyle-a-wong a=kyle-a-wong

Refactors the schema insights component to no longer
require redux and sagags. It now uses `useSwr` for data
fetching. In order to remove the dependency on redux
and sagas, some functionality was removed from this
component. This functionality is:
  1. dispatching analytics.track actions
  2. persisting table sorting and filtering to browser
     session storage.

The analytics.track actions were used in cloud console
to track when the table is sorted or a filter is applied.
We decided this doesn't provide very much value to
replace and removed it.

Epic: None
Release note: None


---
Note: This is a stacked PR, only the last commit needs to be reviewed. 

149986: clusterversion: remove obs TODO_Delete_V25_2 versions r=kyle-a-wong a=kyle-a-wong

Resolves: #147776
Release note: None

150448: roachtest: bump upgrade timeout in jobs/mixed-version r=jeffswenson a=msbutler

We've seen a few runs of this roachtest time out even though the migration is happily chugging along. This patch bumps the timeout from 30 minutes to an hour.

Informs #146508
Informs #150104

Release note: none

150491: roachtest: elide 'estimated_last_login_time' in system.users fingerprint r=jeffswenson a=msbutler

The backup/restore roachtests have recently begun to flake (due to #150375) with a fingerprint error on the system.users table. The roachtest simply needs to be taught to elide the values of the estimated_last_login_time column, which can be updated before the test driver fingerprints the column.

Fixes #150400
Fixes #149316
Fixes #150471
Fixes #150472
Fixes #150399

Release note: none

150492: go.mod: bump Pebble to 273e26653683 r=RaduBerinde a=jbowens

Changes:

 * [`273e2665`](cockroachdb/pebble@273e2665) sstable: prevent block metadata pointers to garbage
 * [`136248c7`](cockroachdb/pebble@136248c7) manual: expand useGoAllocation's comment
 * [`2fa01831`](cockroachdb/pebble@2fa01831) db: check FormatExciseBoundsRecord against the current format version
 * [`7a51062c`](cockroachdb/pebble@7a51062c) manual: sometimes mangle freed buffers in invariants builds
 * [`6b27daec`](cockroachdb/pebble@6b27daec) db: add leaktest to compaction unit tests
 * [`83f68e05`](cockroachdb/pebble@83f68e05) pebble: close the manifest file on Open failure
 * [`9685dbe8`](cockroachdb/pebble@9685dbe8) sstable: mangle some more buffers in invariants builds
 * [`ab5eeb98`](cockroachdb/pebble@ab5eeb98) metamorphic: propagate FS changes to TestOptions
 * [`f2a76e85`](cockroachdb/pebble@f2a76e85) db: deflake TestCompactionCorruption
 * [`bf6aaa56`](cockroachdb/pebble@bf6aaa56) github: stress new unit tests in PRs
 * [`ffd01fd1`](cockroachdb/pebble@ffd01fd1) manifest: explicitly encode excise operations in the MANIFEST
 * [`e1bc7c50`](cockroachdb/pebble@e1bc7c50) pebble: fix TestOpenAlreadyLocked

Close #149955.
Close #150216.
Release note: none.
Epic: none.

150510: workload/schemachange: don't use CITEXT in mixed version cluster r=rafiss a=rafiss

fixes #148980
fixes #150133

Release note: None

Co-authored-by: Kyle Wong <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Jackson Owens <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>

Author: 5 people

DEPS.bzl

@@ -1835,10 +1835,10 @@ def go_deps():
         patches = [
             "@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch",
         ],
-        sha256 = "b854ba6802c929910b6c5c2572bf9b8b408e1d4cb80db9c62af8fc19fc74dd14",
-        strip_prefix = "github.com/cockroachdb/[email protected]20250711175034-837c19b81bab",
+        sha256 = "dc82ab51494c5580be75fd82dfefd78b17ce7868d21ff9c44f4feecc71a56de9",
+        strip_prefix = "github.com/cockroachdb/[email protected]20250717215536-273e26653683",
         urls = [
-            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250711175034-837c19b81bab.zip",
+            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250717215536-273e26653683.zip",
         ],
     )
     go_repository(

build/bazelutil/distdir_files.bzl

@@ -358,7 +358,7 @@ DISTDIR_FILES = {
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/gostdlib/com_github_cockroachdb_gostdlib-v1.19.0.zip": "c4d516bcfe8c07b6fc09b8a9a07a95065b36c2855627cb3514e40c98f872b69e",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/logtags/com_github_cockroachdb_logtags-v0.0.0-20241215232642-bb51bb14a506.zip": "920068af09e3846d9ebb4e4a7787ff1dd10f3989c5f940ad861b0f6a9f824f6e",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/metamorphic/com_github_cockroachdb_metamorphic-v0.0.0-20231108215700-4ba948b56895.zip": "28c8cf42192951b69378cf537be5a9a43f2aeb35542908cc4fe5f689505853ea",
-    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250711175034-837c19b81bab.zip": "b854ba6802c929910b6c5c2572bf9b8b408e1d4cb80db9c62af8fc19fc74dd14",
+    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250717215536-273e26653683.zip": "dc82ab51494c5580be75fd82dfefd78b17ce7868d21ff9c44f4feecc71a56de9",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/redact/com_github_cockroachdb_redact-v1.1.6.zip": "018eccb5fb9ca52d43ec9eaf213539d01c1f2b94e0e822406ebfb2e9321ef6cf",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/returncheck/com_github_cockroachdb_returncheck-v0.0.0-20200612231554-92cdbca611dd.zip": "ce92ba4352deec995b1f2eecf16eba7f5d51f5aa245a1c362dfe24c83d31f82b",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/stress/com_github_cockroachdb_stress-v0.0.0-20220803192808-1806698b1b7b.zip": "3fda531795c600daf25532a4f98be2a1335cd1e5e182c72789bca79f5f69fcc1",

docs/generated/eventlog.md

@@ -140,7 +140,7 @@ require (
 	github.com/cockroachdb/go-test-teamcity v0.0.0-20191211140407-cff980ad0a55
 	github.com/cockroachdb/gostdlib v1.19.0
 	github.com/cockroachdb/logtags v0.0.0-20241215232642-bb51bb14a506
-	github.com/cockroachdb/pebble v0.0.0-20250711175034-837c19b81bab
+	github.com/cockroachdb/pebble v0.0.0-20250717215536-273e26653683
 	github.com/cockroachdb/redact v1.1.6
 	github.com/cockroachdb/returncheck v0.0.0-20200612231554-92cdbca611dd
 	github.com/cockroachdb/stress v0.0.0-20220803192808-1806698b1b7b

go.mod

@@ -582,8 +582,8 @@ github.com/cockroachdb/logtags v0.0.0-20241215232642-bb51bb14a506 h1:ASDL+UJcILM
 github.com/cockroachdb/logtags v0.0.0-20241215232642-bb51bb14a506/go.mod h1:Mw7HqKr2kdtu6aYGn3tPmAftiP3QPX63LdK/zcariIo=
 github.com/cockroachdb/metamorphic v0.0.0-20231108215700-4ba948b56895 h1:XANOgPYtvELQ/h4IrmPAohXqe2pWA8Bwhejr3VQoZsA=
 github.com/cockroachdb/metamorphic v0.0.0-20231108215700-4ba948b56895/go.mod h1:aPd7gM9ov9M8v32Yy5NJrDyOcD8z642dqs+F0CeNXfA=
-github.com/cockroachdb/pebble v0.0.0-20250711175034-837c19b81bab h1:TL4dKn78L2rqTb2bOMnLJjYoyx7NQUOyi/BD0UDYAjo=
-github.com/cockroachdb/pebble v0.0.0-20250711175034-837c19b81bab/go.mod h1:LLa+I2vZrOsrsy4QcuZ6wSXBNQll7erNg3GCr8NpE90=
+github.com/cockroachdb/pebble v0.0.0-20250717215536-273e26653683 h1:MZ0Sqn8yxrgOtLw2rAGSlgzNMDkFzc86nOa7mUjALyc=
+github.com/cockroachdb/pebble v0.0.0-20250717215536-273e26653683/go.mod h1:LLa+I2vZrOsrsy4QcuZ6wSXBNQll7erNg3GCr8NpE90=
 github.com/cockroachdb/redact v1.1.3/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=
 github.com/cockroachdb/redact v1.1.6 h1:zXJBwDZ84xJNlHl1rMyCojqyIxv+7YUpQiJLQ7n4314=
 github.com/cockroachdb/redact v1.1.6/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=

go.sum

@@ -1097,7 +1097,7 @@ ALTER DATABASE drop_region_db DROP REGION IF EXISTS "us-east-1"
 
 # Ensure that events are generated for dropping the region
 query IT
-SELECT "reportingID", info::JSONB - 'Timestamp' - 'DescriptorID'
+SELECT "reportingID", info::JSONB - 'Timestamp' - 'DescriptorID' - 'TxnReadTimestamp'
 FROM system.eventlog
 WHERE "eventType" = 'alter_database_drop_region'
 ----

pkg/ccl/logictestccl/testdata/logic_test/multi_region

@@ -205,10 +205,6 @@ const (
 
 	TODO_Delete_V25_2_Start
 
-	TODO_Delete_V25_2_AddSqlActivityFlushJob
-
-	TODO_Delete_V25_2_SetUiDefaultTimezoneSetting
-
 	// V25_2 is CockroachDB v25.2. It's used for all v25.2.x patch releases.
 	V25_2
 
@@ -277,9 +273,7 @@ var versionTable = [numKeys]roachpb.Version{
 	V25_1: {Major: 25, Minor: 1, Internal: 0},
 
 	// v25.2 versions. Internal versions must be even.
-	TODO_Delete_V25_2_Start:                       {Major: 25, Minor: 1, Internal: 2},
-	TODO_Delete_V25_2_AddSqlActivityFlushJob:      {Major: 25, Minor: 1, Internal: 4},
-	TODO_Delete_V25_2_SetUiDefaultTimezoneSetting: {Major: 25, Minor: 1, Internal: 6},
+	TODO_Delete_V25_2_Start: {Major: 25, Minor: 1, Internal: 2},
 
 	V25_2: {Major: 25, Minor: 2, Internal: 0},
 

pkg/clusterversion/cockroach_versions.go

@@ -842,6 +842,17 @@ func (sc *systemTableContents) scheduledJobsHandler(
 		Values()
 }
 
+// usersHandler replaces the contents of "estimated_last_login_time" which gets
+// updated on every user login attempt, which means the post restore fingerprint
+// could observe an updated log in time value.
+func (sc *systemTableContents) usersHandler(
+	values []interface{}, columns []string,
+) ([]interface{}, error) {
+	return newSystemTableRow(sc.table, values, columns).
+		WithSentinel("estimated_last_login_time").
+		Values()
+}
+
 func (sc *systemTableContents) commentsHandler(
 	values []interface{}, columns []string,
 ) ([]interface{}, error) {
@@ -879,6 +890,8 @@ func (sc *systemTableContents) handleSpecialCases(
 		return sc.commentsHandler(row, columns)
 	case "system.tenant_settings":
 		return sc.tenantSettingsHandler(row, columns)
+	case "system.users":
+		return sc.usersHandler(row, columns)
 	default:
 		return row, nil
 	}

pkg/cmd/roachtest/tests/mixed_version_backup.go

@@ -42,7 +42,7 @@ func runJobsMixedVersions(ctx context.Context, t test.Test, c cluster.Cluster) {
 	mvt := mixedversion.NewTest(
 		ctx, t, t.L(), c, c.All(),
 		mixedversion.NumUpgrades(2),
-		mixedversion.UpgradeTimeout(time.Minute*30),
+		mixedversion.UpgradeTimeout(time.Hour),
 		mixedversion.MinimumSupportedVersion("v24.3.0"),
 		mixedversion.AlwaysUseLatestPredecessors,
 		mixedversion.NeverUseFixtures,

pkg/cmd/roachtest/tests/mixed_version_jobs.go

@@ -247,12 +247,8 @@ func logEventInternalForSQLStatements(
 ) error {
 	// Inject the common fields into the payload provided by the caller.
 	injectCommonFields := func(event logpb.EventPayload) error {
-		if txn == nil {
-			// No txn is set (e.g. for COPY or BEGIN), so use now instead.
-			event.CommonDetails().Timestamp = timeutil.Now().UnixNano()
-		} else {
-			event.CommonDetails().Timestamp = txn.KV().ReadTimestamp().WallTime
-		}
+		event.CommonDetails().Timestamp = timeutil.Now().UnixNano()
+
 		sqlCommon, ok := event.(eventpb.EventWithCommonSQLPayload)
 		if !ok {
 			return errors.AssertionFailedf("unknown event type: %T", event)
@@ -278,6 +274,10 @@ func logEventInternalForSQLStatements(
 		// Overwrite with the common details.
 		*m = commonSQLEventDetails
 
+		if txn != nil {
+			m.TxnReadTimestamp = txn.KV().ReadTimestamp().WallTime
+		}
+
 		// If the common details didn't have a descriptor ID, keep the
 		// one that was in the event already.
 		if m.DescriptorID == 0 {