intentresolver: change logging channel

Author: tbg

pkg/kv/kvserver/intentresolver/intent_resolver.go

@@ -339,7 +339,7 @@ func updateIntentTxnStatus(
 		if !ok {
 			// The intent was not pushed.
 			if !skipIfInFlight {
-				log.Dev.Fatalf(ctx, "no PushTxn response for intent %+v", intent)
+				log.KvExec.Fatalf(ctx, "no PushTxn response for intent %+v", intent)
 			}
 			// It must have been skipped.
 			continue
@@ -369,7 +369,7 @@ func (ir *IntentResolver) PushTransaction(
 	}
 	pushedTxn, ok := pushedTxns[pushTxn.ID]
 	if !ok {
-		log.Dev.Fatalf(ctx, "missing PushTxn responses for %s", pushTxn)
+		log.KvExec.Fatalf(ctx, "missing PushTxn responses for %s", pushTxn)
 	}
 	return pushedTxn, ambiguousAbort, nil
 }
@@ -421,7 +421,7 @@ func (ir *IntentResolver) MaybePushTransactions(
 			// Another goroutine is working on this transaction so we can
 			// skip it.
 			if log.V(1) {
-				log.Dev.Infof(ctx, "skipping PushTxn for %s; attempt already in flight", txnID)
+				log.KvExec.Infof(ctx, "skipping PushTxn for %s; attempt already in flight", txnID)
 			}
 			delete(pushTxns, txnID)
 		} else {
@@ -476,7 +476,7 @@ func (ir *IntentResolver) MaybePushTransactions(
 		txn := &resp.PusheeTxn
 		anyAmbiguousAbort = anyAmbiguousAbort || resp.AmbiguousAbort
 		if _, ok := pushedTxns[txn.ID]; ok {
-			log.Dev.Fatalf(ctx, "have two PushTxn responses for %s", txn.ID)
+			log.KvExec.Fatalf(ctx, "have two PushTxn responses for %s", txn.ID)
 		}
 		pushedTxns[txn.ID] = txn
 		log.Eventf(ctx, "%s is now %s", txn.ID, txn.Status)
@@ -546,7 +546,7 @@ func (ir *IntentResolver) CleanupIntentsAsync(
 				return err
 			})
 		if err != nil && ir.every.ShouldLog() {
-			log.Dev.Warningf(ctx, "%v", err)
+			log.KvExec.Warningf(ctx, "%v", err)
 		}
 	})
 }
@@ -664,7 +664,7 @@ func (ir *IntentResolver) CleanupTxnIntentsAsync(
 				ctx, kv.AdmissionHeaderForLockUpdateForTxn(et.Txn), rangeID, et.Txn, et.Poison, onComplete,
 			); err != nil {
 				if ir.every.ShouldLog() {
-					log.Dev.Warningf(ctx, "failed to cleanup transaction intents: %v", err)
+					log.KvExec.Warningf(ctx, "failed to cleanup transaction intents: %v", err)
 				}
 			}
 		}); err != nil {
@@ -784,7 +784,7 @@ func (ir *IntentResolver) CleanupTxnIntentsOnGCAsync(
 			ctx, admissionHeader, rangeID, txn, false /* poison */, onCleanupComplete)
 		if err != nil {
 			if ir.every.ShouldLog() {
-				log.Dev.Warningf(ctx, "failed to cleanup transaction intents: %+v", err)
+				log.KvExec.Warningf(ctx, "failed to cleanup transaction intents: %+v", err)
 			}
 		}
 	}(ctx)
@@ -887,7 +887,7 @@ func (ir *IntentResolver) cleanupFinishedTxnIntents(
 		}
 		if err != nil {
 			if ir.every.ShouldLog() {
-				log.Dev.Warningf(ctx, "failed to gc transaction record: %v", err)
+				log.KvExec.Warningf(ctx, "failed to gc transaction record: %v", err)
 			}
 		}
 	}(ctx)
@@ -937,14 +937,14 @@ func (ir *IntentResolver) lookupRangeID(ctx context.Context, key roachpb.Key) ro
 	rKey, err := keys.Addr(key)
 	if err != nil {
 		if ir.every.ShouldLog() {
-			log.Dev.Warningf(ctx, "failed to resolve addr for key %q: %+v", key, err)
+			log.KvExec.Warningf(ctx, "failed to resolve addr for key %q: %+v", key, err)
 		}
 		return 0
 	}
 	rangeID, err := ir.rdc.LookupRangeID(ctx, rKey)
 	if err != nil {
 		if ir.every.ShouldLog() {
-			log.Dev.Warningf(ctx, "failed to look up range descriptor for key %q: %+v", key, err)
+			log.KvExec.Warningf(ctx, "failed to look up range descriptor for key %q: %+v", key, err)
 		}
 		return 0
 	}
@@ -1068,7 +1068,7 @@ func (ir *IntentResolver) resolveIntents(
 	// TODO(aaditya): reconsider this once #112680 is resolved.
 	// if !build.IsRelease() && h == (kvpb.AdmissionHeader{}) && ir.everyAdmissionHeaderMissing.ShouldLog() {
 	if false {
-		log.Dev.Warningf(ctx,
+		log.KvExec.Warningf(ctx,
 			"test-only warning: if you see this, please report to https://github.com/cockroachdb/cockroach/issues/112680. empty admission header provided by %s", debugutil.Stack())
 	}
 	// Send the requests ...