storage: use fastest profile for default compression

This change fixes the issue of having different cluster setting
defaults on different platforms, which is problematic for
auto-generated documentation.

Epic: none
Release note: None

Author: RaduBerinde

docs/generated/settings/settings-for-tenants.txt

@@ -401,9 +401,9 @@ storage.delete_compaction_excise.enabled	boolean	true	set to false to direct Peb
 storage.ingestion.value_blocks.enabled	boolean	true	set to true to enable writing of value blocks in ingestion sstables	application
 storage.max_sync_duration	duration	20s	maximum duration for disk operations; any operations that take longer than this setting trigger a warning log entry or process crash	system-visible
 storage.max_sync_duration.fatal.enabled	boolean	true	if true, fatal the process when a disk operation exceeds storage.max_sync_duration	application
-storage.sstable.compression_algorithm	enumeration	minlz	determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store; [snappy = 1, zstd = 2, none = 3, minlz = 4]	system-visible
-storage.sstable.compression_algorithm_backup_storage	enumeration	minlz	determines the compression algorithm to use when compressing sstable data blocks for backup row data storage; [snappy = 1, zstd = 2, none = 3, minlz = 4]	system-visible
-storage.sstable.compression_algorithm_backup_transport	enumeration	minlz	determines the compression algorithm to use when compressing sstable data blocks for backup transport; [snappy = 1, zstd = 2, none = 3, minlz = 4]	system-visible
+storage.sstable.compression_algorithm	enumeration	fastest	determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store; [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5]	system-visible
+storage.sstable.compression_algorithm_backup_storage	enumeration	fastest	determines the compression algorithm to use when compressing sstable data blocks for backup row data storage; [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5]	system-visible
+storage.sstable.compression_algorithm_backup_transport	enumeration	fastest	determines the compression algorithm to use when compressing sstable data blocks for backup transport; [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5]	system-visible
 timeseries.storage.resolution_10s.ttl	duration	240h0m0s	the maximum age of time series data stored at the 10 second resolution. Data older than this is subject to rollup and deletion.	system-visible
 timeseries.storage.resolution_30m.ttl	duration	2160h0m0s	the maximum age of time series data stored at the 30 minute resolution. Data older than this is subject to deletion.	system-visible
 trace.debug_http_endpoint.enabled (alias: trace.debug.enable)	boolean	false	if set, traces for recent requests can be seen at https://<ui>/debug/requests	application

docs/generated/settings/settings.html

@@ -357,9 +357,9 @@
 <tr><td><div id="setting-storage-ingestion-value-blocks-enabled" class="anchored"><code>storage.ingestion.value_blocks.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable writing of value blocks in ingestion sstables</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-storage-max-sync-duration" class="anchored"><code>storage.max_sync_duration</code></div></td><td>duration</td><td><code>20s</code></td><td>maximum duration for disk operations; any operations that take longer than this setting trigger a warning log entry or process crash</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
 <tr><td><div id="setting-storage-max-sync-duration-fatal-enabled" class="anchored"><code>storage.max_sync_duration.fatal.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if true, fatal the process when a disk operation exceeds storage.max_sync_duration</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
-<tr><td><div id="setting-storage-sstable-compression-algorithm" class="anchored"><code>storage.sstable.compression_algorithm</code></div></td><td>enumeration</td><td><code>minlz</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store; [snappy = 1, zstd = 2, none = 3, minlz = 4]</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
-<tr><td><div id="setting-storage-sstable-compression-algorithm-backup-storage" class="anchored"><code>storage.sstable.compression_algorithm_backup_storage</code></div></td><td>enumeration</td><td><code>minlz</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for backup row data storage; [snappy = 1, zstd = 2, none = 3, minlz = 4]</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
-<tr><td><div id="setting-storage-sstable-compression-algorithm-backup-transport" class="anchored"><code>storage.sstable.compression_algorithm_backup_transport</code></div></td><td>enumeration</td><td><code>minlz</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for backup transport; [snappy = 1, zstd = 2, none = 3, minlz = 4]</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
+<tr><td><div id="setting-storage-sstable-compression-algorithm" class="anchored"><code>storage.sstable.compression_algorithm</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store; [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5]</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
+<tr><td><div id="setting-storage-sstable-compression-algorithm-backup-storage" class="anchored"><code>storage.sstable.compression_algorithm_backup_storage</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for backup row data storage; [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5]</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
+<tr><td><div id="setting-storage-sstable-compression-algorithm-backup-transport" class="anchored"><code>storage.sstable.compression_algorithm_backup_transport</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for backup transport; [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5]</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>
 <tr><td><div id="setting-storage-wal-failover-unhealthy-op-threshold" class="anchored"><code>storage.wal_failover.unhealthy_op_threshold</code></div></td><td>duration</td><td><code>100ms</code></td><td>the latency of a WAL write considered unhealthy and triggers a failover to a secondary WAL location</td><td>Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-timeseries-storage-enabled" class="anchored"><code>timeseries.storage.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if set, periodic timeseries data is stored within the cluster; disabling is not recommended unless you are storing the data elsewhere</td><td>Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-timeseries-storage-resolution-10s-ttl" class="anchored"><code>timeseries.storage.resolution_10s.ttl</code></div></td><td>duration</td><td><code>240h0m0s</code></td><td>the maximum age of time series data stored at the 10 second resolution. Data older than this is subject to rollup and deletion.</td><td>Dedicated/Self-hosted (read-write); Serverless (read-only)</td></tr>

pkg/storage/pebble.go

@@ -12,7 +12,6 @@ import (
 	"math"
 	"os"
 	"path/filepath"
-	"runtime"
 	"sort"
 	"strconv"
 	"strings"
@@ -184,17 +183,22 @@ type CompressionAlgorithm int64
 // These values end up being the underlying value of the cluster setting, so
 // they must be stable across releases.
 const (
-	CompressionAlgorithmSnappy CompressionAlgorithm = 1
-	CompressionAlgorithmZstd   CompressionAlgorithm = 2
-	CompressionAlgorithmNone   CompressionAlgorithm = 3
-	CompressionAlgorithmMinLZ  CompressionAlgorithm = 4
+	CompressionAlgorithmSnappy  CompressionAlgorithm = 1
+	CompressionAlgorithmZstd    CompressionAlgorithm = 2
+	CompressionAlgorithmNone    CompressionAlgorithm = 3
+	CompressionAlgorithmMinLZ   CompressionAlgorithm = 4
+	CompressionAlgorithmFastest CompressionAlgorithm = 5
 )
 
 var compressionAlgorithmToString = map[CompressionAlgorithm]string{
 	CompressionAlgorithmSnappy: "snappy",
 	CompressionAlgorithmMinLZ:  "minlz",
 	CompressionAlgorithmNone:   "none",
 	CompressionAlgorithmZstd:   "zstd",
+
+	// CompressionAlgorithmFastest uses either Snappy or MinLZ, depending on the
+	// architecture.
+	CompressionAlgorithmFastest: "fastest",
 }
 
 // String implements fmt.Stringer for CompressionAlgorithm.
@@ -225,19 +229,6 @@ func RegisterCompressionAlgorithmClusterSetting(
 	)
 }
 
-var defaultCompressionAlgorithm = func() CompressionAlgorithm {
-	if runtime.GOARCH == "amd64" {
-		// We prefer MinLZ on amd64 because it is slightly superior to Snappy in
-		// almost all cases (both in terms of speed and compression ratio).
-		//
-		// Only amd64 has an optimized assembly MinLZ implementation; the Go
-		// implementation is significantly slower, especially when decompressing;
-		// see https://github.com/minio/minlz#protobuf-sample
-		return CompressionAlgorithmMinLZ
-	}
-	return CompressionAlgorithmSnappy
-}()
-
 // CompressionAlgorithmStorage determines the compression algorithm used to
 // compress data blocks when writing sstables for use in a Pebble store (written
 // directly, or constructed for ingestion on a remote store via AddSSTable).
@@ -246,7 +237,7 @@ var defaultCompressionAlgorithm = func() CompressionAlgorithm {
 var CompressionAlgorithmStorage = RegisterCompressionAlgorithmClusterSetting(
 	"storage.sstable.compression_algorithm",
 	`determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store;`,
-	defaultCompressionAlgorithm,
+	CompressionAlgorithmFastest,
 )
 
 // CompressionAlgorithmBackupStorage determines the compression algorithm used
@@ -256,7 +247,7 @@ var CompressionAlgorithmStorage = RegisterCompressionAlgorithmClusterSetting(
 var CompressionAlgorithmBackupStorage = RegisterCompressionAlgorithmClusterSetting(
 	"storage.sstable.compression_algorithm_backup_storage",
 	`determines the compression algorithm to use when compressing sstable data blocks for backup row data storage;`,
-	defaultCompressionAlgorithm,
+	CompressionAlgorithmFastest,
 )
 
 // CompressionAlgorithmBackupTransport determines the compression algorithm used
@@ -269,7 +260,7 @@ var CompressionAlgorithmBackupStorage = RegisterCompressionAlgorithmClusterSetti
 var CompressionAlgorithmBackupTransport = RegisterCompressionAlgorithmClusterSetting(
 	"storage.sstable.compression_algorithm_backup_transport",
 	`determines the compression algorithm to use when compressing sstable data blocks for backup transport;`,
-	defaultCompressionAlgorithm,
+	CompressionAlgorithmFastest,
 )
 
 func getCompressionProfile(
@@ -286,6 +277,8 @@ func getCompressionProfile(
 		return pebble.NoCompression
 	case CompressionAlgorithmMinLZ:
 		return pebble.MinLZCompression
+	case CompressionAlgorithmFastest:
+		return pebble.FastestCompression
 	default:
 		return pebble.DefaultCompression
 	}