backup: remove metamorphic backup manifest read

Epic: none

Release note: none

Author: msbutler

pkg/backup/backup_job.go

@@ -61,7 +61,6 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/cockroach/pkg/util/log/eventpb"
 	"github.com/cockroachdb/cockroach/pkg/util/log/logutil"
-	"github.com/cockroachdb/cockroach/pkg/util/metamorphic"
 	"github.com/cockroachdb/cockroach/pkg/util/mon"
 	"github.com/cockroachdb/cockroach/pkg/util/randutil"
 	"github.com/cockroachdb/cockroach/pkg/util/retry"
@@ -82,8 +81,6 @@ var BackupCheckpointInterval = settings.RegisterDurationSetting(
 	"the minimum time between writing progress checkpoints during a backup",
 	time.Minute)
 
-var forceReadBackupManifest = metamorphic.ConstantWithTestBool("backup-read-manifest", false)
-
 var useBulkOracle = settings.RegisterBoolSetting(
 	settings.ApplicationLevel,
 	"bulkio.backup.balanced_distribution.enabled",
@@ -705,7 +702,7 @@ func (b *backupResumer) Resume(ctx context.Context, execCtx interface{}) error {
 	defer mem.Close(ctx)
 	var memSize int64
 
-	if backupManifest == nil || forceReadBackupManifest {
+	if backupManifest == nil {
 		backupManifest, memSize, err = b.readManifestOnResume(ctx, &mem, p.ExecCfg(), defaultStore,
 			details, p.User(), &kmsEnv)
 		if err != nil {