Merge #147688

147688: jobs: fix typo in testing hooks r=jeffswenson a=stevendanna

Epic: none
Release note: None

Co-authored-by: Steven Danna <[email protected]>

Author: craig[bot]

pkg/jobs/jobs_test.go

@@ -1187,7 +1187,7 @@ func TestJobLifecycle(t *testing.T) {
 	ctx := context.Background()
 
 	var params base.TestServerArgs
-	params.Knobs.JobsTestingKnobs = &jobs.TestingKnobs{DisableRegistryLifecycleManagent: true}
+	params.Knobs.JobsTestingKnobs = &jobs.TestingKnobs{DisableRegistryLifecycleManagement: true}
 	srv, sqlDB, _ := serverutils.StartServer(t, params)
 	defer srv.Stopper().Stop(ctx)
 	s := srv.ApplicationLayer()

pkg/jobs/registry.go

@@ -944,7 +944,7 @@ func (r *Registry) withSession(ctx context.Context, f withSessionFunc) {
 // jobs if it observes a failure. Otherwise it starts all the main daemons of
 // registry that poll the jobs table and start/cancel/gc jobs.
 func (r *Registry) Start(ctx context.Context, stopper *stop.Stopper) error {
-	if r.knobs.DisableRegistryLifecycleManagent {
+	if r.knobs.DisableRegistryLifecycleManagement {
 		return nil
 	}
 

pkg/jobs/testing_knobs.go

@@ -72,8 +72,9 @@ type TestingKnobs struct {
 	// validates that these knobs are used in tandem.
 	DisableAdoptions bool
 
-	// DisableRegistryLifecycleManagement
-	DisableRegistryLifecycleManagent bool
+	// DisableRegistryLifecycleManagement disables all periodic job-system
+	// management tasks such as adoption and cancellation loops.
+	DisableRegistryLifecycleManagement bool
 
 	// BeforeWaitForJobsQuery is called once per invocation of the
 	// poll-show-jobs query in WaitForJobs.