teamcity: add s390x-test-failure label for relevant unit test failures

Epic: CRDB-21133
Release note: None

Author: rickystewart

build/teamcity/cockroach/ci/tests-ibm-cloud-linux-s390x/unit_tests_impl.sh

@@ -20,6 +20,7 @@ TESTS=$(bazel query 'kind(go_test, pkg/...) except attr("tags", "[\[ ]integratio
 
 set -x
 
-$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=dev \
-    $TESTS \
-    --profile=/artifacts/profile.gz
+$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci --extralabels=s390x-test-failure -- \
+		       test --config=ci --config=dev \
+		       $TESTS \
+		       --profile=/artifacts/profile.gz

pkg/cmd/bazci/bazci.go

@@ -61,6 +61,7 @@ var (
 	port                    int
 	artifactsDir            string
 	githubPostFormatterName string
+	extraLabels             []string
 
 	rootCmd = &cobra.Command{
 		Use:   "bazci",
@@ -286,6 +287,12 @@ func init() {
 		8998,
 		"port to run the bazci server on",
 	)
+	rootCmd.Flags().StringSliceVar(
+		&extraLabels,
+		"extralabels",
+		[]string{},
+		"comma-separated list of extra labels to add to any filed GitHub issues",
+	)
 }
 
 func getRunEnvForBeaverHub() string {
@@ -488,7 +495,7 @@ func processTestXmls(testXmls []string) error {
 				postErrors = append(postErrors, fmt.Sprintf("Failed to parse test.xml file with the following error: %+v", err))
 				continue
 			}
-			if err := githubpost.PostFromTestXMLWithFormatterName(githubPostFormatterName, testSuites); err != nil {
+			if err := githubpost.PostFromTestXMLWithFormatterName(githubPostFormatterName, testSuites, extraLabels); err != nil {
 				postErrors = append(postErrors, fmt.Sprintf("Failed to process %s with the following error: %+v", testXml, err))
 				continue
 			}

pkg/cmd/bazci/githubpost/githubpost.go

@@ -111,14 +111,22 @@ func DefaultIssueFilerFromFormatter(
 
 }
 
-func getFailurePosterFromFormatterName(formatterName string) FailurePoster {
+func getFailurePosterFromFormatterName(formatterName string, extraLabels []string) FailurePoster {
 	var reqFromFailure Formatter
 	switch formatterName {
 	case "pebble-metamorphic":
 		reqFromFailure = formatPebbleMetamorphicIssue
 	default:
 		reqFromFailure = DefaultFormatter
 	}
+	if len(extraLabels) > 0 {
+		reqFromFailure2 := func(ctx context.Context, f Failure) (issues.IssueFormatter, issues.PostRequest) {
+			i, r := reqFromFailure(ctx, f)
+			r.Labels = append(r.Labels, extraLabels...)
+			return i, r
+		}
+		reqFromFailure = reqFromFailure2
+	}
 	return DefaultIssueFilerFromFormatter(reqFromFailure)
 }
 
@@ -129,7 +137,7 @@ func getFailurePosterFromFormatterName(formatterName string) FailurePoster {
 // GitHub.
 func PostFromJSON(formatterName string, in io.Reader) {
 	ctx := context.Background()
-	fileIssue := getFailurePosterFromFormatterName(formatterName)
+	fileIssue := getFailurePosterFromFormatterName(formatterName, []string{})
 	if err := listFailuresFromJSON(ctx, in, fileIssue); err != nil {
 		log.Println(err) // keep going
 	}
@@ -138,10 +146,13 @@ func PostFromJSON(formatterName string, in io.Reader) {
 // PostFromTestXMLWithFormatterName consumes a Bazel-style `test.xml` stream
 // and posts issues for any failed tests to GitHub. If there are no failed
 // tests, it does nothing. Unlike PostFromTestXMLWithFailurePoster, it takes a
-// formatter name.
-func PostFromTestXMLWithFormatterName(formatterName string, testXml buildutil.TestSuites) error {
+// formatter name. extraLabels is a list of extra labels to apply to the
+// created GitHub issue.
+func PostFromTestXMLWithFormatterName(
+	formatterName string, testXml buildutil.TestSuites, extraLabels []string,
+) error {
 	ctx := context.Background()
-	fileIssue := getFailurePosterFromFormatterName(formatterName)
+	fileIssue := getFailurePosterFromFormatterName(formatterName, extraLabels)
 	return PostFromTestXMLWithFailurePoster(ctx, fileIssue, testXml)
 }
 
@@ -738,7 +749,7 @@ func formatPebbleMetamorphicIssue(
 // insight into what caused the build failure and can't properly assign owners,
 // so a general issue is filed against test-eng in this case.
 func PostGeneralFailure(formatterName, logs string) {
-	fileIssue := getFailurePosterFromFormatterName(formatterName)
+	fileIssue := getFailurePosterFromFormatterName(formatterName, []string{})
 	postGeneralFailureImpl(logs, fileIssue)
 }