Skip to content

Commit 08ce8f9

Browse files
committed
roachtest: deflake cdc/ledger
This patch deflakes `cdc/ledger` by increasing the target steady latency from 1 minute to 3 minutes. It also eliminates a weird quirk where the latency verifier expects the latency to be less than half of the target latency before it'll be considered steady, which led to weird logs and added unnecessary complexity. Release note: None
1 parent 99e7c38 commit 08ce8f9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/cmd/roachtest/tests/cdc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2574,7 +2574,7 @@ CONFIGURE ZONE USING
25742574
})
25752575
ct.runFeedLatencyVerifier(feed, latencyTargets{
25762576
initialScanLatency: 10 * time.Minute,
2577-
steadyLatency: time.Minute,
2577+
steadyLatency: 3 * time.Minute,
25782578
})
25792579
ct.waitForWorkload()
25802580
},

pkg/cmd/roachtest/tests/latency_verifier.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func (lv *latencyVerifier) noteHighwater(highwaterTime time.Time) {
116116
return
117117
}
118118

119-
if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency/2 {
119+
if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency {
120120
lv.latencyBecameSteady = true
121121
}
122122
if !lv.latencyBecameSteady {

0 commit comments

Comments
 (0)