Merge #143305 #143390

143305: util/mon: reduce monitor-related allocations r=mgartner a=mgartner

#### util/mon: rename fields of MonitorName

Release note: None

#### util/uuid: add comment to uuid.Short

Release note: None

#### util/mon: add fields to MonitorName

The `processorID`, `suffix`, and `i` fields will be used in future
commits to reduce allocations related to MonitorNames.

Release note: None

#### util/mon: compile-time checks for size of BytesMonitor and BoundAccount

Release note: None

#### sql: use mon.MonitorName in more places

Using structured `mon.MonitorName` objects reduces allocations of
strings in some cases. This commit doesn't replace all usages of string
monitor names - there are myriad such usages. We can iteratively chip
away at them in future commits.

Release note: None

#### util/mon: reduce size of MonitorName

The size of `MonitorName` has been reduced by replacing the string
suffix with a suffix enum.

Release note: None

#### util/mon: further reduce the size of MonitorName

The size of `MonitorName` has been reduced by using the same 4 bytes to
store either the `int32` processor ID or the `uuid.Short`, and by
reducing the optional integer suffix from an `int32` to `uint16`, which
should be sufficient in all cases.

Release note: None

#### util/mon: rename MonitorName to Name

Release note: None

#### util/mon: remove deprecated NewMonitorWithStringName

All usages of the deprecated NewMonitorWithStringName function have been
replaced with NewMonitor, and the former has been removed.

Release note: None

#### util/mon: remove deprecated NewMonitorInheritWithLimitAndStringName

All usages of the deprecated NewMonitorInheritWithLimitAndStringName
function have been replaced with NewMonitorInheritWithLimit, and the
former has been removed.

Release note: None

#### colexec: batch allocations of BoundAccount

Allocations of `BoundAccount`s in `createUnlimitedMemAccountsLocked` are
now batched into a single allocation.

Release note: None

#### sql/rowflow: refactor monitor name

The monitor names created in `(*rowBasedFlow).setupRouter` now use
`(*mon.Name).WithID` to add the stream ID to the name instead of
allocating a new string.

Epic: None
Release note: None


143390: raft: remove sync writes API r=tbg a=pav-kv

This PR removes the synchronous writes API from raft. All storage interaction is done via the asynchronous API, which used to be guarded by the `AsyncStorageWrites` config option. Further work will double down on the asynchronous API and make it type-safe.

Resolves #129411
Part of #124440

Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Pavel Kalinnikov <[email protected]>

Author: 3 people

pkg/backup/backup_test.go

@@ -8370,7 +8370,7 @@ func TestReadBackupManifestMemoryMonitoring(t *testing.T) {
 	require.NoError(t, err)
 
 	m := mon.NewMonitor(mon.Options{
-		Name:     mon.MakeMonitorName("test-monitor"),
+		Name:     mon.MakeName("test-monitor"),
 		Settings: st,
 	})
 	m.Start(ctx, nil, mon.NewStandaloneBudget(128<<20))

pkg/backup/backuputils/memory_backed_quota_pool.go

@@ -40,7 +40,7 @@ func NewMemoryBackedQuotaPool(
 	}
 
 	if m != nil {
-		q.mon = mon.NewMonitorInheritWithLimit(name, limit, m, false /* longLiving */)
+		q.mon = mon.NewMonitorInheritWithLimit(mon.MakeName(name), limit, m, false /* longLiving */)
 		q.mon.StartNoReserved(ctx, m)
 		mem := q.mon.MakeBoundAccount()
 		q.mem = &mem

pkg/backup/backuputils/memory_backed_quota_pool_test.go

@@ -21,7 +21,7 @@ import (
 
 func getMemoryMonitor(limit int64) *mon.BytesMonitor {
 	return mon.NewMonitor(mon.Options{
-		Name:      mon.MakeMonitorName("test-mon"),
+		Name:      mon.MakeName("test-mon"),
 		Limit:     limit,
 		Increment: 1,
 		Settings:  cluster.MakeTestingClusterSettings(),

pkg/backup/restore_data_processor_test.go

@@ -270,7 +270,7 @@ func runTestIngest(t *testing.T, init func(*cluster.Settings)) {
 			Settings: s.ClusterSettings(),
 			Codec:    s.Codec(),
 			BackupMonitor: mon.NewUnlimitedMonitor(ctx, mon.Options{
-				Name:     mon.MakeMonitorName("test"),
+				Name:     mon.MakeName("test"),
 				Settings: s.ClusterSettings(),
 			}),
 			BulkSenderLimiter: limit.MakeConcurrentRequestLimiter("test", math.MaxInt),

pkg/base/config.go

@@ -947,11 +947,11 @@ func InheritTempStorageConfig(
 func newTempStorageConfig(
 	ctx context.Context, st *cluster.Settings, inMemory bool, useStore StoreSpec, maxSizeBytes int64,
 ) TempStorageConfig {
-	var monitorName mon.MonitorName
+	var monitorName mon.Name
 	if inMemory {
-		monitorName = mon.MakeMonitorName("in-mem temp storage")
+		monitorName = mon.MakeName("in-mem temp storage")
 	} else {
-		monitorName = mon.MakeMonitorName("temp disk storage")
+		monitorName = mon.MakeName("temp disk storage")
 	}
 	monitor := mon.NewMonitor(mon.Options{
 		Name:      monitorName,

pkg/base/test_server_args.go

@@ -591,7 +591,7 @@ func DefaultTestTempStorageConfigWithSize(
 	st *cluster.Settings, maxSizeBytes int64,
 ) TempStorageConfig {
 	monitor := mon.NewMonitor(mon.Options{
-		Name:      mon.MakeMonitorName("in-mem temp storage"),
+		Name:      mon.MakeName("in-mem temp storage"),
 		Res:       mon.DiskResource,
 		Increment: 1024 * 1024,
 		Settings:  st,

pkg/ccl/changefeedccl/changefeed_processors.go

@@ -195,7 +195,7 @@ func newChangeAggregatorProcessor(
 		}
 	}()
 
-	memMonitor := execinfra.NewMonitor(ctx, flowCtx.Mon, "changeagg-mem")
+	memMonitor := execinfra.NewMonitor(ctx, flowCtx.Mon, mon.MakeName("changeagg-mem"))
 	ca := &changeAggregator{
 		spec:              spec,
 		memAcc:            memMonitor.MakeBoundAccount(),
@@ -444,7 +444,7 @@ func (ca *changeAggregator) startKVFeed(
 	opts changefeedbase.StatementOptions,
 ) (kvevent.Reader, chan struct{}, chan error, error) {
 	cfg := ca.FlowCtx.Cfg
-	kvFeedMemMon := mon.NewMonitorInheritWithLimit("kvFeed", memLimit, parentMemMon, false /* longLiving */)
+	kvFeedMemMon := mon.NewMonitorInheritWithLimit(mon.MakeName("kvFeed"), memLimit, parentMemMon, false /* longLiving */)
 	kvFeedMemMon.StartNoReserved(ctx, parentMemMon)
 	buf := kvevent.NewThrottlingBuffer(
 		kvevent.NewMemBuffer(kvFeedMemMon.MakeBoundAccount(), &cfg.Settings.SV, &ca.metrics.KVFeedMetrics.AggregatorBufferMetricsWithCompat),
@@ -1193,7 +1193,7 @@ func newChangeFrontierProcessor(
 	input execinfra.RowSource,
 	post *execinfrapb.PostProcessSpec,
 ) (execinfra.Processor, error) {
-	memMonitor := execinfra.NewMonitor(ctx, flowCtx.Mon, "changefntr-mem")
+	memMonitor := execinfra.NewMonitor(ctx, flowCtx.Mon, mon.MakeName("changefntr-mem"))
 
 	cf := &changeFrontier{
 		// We might modify the ChangefeedState field in the eval.Context, so we

pkg/ccl/changefeedccl/changefeed_test.go

@@ -9330,7 +9330,7 @@ func TestChangefeedPredicateWithSchemaChange(t *testing.T) {
 
 func startMonitorWithBudget(budget int64) *mon.BytesMonitor {
 	mm := mon.NewMonitor(mon.Options{
-		Name:      mon.MakeMonitorName("test-mm"),
+		Name:      mon.MakeName("test-mm"),
 		Limit:     budget,
 		Increment: 128, /* small allocation increment */
 		Settings:  cluster.MakeTestingClusterSettings(),

pkg/ccl/changefeedccl/kvevent/blocking_buffer_test.go

@@ -68,7 +68,7 @@ func makeRangeFeedEvent(rnd *rand.Rand, valSize int, prevValSize int) *kvpb.Rang
 
 func getBoundAccountWithBudget(budget int64) (account mon.BoundAccount, cleanup func()) {
 	mm := mon.NewMonitor(mon.Options{
-		Name:      mon.MakeMonitorName("test-mm"),
+		Name:      mon.MakeName("test-mm"),
 		Limit:     budget,
 		Increment: 128, /* small allocation increment */
 		Settings:  cluster.MakeTestingClusterSettings(),

pkg/ccl/changefeedccl/kvfeed/kv_feed_test.go

@@ -120,7 +120,7 @@ func TestKVFeed(t *testing.T) {
 	runTest := func(t *testing.T, tc testCase) {
 		settings := cluster.MakeTestingClusterSettings()
 		mm := mon.NewUnlimitedMonitor(context.Background(), mon.Options{
-			Name:     mon.MakeMonitorName("test"),
+			Name:     mon.MakeName("test"),
 			Settings: settings,
 		})
 		metrics := kvevent.MakeMetrics(time.Minute)