Skip to content

Commit 0c85e9d

Browse files
craig[bot]yuzefovich
andcommitted
Merge #152743
152743: sql: fix a flake in TestSavepoints r=mw5h a=yuzefovich The test can have a flake with txnWriteBuffer buffer size in certain range, and when working on eec520b I only tried very small values like 1-3B, so I didn't catch this flake. (Additionally, that commit reduced the range of allowed values making the flake much more likely.) Require 2KiB buffer size minimum to de-flake it. Fixes: #152039. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
2 parents 6a796d5 + 36a4132 commit 0c85e9d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/sql/conn_executor_savepoints_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ func TestSavepoints(t *testing.T) {
3333
s, origConn, _ := serverutils.StartServer(t, params)
3434
defer s.Stopper().Stop(ctx)
3535

36+
if _, err := origConn.Exec(`SET CLUSTER SETTING kv.transaction.write_buffering.max_buffer_size = '2KiB';`); err != nil {
37+
t.Fatal(err)
38+
}
3639
if _, err := origConn.Exec(`CREATE TABLE progress(
3740
conn STRING,
3841
n INT,

0 commit comments

Comments
 (0)