asim: fix lower_bound

tbg · tbg · commit 0ea687f4219d · 2025-09-19T12:53:22.000+02:00
It wasn't being removed from the args, so using it necessarily
tripped the test. We need to call `scanIfExists` (this could
all be made a little less opaque).
diff --git a/pkg/kv/kvserver/asim/tests/helpers_test.go b/pkg/kv/kvserver/asim/tests/helpers_test.go
@@ -105,7 +105,7 @@ func scanThreshold(t *testing.T, d *datadriven.TestData) (th assertion.Threshold
 		th.ThresholdType = assertion.UpperBound
 		return th
 	}
-	scanArg(t, d, "lower_bound", &th.Value)
+	scanMustExist(t, d, "lower_bound", &th.Value)
 	th.ThresholdType = assertion.LowerBound
 	return th
 }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ func scanThreshold(t testing.T, d datadriven.TestData) (th assertion.Threshold`
`105`	`105`	`th.ThresholdType = assertion.UpperBound`
`106`	`106`	`return th`
`107`	`107`	`}`
`108`		`- scanArg(t, d, "lower_bound", &th.Value)`
	`108`	`+ scanMustExist(t, d, "lower_bound", &th.Value)`
`109`	`109`	`th.ThresholdType = assertion.LowerBound`
`110`	`110`	`return th`
`111`	`111`	`}`