Skip to content

Commit 0f00b7d

Browse files
committed
pg_regress: accept new diffs
* ltree patches moved some type outputs around * a change to pg_regress output moved diffs down 6 rows. Fixes: #151625 Release note: None
1 parent e227d62 commit 0f00b7d

File tree

4 files changed

+137
-128
lines changed

4 files changed

+137
-128
lines changed

pkg/cmd/roachtest/testdata/pg_regress/aggregates.diffs

Lines changed: 34 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
13481348
-- Ensure that we never choose to provide presorted input to an Aggref with
13491349
-- a volatile function in the ORDER BY / DISTINCT clause. We want to ensure
13501350
-- these sorts are performed individually rather than at the query level.
1351-
@@ -1527,34 +1306,76 @@
1351+
@@ -1527,34 +1306,78 @@
13521352
sum(unique1 order by two, random(), random() + 1)
13531353
from tenk1
13541354
group by ten;
@@ -1418,6 +1418,8 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
14181418
+array_agg(jsonb[]) -> jsonb[][]
14191419
+array_agg(varbit) -> varbit[]
14201420
+array_agg(varbit[]) -> varbit[][]
1421+
+array_agg(ltree) -> ltree[]
1422+
+array_agg(ltree[]) -> ltree[][]
14211423
+array_agg(anyenum) -> anyenum[]
14221424
+array_agg(anyenum[]) -> anyenum[][]
14231425
+array_agg(tuple) -> tuple[]
@@ -1444,7 +1446,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
14441446
--
14451447
-- Test combinations of DISTINCT and/or ORDER BY
14461448
--
1447-
@@ -1595,246 +1416,186 @@
1449+
@@ -1595,246 +1418,186 @@
14481450

14491451
select array_agg(distinct a order by a)
14501452
from (values (1),(2),(1),(3),(null),(2)) v(a);
@@ -1788,7 +1790,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
17881790
-- string_agg tests
17891791
select string_agg(a,',') from (values('aaaa'),('bbbb'),('cccc')) g(a);
17901792
string_agg
1791-
@@ -1862,25 +1623,29 @@
1793+
@@ -1862,25 +1625,29 @@
17921794

17931795
-- check some implicit casting cases, as per bug #5564
17941796
select string_agg(distinct f1, ',' order by f1) from varchar_tbl; -- ok
@@ -1834,7 +1836,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
18341836
-- string_agg bytea tests
18351837
create table bytea_test_table(v bytea);
18361838
select string_agg(v, '') from bytea_test_table;
1837-
@@ -1922,11 +1687,60 @@
1839+
@@ -1922,11 +1689,60 @@
18381840
select (case x % 4 when 1 then null else x end), x % 10
18391841
from generate_series(1,5000) x;
18401842
set parallel_setup_cost TO 0;
@@ -1895,7 +1897,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
18951897
-- create a view as we otherwise have to repeat this query a few times.
18961898
create view v_pagg_test AS
18971899
select
1898-
@@ -1954,66 +1768,92 @@
1900+
@@ -1954,66 +1770,92 @@
18991901
) a1
19001902
) a2
19011903
group by y;
@@ -2033,7 +2035,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
20332035
drop table pagg_test;
20342036
-- FILTER tests
20352037
select min(unique1) filter (where unique1 > 100) from tenk1;
2036-
@@ -2023,13 +1863,9 @@
2038+
@@ -2023,13 +1865,9 @@
20372039
(1 row)
20382040

20392041
select sum(1/ten) filter (where ten > 0) from tenk1;
@@ -2049,7 +2051,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
20492051
ten | sum
20502052
-----+-----
20512053
0 |
2052-
@@ -2045,17 +1881,14 @@
2054+
@@ -2045,17 +1883,14 @@
20532055
(10 rows)
20542056

20552057
select ten, sum(distinct four) filter (where four > 10) from onek a
@@ -2074,7 +2076,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
20742076
select max(foo COLLATE "C") filter (where (bar collate "POSIX") > '0')
20752077
from (values ('a', 'b')) AS v(foo,bar);
20762078
max
2077-
@@ -2064,11 +1897,7 @@
2079+
@@ -2064,11 +1899,7 @@
20782080
(1 row)
20792081

20802082
select any_value(v) filter (where v > 2) from (values (1), (2), (3)) as v (v);
@@ -2087,7 +2089,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
20872089
-- outer reference in FILTER (PostgreSQL extension)
20882090
select (select count(*)
20892091
from (values (1)) t0(inner_c))
2090-
@@ -2117,11 +1946,10 @@
2092+
@@ -2117,11 +1948,10 @@
20912093
select aggfns(distinct a,b,c order by a,c using ~<~,b) filter (where a > 1)
20922094
from (values (1,3,'foo'),(0,null,null),(2,2,'bar'),(3,1,'baz')) v(a,b,c),
20932095
generate_series(1,2) i;
@@ -2103,7 +2105,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
21032105
-- check handling of bare boolean Var in FILTER
21042106
select max(0) filter (where b1) from bool_test;
21052107
max
2106-
@@ -2137,78 +1965,49 @@
2108+
@@ -2137,78 +1967,49 @@
21072109

21082110
-- check for correct detection of nested-aggregate errors in FILTER
21092111
select max(unique1) filter (where sum(ten) > 0) from tenk1;
@@ -2198,7 +2200,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
21982200
select percentile_disc(0.5) within group (order by thousand) from tenk1;
21992201
percentile_disc
22002202
-----------------
2201-
@@ -2217,161 +2016,97 @@
2203+
@@ -2217,161 +2018,97 @@
22022204

22032205
select rank(3) within group (order by x)
22042206
from (values (1),(1),(2),(2),(3),(3),(4)) v(x);
@@ -2404,7 +2406,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
24042406
-- deparse and multiple features:
24052407
create view aggordview1 as
24062408
select ten,
2407-
@@ -2380,73 +2115,83 @@
2409+
@@ -2380,73 +2117,83 @@
24082410
rank(5,'AZZZZ',50) within group (order by hundred, string4 desc, hundred)
24092411
from tenk1
24102412
group by ten order by ten;
@@ -2540,7 +2542,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
25402542
create type avg_state as (total bigint, count bigint);
25412543
create or replace function avg_transfn(state avg_state, n int) returns avg_state as
25422544
$$
2543-
@@ -2469,6 +2214,10 @@
2545+
@@ -2469,6 +2216,10 @@
25442546
return null;
25452547
end
25462548
$$ language plpgsql;
@@ -2551,7 +2553,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
25512553
create function avg_finalfn(state avg_state) returns int4 as
25522554
$$
25532555
begin
2554-
@@ -2479,6 +2228,10 @@
2556+
@@ -2479,6 +2230,10 @@
25552557
end if;
25562558
end
25572559
$$ language plpgsql;
@@ -2562,7 +2564,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
25622564
create function sum_finalfn(state avg_state) returns int4 as
25632565
$$
25642566
begin
2565-
@@ -2489,106 +2242,70 @@
2567+
@@ -2489,106 +2244,70 @@
25662568
end if;
25672569
end
25682570
$$ language plpgsql;
@@ -2695,7 +2697,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
26952697
-- test that aggs with the same sfunc and initcond share the same agg state
26962698
create aggregate my_sum_init(int4)
26972699
(
2698-
@@ -2597,6 +2314,12 @@
2700+
@@ -2597,6 +2316,12 @@
26992701
finalfunc = sum_finalfn,
27002702
initcond = '(10,0)'
27012703
);
@@ -2708,7 +2710,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
27082710
create aggregate my_avg_init(int4)
27092711
(
27102712
stype = avg_state,
2711-
@@ -2604,6 +2327,12 @@
2713+
@@ -2604,6 +2329,12 @@
27122714
finalfunc = avg_finalfn,
27132715
initcond = '(10,0)'
27142716
);
@@ -2721,7 +2723,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
27212723
create aggregate my_avg_init2(int4)
27222724
(
27232725
stype = avg_state,
2724-
@@ -2611,30 +2340,28 @@
2726+
@@ -2611,30 +2342,28 @@
27252727
finalfunc = avg_finalfn,
27262728
initcond = '(4,0)'
27272729
);
@@ -2766,7 +2768,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
27662768
create or replace function sum_transfn(state int4, n int4) returns int4 as
27672769
$$
27682770
declare new_state int4;
2769-
@@ -2664,29 +2391,35 @@
2771+
@@ -2664,29 +2393,35 @@
27702772
end if;
27712773
end
27722774
$$ language plpgsql;
@@ -2811,7 +2813,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
28112813
-- test that the aggregate transition logic correctly handles
28122814
-- transition / combine functions returning NULL
28132815
-- First test the case of a normal transition function returning NULL
2814-
@@ -2701,6 +2434,8 @@
2816+
@@ -2701,6 +2436,8 @@
28152817
END IF;
28162818
RETURN NULL;
28172819
END$$;
@@ -2820,7 +2822,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
28202822
CREATE AGGREGATE balk(int4)
28212823
(
28222824
SFUNC = balkifnull(int8, int4),
2823-
@@ -2708,13 +2443,16 @@
2825+
@@ -2708,13 +2445,16 @@
28242826
PARALLEL = SAFE,
28252827
INITCOND = '0'
28262828
);
@@ -2842,7 +2844,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
28422844
-- Secondly test the case of a parallel aggregate combiner function
28432845
-- returning NULL. For that use normal transition function, but a
28442846
-- combiner function returning NULL.
2845-
@@ -2730,6 +2468,23 @@
2847+
@@ -2730,6 +2470,23 @@
28462848
END IF;
28472849
RETURN NULL;
28482850
END$$;
@@ -2866,7 +2868,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
28662868
CREATE AGGREGATE balk(int4)
28672869
(
28682870
SFUNC = int4_sum(int8, int4),
2869-
@@ -2738,26 +2493,27 @@
2871+
@@ -2738,26 +2495,27 @@
28702872
PARALLEL = SAFE,
28712873
INITCOND = '0'
28722874
);
@@ -2908,7 +2910,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
29082910
ROLLBACK;
29092911
-- test multiple usage of an aggregate whose finalfn returns a R/W datum
29102912
BEGIN;
2911-
@@ -2767,6 +2523,8 @@
2913+
@@ -2767,6 +2525,8 @@
29122914
RETURN array_fill(y[1], ARRAY[4]);
29132915
END;
29142916
$$;
@@ -2917,7 +2919,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
29172919
CREATE FUNCTION rwagg_finalfunc(x anyarray) RETURNS anyarray
29182920
LANGUAGE plpgsql STRICT IMMUTABLE AS $$
29192921
DECLARE
2920-
@@ -2777,11 +2535,25 @@
2922+
@@ -2777,11 +2537,25 @@
29212923
RETURN res;
29222924
END;
29232925
$$;
@@ -2943,7 +2945,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
29432945
CREATE FUNCTION eatarray(x real[]) RETURNS real[]
29442946
LANGUAGE plpgsql STRICT IMMUTABLE AS $$
29452947
BEGIN
2946-
@@ -2789,21 +2561,44 @@
2948+
@@ -2789,21 +2563,44 @@
29472949
RETURN x;
29482950
END;
29492951
$$;
@@ -2993,7 +2995,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
29932995
-- variance(int4) covers numeric_poly_combine
29942996
-- sum(int8) covers int8_avg_combine
29952997
-- regr_count(float8, float8) covers int8inc_float8_float8 and aggregates with > 1 arg
2996-
@@ -2813,36 +2608,17 @@
2998+
@@ -2813,36 +2610,17 @@
29972999
UNION ALL SELECT * FROM tenk1
29983000
UNION ALL SELECT * FROM tenk1
29993001
UNION ALL SELECT * FROM tenk1) u;
@@ -3036,7 +3038,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
30363038
-- variance(int8) covers numeric_combine
30373039
-- avg(numeric) covers numeric_avg_combine
30383040
EXPLAIN (COSTS OFF, VERBOSE)
3039-
@@ -2851,46 +2627,22 @@
3041+
@@ -2851,46 +2629,22 @@
30403042
UNION ALL SELECT * FROM tenk1
30413043
UNION ALL SELECT * FROM tenk1
30423044
UNION ALL SELECT * FROM tenk1) u;
@@ -3091,7 +3093,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
30913093
-- Ensure that the STRICT checks for aggregates does not take NULLness
30923094
-- of ORDER BY columns into account. See bug report around
30933095
3094-
@@ -2929,27 +2681,46 @@
3096+
@@ -2929,27 +2683,46 @@
30953097
-- does not lead to array overflow due to unexpected duplicate hash keys
30963098
-- see CAFeeJoKKu0u+A_A9R9316djW-YW3-+Gtgvy3ju655qRHR3jtdA@mail.gmail.com
30973099
set enable_memoize to off;
@@ -3150,7 +3152,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
31503152
select unique1, count(*), sum(twothousand) from tenk1
31513153
group by unique1
31523154
having sum(fivethous) > 4975
3153-
@@ -3007,36 +2778,84 @@
3155+
@@ -3007,36 +2780,84 @@
31543156
(48 rows)
31553157

31563158
set work_mem to default;
@@ -3244,7 +3246,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
32443246
create table agg_group_2 as
32453247
select * from
32463248
(values (100), (300), (500)) as r(a),
3247-
@@ -3047,30 +2866,58 @@
3249+
@@ -3047,30 +2868,58 @@
32483250
from agg_data_2k
32493251
where g < r.a
32503252
group by g/2) as s;
@@ -3310,7 +3312,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
33103312
create table agg_hash_2 as
33113313
select * from
33123314
(values (100), (300), (500)) as r(a),
3313-
@@ -3081,15 +2928,43 @@
3315+
@@ -3081,15 +2930,43 @@
33143316
from agg_data_2k
33153317
where g < r.a
33163318
group by g/2) as s;

pkg/cmd/roachtest/testdata/pg_regress/create_function_sql.diffs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/create_function_s
820820

821821
-- Regression tests for bugs:
822822
-- Check that arguments that are R/W expanded datums aren't corrupted by
823-
@@ -674,70 +758,60 @@
823+
@@ -674,70 +758,61 @@
824824
CREATE FUNCTION double_append(anyarray, anyelement) RETURNS SETOF anyarray
825825
LANGUAGE SQL IMMUTABLE AS
826826
$$ SELECT array_append($1, $2) || array_append($1, $2) $$;
@@ -847,6 +847,7 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/create_function_s
847847
+array_append(timetz[], timetz) -> timetz[]
848848
+array_append(jsonb[], jsonb) -> jsonb[]
849849
+array_append(varbit[], varbit) -> varbit[]
850+
+array_append(ltree[], ltree) -> ltree[]
850851
+array_append(anyenum[], anyenum) -> anyenum[]
851852
+array_append(tuple[], tuple) -> tuple[]
852853
+

0 commit comments

Comments
 (0)