sql: reset schema_locked correctly in a mixed version state

Previously, when schema_locked was reset it would always adopt the value
from create_table_with_schema_locked. This was incorrect, since this
setting should only adopted if the cluster is running on 25.3. This
patch adds a version gate in the reset logic.

Fixes: #149266

Release note: None

Author: fqazi

pkg/sql/logictest/testdata/logic_test/schema_locked

@@ -1,3 +1,10 @@
+# Intentionally set this to true in 25.2, this setting
+# should be ignored.
+onlyif config local-mixed-25.2
+statement ok
+SET create_table_with_schema_locked=true
+
+skipif config local-mixed-25.2
 statement ok
 SET create_table_with_schema_locked=false
 

pkg/sql/storageparam/tablestorageparam/BUILD.bazel

@@ -6,6 +6,7 @@ go_library(
     importpath = "github.com/cockroachdb/cockroach/pkg/sql/storageparam/tablestorageparam",
     visibility = ["//visibility:public"],
     deps = [
+        "//pkg/clusterversion",
         "//pkg/sql/catalog/catpb",
         "//pkg/sql/catalog/tabledesc",
         "//pkg/sql/paramparse",

pkg/sql/storageparam/tablestorageparam/table_storage_param.go

@@ -12,6 +12,7 @@ import (
 	"math"
 	"strings"
 
+	"github.com/cockroachdb/cockroach/pkg/clusterversion"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/catpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc"
 	"github.com/cockroachdb/cockroach/pkg/sql/paramparse"
@@ -608,7 +609,12 @@ var tableParams = map[string]tableParam{
 			return nil
 		},
 		onReset: func(ctx context.Context, po *Setter, evalCtx *eval.Context, key string) error {
-			po.TableDesc.SchemaLocked = evalCtx.SessionData().CreateTableWithSchemaLocked
+			schemaLockedDefault := evalCtx.SessionData().CreateTableWithSchemaLocked
+			// Before 25.3 tables were never created with schema_locked by default.
+			if !evalCtx.Settings.Version.IsActive(ctx, clusterversion.V25_3) {
+				schemaLockedDefault = false
+			}
+			po.TableDesc.SchemaLocked = schemaLockedDefault
 			return nil
 		},
 	},