Skip to content

Commit 1057749

Browse files
craig[bot]aerfrei
andcommitted
Merge #145352
145352: Add fine-grained checkpointing metrics to DRT clusters r=rharding6373 a=aerfrei We added fine grained checkpointing for changefeeds in release 25.2. In order to monitor the additional resources involved in taking the checkpoints, we added metrics on the total number of bytes, spans, timestamps and write time involved in these checkpoints. This commit makes those visible in datadog for DRT clusters. Epic: none Release note: None Co-authored-by: Aerin Freilich <[email protected]>
2 parents c98cf90 + 659280b commit 1057749

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

pkg/roachprod/opentelemetry/cockroachdb_metrics.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,24 @@ var cockroachdbMetrics = map[string]string{
333333
"changefeed_buffer_pushback_nanos_aggregator": "changefeed.buffer_pushback_nanos.aggregator",
334334
"changefeed_buffer_pushback_nanos_rangefeed": "changefeed.buffer_pushback_nanos.rangefeed",
335335
"changefeed_bytes_messages_pushback_nanos": "changefeed.bytes.messages_pushback",
336+
"changefeed_checkpoint_create_nanos": "changefeed.checkpoint.create_nanos",
337+
"changefeed_checkpoint_create_nanos_bucket": "changefeed.checkpoint.create_nanos.bucket",
338+
"changefeed_checkpoint_create_nanos_count": "changefeed.checkpoint.create_nanos.count",
339+
"changefeed_checkpoint_create_nanos_sum": "changefeed.checkpoint.create_nanos.sum",
336340
"changefeed_checkpoint_hist_nanos": "changefeed.checkpoint_hist",
337341
"changefeed_checkpoint_hist_nanos_bucket": "changefeed.checkpoint_hist_nanos.bucket",
338342
"changefeed_checkpoint_hist_nanos_count": "changefeed.checkpoint_hist_nanos.count",
339343
"changefeed_checkpoint_hist_nanos_sum": "changefeed.checkpoint_hist_nanos.sum",
340344
"changefeed_checkpoint_progress": "changefeed.checkpoint_progress",
345+
"changefeed_checkpoint_total_bytes": "changefeed.checkpoint.total_bytes",
346+
"changefeed_checkpoint_timestamp_count": "changefeed.checkpoint.timestamp_count",
347+
"changefeed_checkpoint_timestamp_count_bucket": "changefeed.checkpoint.timestamp_count.bucket",
348+
"changefeed_checkpoint_timestamp_count_count": "changefeed.checkpoint.timestamp_count.count",
349+
"changefeed_checkpoint_timestamp_count_sum": "changefeed.checkpoint.timestamp_count.sum",
350+
"changefeed_checkpoint_span_count": "changefeed.checkpoint.span_count",
351+
"changefeed_checkpoint_span_count_bucket": "changefeed.checkpoint.span_count.bucket",
352+
"changefeed_checkpoint_span_count_count": "changefeed.checkpoint.span_count.count",
353+
"changefeed_checkpoint_span_count_sum": "changefeed.checkpoint.span_count.sum",
341354
"changefeed_cloudstorage_buffered_bytes": "changefeed.cloudstorage_buffered_bytes",
342355
"changefeed_commit_latency": "changefeed.commit.latency",
343356
"changefeed_commit_latency_bucket": "changefeed.commit_latency.bucket",

0 commit comments

Comments
 (0)