roachprod-microbench: remove unused error counter

herkolategan · herkolategan · commit 1146ea6f553e · 2025-06-02T08:58:57.000+01:00
Epic: None
Release note: None
diff --git a/pkg/cmd/roachprod-microbench/executor.go b/pkg/cmd/roachprod-microbench/executor.go
@@ -425,7 +425,6 @@ func (e *executor) executeBenchmarks() error {
 	}
 
 	// Execute commands.
-	benchmarkErrorCount := 0
 	logIndex := 0
 	missingBenchmarks := make(map[benchmark]int, 0)
 	failedBenchmarks := make(map[benchmark]int, 0)
@@ -467,7 +466,6 @@ func (e *executor) executeBenchmarks() error {
 					executorError = errors.CombineErrors(executorError, errors.Wrap(err, "failed to post benchmark issue"))
 				}
 			}
-			benchmarkErrorCount++
 			logIndex++
 		}
 		if _, writeErr := report.analyticsOutput[benchmarkResponse.pkg].WriteString(

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,6 @@ func (e *executor) executeBenchmarks() error {`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`// Execute commands.`
`428`		`- benchmarkErrorCount := 0`
`429`	`428`	`logIndex := 0`
`430`	`429`	`missingBenchmarks := make(map[benchmark]int, 0)`
`431`	`430`	`failedBenchmarks := make(map[benchmark]int, 0)`
`@@ -467,7 +466,6 @@ func (e *executor) executeBenchmarks() error {`
`467`	`466`	`executorError = errors.CombineErrors(executorError, errors.Wrap(err, "failed to post benchmark issue"))`
`468`	`467`	`}`
`469`	`468`	`}`
`470`		`- benchmarkErrorCount++`
`471`	`469`	`logIndex++`
`472`	`470`	`}`
`473`	`471`	`if _, writeErr := report.analyticsOutput[benchmarkResponse.pkg].WriteString(`