Skip to content

Commit 1437883

Browse files
committed
kvcoord: deflake TestRangeFeedMetricsManagement
The 10s timeout is too tight, especially in race builds. Use the SucceedsSoon helper instead, which defaults to 45s, or higher in race builds. Epic: none Release note: none
1 parent 7189668 commit 1437883

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -558,12 +558,12 @@ func TestRangeFeedMetricsManagement(t *testing.T) {
558558

559559
// Wait for the test frontier to advance. Once it advances,
560560
// we know the rangefeed is started, all ranges are running (even if some of them are blocked).
561-
testutils.SucceedsWithin(t, func() error {
561+
testutils.SucceedsSoon(t, func() error {
562562
if frontier.Frontier().IsEmpty() {
563563
return errors.Newf("waiting for frontier advance: %s", frontier.String())
564564
}
565565
return nil
566-
}, 10*time.Second)
566+
})
567567

568568
// At this point, we know the rangefeed for all ranges are running.
569569
require.EqualValues(t, numRanges, metrics.RangefeedRanges.Value(), frontier.String())

0 commit comments

Comments
 (0)